upstream/mercurial-mirror Files · tests/test-atomictempfile.py

share: wrap bmstore._writerepo for transaction sensitivity (issue4940)...

share: wrap bmstore._writerepo for transaction sensitivity (issue4940) made 'bmstore.write()' transaction sensitive, to restore original bookmarks correctly at failure of a transaction. For example, shelve and unshelve imply steps below: before 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' writes updated ones into .hg/bookmarks 3. rollback transaction to remove internal commits 4. restore updated bookmarks manually after 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' doesn't write updated ones into .hg/bookmarks (these are written into .hg/bookmarks.pending, if external hook is spawn) 3. rollback transaction to remove internal commits 4. .hg/bookmarks should be clean, because it isn't changed while transaction running: see (2) above But if shelve or unshelve is executed in the repository created with "shared bookmarks" ("hg share -B"), this doesn't work as expected, because: - share extension makes 'bmstore.write()' write updated bookmarks into .hg/bookmarks of shared source repository regardless of transaction activity, and - intentional transaction failure at the end of shelve/unshelve doesn't restore already updated .hg/bookmarks of shared source This patch makes share extension wrap 'bmstore._writerepo()' instead of 'bmstore.write()', because the former is used to actually write bookmark changes out.

Idan Kamara - - Load All Authors

File last commit:

r18666:fb9d1c28 default


                r26933:a7eecd02

stable

Download file

             test-atomictempfile.py
        
                    42 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-atomictempfile.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import os

      import glob

      import unittest

      import silenttestrunner

      from mercurial.util import atomictempfile

      class testatomictempfile(unittest.TestCase):

          def test1_simple(self):

              if os.path.exists('foo'):

                  os.remove('foo')

              file = atomictempfile('foo')

              (dir, basename) = os.path.split(file._tempname)

              self.assertFalse(os.path.isfile('foo'))

              self.assertTrue(basename in glob.glob('.foo-*'))

              file.write('argh\n')

              file.close()

              self.assertTrue(os.path.isfile('foo'))

              self.assertTrue(basename not in glob.glob('.foo-*'))

          # discard() removes the temp file without making the write permanent

          def test2_discard(self):

              if os.path.exists('foo'):

                  os.remove('foo')

              file = atomictempfile('foo')

              (dir, basename) = os.path.split(file._tempname)

              file.write('yo\n')

              file.discard()

              self.assertFalse(os.path.isfile('foo'))

              self.assertTrue(basename not in os.listdir('.'))

          # if a programmer screws up and passes bad args to atomictempfile, they

          # get a plain ordinary TypeError, not infinite recursion

          def test3_oops(self):

              self.assertRaises(TypeError, atomictempfile)

      if __name__ == '__main__':

          silenttestrunner.main(__name__)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import os
				import glob
				import unittest
				import silenttestrunner

				from mercurial.util import atomictempfile

				class testatomictempfile(unittest.TestCase):
				def test1_simple(self):
				if os.path.exists('foo'):
				os.remove('foo')
				file = atomictempfile('foo')
				(dir, basename) = os.path.split(file._tempname)
				self.assertFalse(os.path.isfile('foo'))
				self.assertTrue(basename in glob.glob('.foo-*'))

				file.write('argh\n')
				file.close()

				self.assertTrue(os.path.isfile('foo'))
				self.assertTrue(basename not in glob.glob('.foo-*'))

				# discard() removes the temp file without making the write permanent
				def test2_discard(self):
				if os.path.exists('foo'):
				os.remove('foo')
				file = atomictempfile('foo')
				(dir, basename) = os.path.split(file._tempname)

				file.write('yo\n')
				file.discard()

				self.assertFalse(os.path.isfile('foo'))
				self.assertTrue(basename not in os.listdir('.'))

				# if a programmer screws up and passes bad args to atomictempfile, they
				# get a plain ordinary TypeError, not infinite recursion
				def test3_oops(self):
				self.assertRaises(TypeError, atomictempfile)

				if __name__ == '__main__':
				silenttestrunner.main(__name__)