upstream/mercurial-mirror Files · tests/test-bad-extension.t

share: wrap bmstore._writerepo for transaction sensitivity (issue4940)...

share: wrap bmstore._writerepo for transaction sensitivity (issue4940) made 'bmstore.write()' transaction sensitive, to restore original bookmarks correctly at failure of a transaction. For example, shelve and unshelve imply steps below: before 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' writes updated ones into .hg/bookmarks 3. rollback transaction to remove internal commits 4. restore updated bookmarks manually after 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' doesn't write updated ones into .hg/bookmarks (these are written into .hg/bookmarks.pending, if external hook is spawn) 3. rollback transaction to remove internal commits 4. .hg/bookmarks should be clean, because it isn't changed while transaction running: see (2) above But if shelve or unshelve is executed in the repository created with "shared bookmarks" ("hg share -B"), this doesn't work as expected, because: - share extension makes 'bmstore.write()' write updated bookmarks into .hg/bookmarks of shared source repository regardless of transaction activity, and - intentional transaction failure at the end of shelve/unshelve doesn't restore already updated .hg/bookmarks of shared source This patch makes share extension wrap 'bmstore._writerepo()' instead of 'bmstore.write()', because the former is used to actually write bookmark changes out.

timeless@mozdev.org - - Load All Authors

File last commit:

r26239:f3995366 default


                r26933:a7eecd02

stable

Download file

             test-bad-extension.t
        
                    40 lines
            
             | 1.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-bad-extension.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ echo 'raise Exception("bit bucket overflow")' > badext.py

        $ abspath=`pwd`/badext.py

        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > gpg =

        > hgext.gpg =

        > badext = $abspath

        > badext2 =

        > EOF

        $ hg -q help help 2>&1 |grep extension

        *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow

        *** failed to import extension badext2: No module named badext2

      show traceback

        $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError'

        *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow

        Traceback (most recent call last):

        Exception: bit bucket overflow

        *** failed to import extension badext2: No module named badext2

        Traceback (most recent call last):

        ImportError: No module named badext2

      show traceback for ImportError of hgext.name if debug is set

      (note that --debug option isn't applied yet when loading extensions)

        $ (hg -q help help --traceback --config ui.debug=True 2>&1) \

        > | grep -v '^ ' \

        > | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import'

        *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow

        Traceback (most recent call last):

        Exception: bit bucket overflow

        could not import hgext.badext2 (No module named badext2): trying badext2

        Traceback (most recent call last):

        ImportError: No module named badext2

        *** failed to import extension badext2: No module named badext2

        Traceback (most recent call last):

        ImportError: No module named badext2

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ echo 'raise Exception("bit bucket overflow")' > badext.py
				$ abspath=`pwd`/badext.py

				$ cat <<EOF >> $HGRCPATH
				> [extensions]
				> gpg =
				> hgext.gpg =
				> badext = $abspath
				> badext2 =
				> EOF

				$ hg -q help help 2>&1 \|grep extension
				*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
				*** failed to import extension badext2: No module named badext2

				show traceback

				$ hg -q help help --traceback 2>&1 \| egrep ' extension\|^Exception\|Traceback\|ImportError'
				*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
				Traceback (most recent call last):
				Exception: bit bucket overflow
				*** failed to import extension badext2: No module named badext2
				Traceback (most recent call last):
				ImportError: No module named badext2

				show traceback for ImportError of hgext.name if debug is set
				(note that --debug option isn't applied yet when loading extensions)

				$ (hg -q help help --traceback --config ui.debug=True 2>&1) \
				> \| grep -v '^ ' \
				> \| egrep 'extension..[^p]\|^Exception\|Traceback\|ImportError\|not import'
				*** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
				Traceback (most recent call last):
				Exception: bit bucket overflow
				could not import hgext.badext2 (No module named badext2): trying badext2
				Traceback (most recent call last):
				ImportError: No module named badext2
				*** failed to import extension badext2: No module named badext2
				Traceback (most recent call last):
				ImportError: No module named badext2