upstream/mercurial-mirror Files · tests/test-extra-filelog-entry.t

share: wrap bmstore._writerepo for transaction sensitivity (issue4940)...

share: wrap bmstore._writerepo for transaction sensitivity (issue4940) made 'bmstore.write()' transaction sensitive, to restore original bookmarks correctly at failure of a transaction. For example, shelve and unshelve imply steps below: before 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' writes updated ones into .hg/bookmarks 3. rollback transaction to remove internal commits 4. restore updated bookmarks manually after 46dec89fe888: 1. move active bookmark forward at internal rebasing 2. 'bmstore.write()' doesn't write updated ones into .hg/bookmarks (these are written into .hg/bookmarks.pending, if external hook is spawn) 3. rollback transaction to remove internal commits 4. .hg/bookmarks should be clean, because it isn't changed while transaction running: see (2) above But if shelve or unshelve is executed in the repository created with "shared bookmarks" ("hg share -B"), this doesn't work as expected, because: - share extension makes 'bmstore.write()' write updated bookmarks into .hg/bookmarks of shared source repository regardless of transaction activity, and - intentional transaction failure at the end of shelve/unshelve doesn't restore already updated .hg/bookmarks of shared source This patch makes share extension wrap 'bmstore._writerepo()' instead of 'bmstore.write()', because the former is used to actually write bookmark changes out.

Bryan O'Sullivan - - Load All Authors

File last commit:

r17132:b87acfda default


                r26933:a7eecd02

stable

Download file

             test-extra-filelog-entry.t
        
                    21 lines
            
             | 448 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-extra-filelog-entry.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Issue351: mq: qrefresh can create extra revlog entry

        $ echo "[extensions]" >> $HGRCPATH

        $ echo "mq=" >> $HGRCPATH

        $ hg init

        $ hg qinit

        $ echo b > b

        $ hg ci -A -m foo

        adding b

        $ echo cc > b

        $ hg qnew -f foo.diff

        $ echo b > b

        $ hg qrefresh

        $ hg debugindex b

           rev    offset  length  ..... linkrev nodeid       p1           p2 (re)

             0         0       3  .....       0 1e88685f5dde 000000000000 000000000000 (re)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Issue351: mq: qrefresh can create extra revlog entry

				$ echo "[extensions]" >> $HGRCPATH
				$ echo "mq=" >> $HGRCPATH

				$ hg init
				$ hg qinit

				$ echo b > b
				$ hg ci -A -m foo
				adding b

				$ echo cc > b
				$ hg qnew -f foo.diff
				$ echo b > b
				$ hg qrefresh

				$ hg debugindex b
				rev offset length ..... linkrev nodeid p1 p2 (re)
				0 0 3 ..... 0 1e88685f5dde 000000000000 000000000000 (re)