upstream/mercurial-mirror Files · rust/hg-core/src/re2/rust_re2.cpp

rust-regex: fix issues with regex anchoring and performance...

rust-regex: fix issues with regex anchoring and performance It turns out that the way I tried to work around `regex`'s behavior difference with `re2` and Python's `re` was 1) buggy and 2) much more complicated than needed. In a few words: `regex` adds `.*` on either side of patterns when no start or end anchor is present. My previous workaround put `^` or `$` for every pattern, which is wrong even without the other 2 bugs on top of it. Using `^(?:<patterns>)` right at the end of the `regex` path fixes the issue. I've opened an issue to get a build option instead: https://github.com/rust-lang/regex/issues/675 Differential Revision: https://phab.mercurial-scm.org/D8506

Raphaël Gomès - - Load All Authors

File last commit:

r44786:d8d4fa9a default


                r45347:ad1ec409

default

Download file

             rust_re2.cpp
        
                    49 lines
            
             | 1.1 KiB
            
                | text/x-c
            
             |
                CppLexer
            
             / rust / hg-core / src / re2 / rust_re2.cpp
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      /*

      rust_re2.cpp

      C ABI export of Re2's C++ interface for Rust FFI.

      Copyright 2020 Valentin Gatien-Baron

      This software may be used and distributed according to the terms of the

      GNU General Public License version 2 or any later version.

      */

      #include <re2/re2.h>

      using namespace re2;

      extern "C" {

      	RE2* rust_re2_create(const char* data, size_t len) {

      		RE2::Options o;

      		o.set_encoding(RE2::Options::Encoding::EncodingLatin1);

      		o.set_log_errors(false);

      		o.set_max_mem(50000000);

      		return new RE2(StringPiece(data, len), o);

      	}

      	void rust_re2_destroy(RE2* re) {

      		delete re;

      	}

      	bool rust_re2_ok(RE2* re) {

      		return re->ok();

      	}

      	void rust_re2_error(RE2* re, const char** outdata, size_t* outlen) {

      		const std::string& e = re->error();

      		*outdata = e.data();

      		*outlen = e.length();

      	}

      	bool rust_re2_match(RE2* re, char* data, size_t len, int ianchor) {

      		const StringPiece sp = StringPiece(data, len);

      		RE2::Anchor anchor =

      			ianchor == 0 ? RE2::Anchor::UNANCHORED :

      			(ianchor == 1 ? RE2::Anchor::ANCHOR_START :

      			 RE2::Anchor::ANCHOR_BOTH);

      		return re->Match(sp, 0, len, anchor, NULL, 0);

      	}

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				/*
				rust_re2.cpp

				C ABI export of Re2's C++ interface for Rust FFI.

				Copyright 2020 Valentin Gatien-Baron

				This software may be used and distributed according to the terms of the
				GNU General Public License version 2 or any later version.
				*/

				#include <re2/re2.h>
				using namespace re2;

				extern "C" {
				RE2* rust_re2_create(const char* data, size_t len) {
				RE2::Options o;
				o.set_encoding(RE2::Options::Encoding::EncodingLatin1);
				o.set_log_errors(false);
				o.set_max_mem(50000000);

				return new RE2(StringPiece(data, len), o);
				}

				void rust_re2_destroy(RE2* re) {
				delete re;
				}

				bool rust_re2_ok(RE2* re) {
				return re->ok();
				}

				void rust_re2_error(RE2* re, const char** outdata, size_t* outlen) {
				const std::string& e = re->error();
				*outdata = e.data();
				*outlen = e.length();
				}

				bool rust_re2_match(RE2* re, char* data, size_t len, int ianchor) {
				const StringPiece sp = StringPiece(data, len);

				RE2::Anchor anchor =
				ianchor == 0 ? RE2::Anchor::UNANCHORED :
				(ianchor == 1 ? RE2::Anchor::ANCHOR_START :
				RE2::Anchor::ANCHOR_BOTH);

				return re->Match(sp, 0, len, anchor, NULL, 0);
				}
				}