##// END OF EJS Templates
vfs: simplify the `abstractvfs.rename()` implementation...
vfs: simplify the `abstractvfs.rename()` implementation PyCharm was yapping about `util.rename()` not returning anything, because it is typed to return `None`, but the value was captured and returned after calling `_avoidambig()`. Instead, drop all of that, unconditionally rename, and then call `_avoidambig()` if appropriate. While we're here, convert the ersatz ternary operator into a modern one to help pytype. When a variable is initialized the old way, pytype tends to assign the type of the LHS of the `and`. In this case, that's a bool, and it will get confused that bool doesn't have a `stat` attribute once this method gets more type annotations. (Currently it thinks the `checkambig` arg is `Any`, so it doesn't care.)
Matt Harbison -
r52778:adbb183c default
Show More
Name Size Modified Last Commit Author
/ mercurial / thirdparty / attr
LICENSE Loading ...
__init__.py Loading ...
__init__.pyi Loading ...
_cmp.py Loading ...
_cmp.pyi Loading ...
_compat.py Loading ...
_config.py Loading ...
_funcs.py Loading ...
_make.py Loading ...
_next_gen.py Loading ...
_version_info.py Loading ...
_version_info.pyi Loading ...
converters.py Loading ...
converters.pyi Loading ...
exceptions.py Loading ...
exceptions.pyi Loading ...
filters.py Loading ...
filters.pyi Loading ...
py.typed Loading ...
setters.py Loading ...
setters.pyi Loading ...
validators.py Loading ...
validators.pyi Loading ...