upstream/mercurial-mirror Files · contrib/casesmash.py

errors: catch urllib errors specifically instead of using safehasattr()...

errors: catch urllib errors specifically instead of using safehasattr() Before this patch, we would catch `IOError` and `OSError` and check if the instance had a `.code` member (indicates `HTTPError`) or a `.reason` member (indicates the more generic `URLError`). It seems to me that can simply catch those exception specifically instead, so that's what this code does. The existing code is from (commands: report http exceptions nicely, 2005-06-17), so I suspect it's just that there was no `urllib2` (where `URLError` lives) back then. The old code mentioned `SSLError` in a comment. The new code does *not* try to catch that. The documentation for `ssl.SSLError` says that it has a `.reason` property, but `python -c 'import ssl; print(dir(ssl.SSLError("foo", Exception("bar"))))` doesn't mention that property on either Python 2 or Python 3 on my system. It also seems that `sslutil` is pretty careful about converting `ssl.SSLError` to `error.Abort`. It also is carefult to not assume that instances of the exception have a `.reason`. So I at least don't want to catch `ssl.SSLError` and handle it the same way as `URLError` because that would likely result in a crash. I also wonder if we don't need to handle it at all (because `sslutil` might handle all the cases). It's now early in the release cycle, so perhaps we can just see how it goes? Differential Revision: https://phab.mercurial-scm.org/D9318

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r46442:ae00e170

default

Download file

             casesmash.py
        
                    41 lines
            
             | 934 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / casesmash.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import

      import __builtin__

      import os

      from mercurial import util

      def lowerwrap(scope, funcname):

          f = getattr(scope, funcname)

          def wrap(fname, *args, **kwargs):

              d, base = os.path.split(fname)

              try:

                  files = os.listdir(d or '.')

              except OSError:

                  files = []

              if base in files:

                  return f(fname, *args, **kwargs)

              for fn in files:

                  if fn.lower() == base.lower():

                      return f(os.path.join(d, fn), *args, **kwargs)

              return f(fname, *args, **kwargs)

          scope.__dict__[funcname] = wrap

      def normcase(path):

          return path.lower()

      os.path.normcase = normcase

      for f in 'file open'.split():

          lowerwrap(__builtin__, f)

      for f in "chmod chown open lstat stat remove unlink".split():

          lowerwrap(os, f)

      for f in "exists lexists".split():

          lowerwrap(os.path, f)

      lowerwrap(util, 'posixfile')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import
				import __builtin__
				import os
				from mercurial import util


				def lowerwrap(scope, funcname):
				f = getattr(scope, funcname)

				def wrap(fname, args, *kwargs):
				d, base = os.path.split(fname)
				try:
				files = os.listdir(d or '.')
				except OSError:
				files = []
				if base in files:
				return f(fname, args, *kwargs)
				for fn in files:
				if fn.lower() == base.lower():
				return f(os.path.join(d, fn), args, *kwargs)
				return f(fname, args, *kwargs)

				scope.__dict__[funcname] = wrap


				def normcase(path):
				return path.lower()


				os.path.normcase = normcase

				for f in 'file open'.split():
				lowerwrap(__builtin__, f)

				for f in "chmod chown open lstat stat remove unlink".split():
				lowerwrap(os, f)

				for f in "exists lexists".split():
				lowerwrap(os.path, f)

				lowerwrap(util, 'posixfile')