upstream/mercurial-mirror Files · contrib/tcsh_completion_build.sh

merge: mark file gets as not thread safe (issue5933)...

merge: mark file gets as not thread safe (issue5933) In default installs, this has the effect of disabling the thread-based worker on Windows when manifesting files in the working directory. My measurements have shown that with revlog-based repositories, Mercurial spends a lot of CPU time in revlog code resolving file data. This ends up incurring a lot of context switching across threads and slows down `hg update` operations when going from an empty working directory to the tip of the repo. On mozilla-unified (246,351 files) on an i7-6700K (4+4 CPUs): before: 487s wall after: 360s wall (equivalent to worker.enabled=false) cpus=2: 379s wall Even with only 2 threads, the thread pool is still slower. The introduction of the thread-based worker (02b36e860e0b) states that it resulted in a "~50%" speedup for `hg sparse --enable-profile` and `hg sparse --disable-profile`. This disagrees with my measurement above. I theorize a few reasons for this: 1) Removal of files from the working directory is I/O - not CPU - bound and should benefit from a thread pool (unless I/O is insanely fast and the GIL release is near instantaneous). So tests like `hg sparse --enable-profile` may exercise deletion throughput and aren't good benchmarks for worker tasks that are CPU heavy. 2) The patch was authored by someone at Facebook. The results were likely measured against a repository using remotefilelog. And I believe that revision retrieval during working directory updates with remotefilelog will often use a remote store, thus being I/O and not CPU bound. This probably resulted in an overstated performance gain. Since there appears to be a need to enable the thread-based worker with some stores, I've made the flagging of file gets as thread safe configurable. I've made it experimental because I don't want to formalize a boolean flag for this option and because this attribute is best captured against the store implementation. But we don't have a proper store API for this yet. I'd rather cross this bridge later. It is possible there are revlog-based repositories that do benefit from a thread-based worker. I didn't do very comprehensive testing. If there are, we may want to devise a more proper algorithm for whether to use the thread-based worker, including possibly config options to limit the number of threads to use. But until I see evidence that justifies complexity, simplicity wins. Differential Revision: https://phab.mercurial-scm.org/D3963

Gilles Moris - - Load All Authors

File last commit:

r13515:26163257 1.8 stable


                r38755:be498426

default

Download file

             tcsh_completion_build.sh
        
                    74 lines
            
             | 1.9 KiB
            
                | application/x-sh
            
             |
                BashLexer
            
             / contrib / tcsh_completion_build.sh
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/bin/sh

      #

      # tcsh_completion_build.sh - script to generate tcsh completion

      #

      #

      # Copyright (C) 2005 TK Soh.

      #

      # This is free software; you can redistribute it and/or modify it under

      # the terms of the GNU General Public License as published by the Free

      # Software Foundation; either version 2 of the License, or (at your

      # option) any later version.

      #

      #

      # Description

      # -----------

      # This script generates a tcsh source file to support completion

      # of Mercurial commands and options.

      #

      # Instruction:

      # -----------

      # Run this script to generate the tcsh source file, and source

      # the file to add command completion support for Mercurial.

      #

      #    tcsh% tcsh_completion.sh FILE

      #    tcsh% source FILE

      #

      # If FILE is not specified, tcsh_completion will be generated.

      #

      # Bugs:

      # ----

      # 1. command specific options are not supported

      # 2. hg commands must be specified immediately after 'hg'.

      #

      tcsh_file=${1-tcsh_completion}

      hg_commands=`hg --debug help | \

              sed -e '1,/^list of commands:/d' \

                  -e '/^enabled extensions:/,$d' \

                  -e '/^additional help topics:/,$d' \

                  -e '/^ [^ ]/!d; s/[,:]//g;' | \

              xargs -n5 | \

              sed -e '$!s/$/ \\\\/g; 2,$s/^ */    /g'`

      hg_global_options=`hg -v help | \

              sed -e '1,/global/d;/^ *-/!d; s/ [^- ].*//' | \

              sed -e 's/ *$//; $!s/$/ \\\\/g; 2,$s/^ */    /g'`

      hg_version=`hg version | sed -e '1q'`

      script_name=`basename $0`

      cat > $tcsh_file <<END

      #

      # tcsh completion for Mercurial

      #

      # This file has been auto-generated by $script_name for

      # $hg_version

      #

      # Copyright (C) 2005 TK Soh.

      #

      # This is free software; you can redistribute it and/or modify it under

      # the terms of the GNU General Public License as published by the Free

      # Software Foundation; either version 2 of the License, or (at your

      # option) any later version.

      #

      complete hg \\

        'n/--cwd/d/' 'n/-R/d/' 'n/--repository/d/' \\

        'C/-/($hg_global_options)/' \\

        'p/1/($hg_commands)/'

      END

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/bin/sh

				#
				# tcsh_completion_build.sh - script to generate tcsh completion
				#
				#
				# Copyright (C) 2005 TK Soh.
				#
				# This is free software; you can redistribute it and/or modify it under
				# the terms of the GNU General Public License as published by the Free
				# Software Foundation; either version 2 of the License, or (at your
				# option) any later version.
				#
				#
				# Description
				# -----------
				# This script generates a tcsh source file to support completion
				# of Mercurial commands and options.
				#
				# Instruction:
				# -----------
				# Run this script to generate the tcsh source file, and source
				# the file to add command completion support for Mercurial.
				#
				# tcsh% tcsh_completion.sh FILE
				# tcsh% source FILE
				#
				# If FILE is not specified, tcsh_completion will be generated.
				#
				# Bugs:
				# ----
				# 1. command specific options are not supported
				# 2. hg commands must be specified immediately after 'hg'.
				#

				tcsh_file=${1-tcsh_completion}

				hg_commands=`hg --debug help \| \
				sed -e '1,/^list of commands:/d' \
				-e '/^enabled extensions:/,$d' \
				-e '/^additional help topics:/,$d' \
				-e '/^ [^ ]/!d; s/[,:]//g;' \| \
				xargs -n5 \| \
				sed -e '$!s/$/ \\\\/g; 2,$s/^ */ /g'`

				hg_global_options=`hg -v help \| \
				sed -e '1,/global/d;/^ -/!d; s/ [^- ].//' \| \
				sed -e 's/ $//; $!s/$/ \\\\/g; 2,$s/^ / /g'`

				hg_version=`hg version \| sed -e '1q'`

				script_name=`basename $0`

				cat > $tcsh_file <<END
				#
				# tcsh completion for Mercurial
				#
				# This file has been auto-generated by $script_name for
				# $hg_version
				#
				# Copyright (C) 2005 TK Soh.
				#
				# This is free software; you can redistribute it and/or modify it under
				# the terms of the GNU General Public License as published by the Free
				# Software Foundation; either version 2 of the License, or (at your
				# option) any later version.
				#

				complete hg \\
				'n/--cwd/d/' 'n/-R/d/' 'n/--repository/d/' \\
				'C/-/($hg_global_options)/' \\
				'p/1/($hg_commands)/'

				END