##// END OF EJS Templates
copies: stop attempt to avoid extra dict copies around branching...
copies: stop attempt to avoid extra dict copies around branching In the python code, we attempt to avoid unnecessary dict copies when gathering copy information. However that logic is wobbly and I keep running into case where independent branches affects each others. With the current code we can't ensure we are the only "user" of dict when dealing with merge. This caused havoc in the next series on tests I am about to introduce. So for now I am disabling the faulty optimisation. I believe we will need a dedicated overlay to deal with the "copy on write logic" to have something correct. I am also hoping to find time to build dedicated test case for this category of problem instead of relying on side effect in other tests. However for now I am focussing on another issue. Differential Revision: https://phab.mercurial-scm.org/D9608

File last commit:

r46782:8a491439 default
r46800:cb8b2ee8 default
Show More
repo.rs
92 lines | 2.4 KiB | application/rls-services+xml | RustLexer
use crate::operations::{find_root, FindRootError};
use crate::requirements;
use memmap::{Mmap, MmapOptions};
use std::path::{Path, PathBuf};
/// A repository on disk
pub struct Repo {
working_directory: PathBuf,
dot_hg: PathBuf,
store: PathBuf,
}
/// Filesystem access abstraction for the contents of a given "base" diretory
#[derive(Clone, Copy)]
pub(crate) struct Vfs<'a> {
base: &'a Path,
}
impl Repo {
/// Returns `None` if the given path doesn’t look like a repository
/// (doesn’t contain a `.hg` sub-directory).
pub fn for_path(root: impl Into<PathBuf>) -> Self {
let working_directory = root.into();
let dot_hg = working_directory.join(".hg");
Self {
store: dot_hg.join("store"),
dot_hg,
working_directory,
}
}
pub fn find() -> Result<Self, FindRootError> {
find_root().map(Self::for_path)
}
pub fn check_requirements(
&self,
) -> Result<(), requirements::RequirementsError> {
requirements::check(self)
}
pub fn working_directory_path(&self) -> &Path {
&self.working_directory
}
/// For accessing repository files (in `.hg`), except for the store
/// (`.hg/store`).
pub(crate) fn hg_vfs(&self) -> Vfs<'_> {
Vfs { base: &self.dot_hg }
}
/// For accessing repository store files (in `.hg/store`)
pub(crate) fn store_vfs(&self) -> Vfs<'_> {
Vfs { base: &self.store }
}
/// For accessing the working copy
// The undescore prefix silences the "never used" warning. Remove before
// using.
pub(crate) fn _working_directory_vfs(&self) -> Vfs<'_> {
Vfs {
base: &self.working_directory,
}
}
}
impl Vfs<'_> {
pub(crate) fn read(
&self,
relative_path: impl AsRef<Path>,
) -> std::io::Result<Vec<u8>> {
std::fs::read(self.base.join(relative_path))
}
pub(crate) fn open(
&self,
relative_path: impl AsRef<Path>,
) -> std::io::Result<std::fs::File> {
std::fs::File::open(self.base.join(relative_path))
}
pub(crate) fn mmap_open(
&self,
relative_path: impl AsRef<Path>,
) -> std::io::Result<Mmap> {
let file = self.open(relative_path)?;
// TODO: what are the safety requirements here?
let mmap = unsafe { MmapOptions::new().map(&file) }?;
Ok(mmap)
}
}