upstream/mercurial-mirror Files · mercurial/bitmanipulation.h

ui: restore behavior to ignore some I/O errors (issue5658)...

ui: restore behavior to ignore some I/O errors (issue5658) and refactored ui methods to no longer silently swallow some IOError instances. This is arguably the correct thing to do. However, it had the unfortunate side-effect of causing StdioError to bubble up to sensitive code like transaction aborts, leading to an uncaught exceptions and failures to e.g. roll back a transaction. This could occur when a remote HTTP or SSH client connection dropped. The new behavior is resulting in semi-frequent "abandonded transaction" errors on multiple high-volume repositories at Mozilla. This commit effectively reverts and to restore the old behavior. I agree with the principle that I/O errors shouldn't be ignored. That makes this change... unfortunate. However, our hands are tied for what to do on stable. I think the proper solution is for the ui's behavior to be configurable (possibly via a context manager). During critical sections like transaction rollback and abort, it should be possible to suppress errors. But this feature would not be appropriate on stable.

Martin von Zweigbergk - - Load All Authors

File last commit:

r32646:b4356d1c default


                r33859:cde4cfeb

stable

Download file

             bitmanipulation.h
        
                    55 lines
            
             | 954 B
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / bitmanipulation.h
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #ifndef _HG_BITMANIPULATION_H_

      #define _HG_BITMANIPULATION_H_

      #include <string.h>

      #include "compat.h"

      static inline uint32_t getbe32(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 24) |

      		(d[1] << 16) |

      		(d[2] << 8) |

      		(d[3]));

      }

      static inline int16_t getbeint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline uint16_t getbeuint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline void putbe32(uint32_t x, char *c)

      {

      	c[0] = (x >> 24) & 0xff;

      	c[1] = (x >> 16) & 0xff;

      	c[2] = (x >> 8) & 0xff;

      	c[3] = (x) & 0xff;

      }

      static inline double getbefloat64(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	double ret;

      	int i;

      	uint64_t t = 0;

      	for (i = 0; i < 8; i++) {

      		t = (t<<8) + d[i];

      	}

      	memcpy(&ret, &t, sizeof(t));

      	return ret;

      }

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#ifndef _HG_BITMANIPULATION_H_
				#define _HG_BITMANIPULATION_H_

				#include <string.h>

				#include "compat.h"

				static inline uint32_t getbe32(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 24) \|
				(d[1] << 16) \|
				(d[2] << 8) \|
				(d[3]));
				}

				static inline int16_t getbeint16(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 8) \|
				(d[1]));
				}

				static inline uint16_t getbeuint16(const char *c)
				{
				const unsigned char d = (const unsigned char )c;

				return ((d[0] << 8) \|
				(d[1]));
				}

				static inline void putbe32(uint32_t x, char *c)
				{
				c[0] = (x >> 24) & 0xff;
				c[1] = (x >> 16) & 0xff;
				c[2] = (x >> 8) & 0xff;
				c[3] = (x) & 0xff;
				}

				static inline double getbefloat64(const char *c)
				{
				const unsigned char d = (const unsigned char )c;
				double ret;
				int i;
				uint64_t t = 0;
				for (i = 0; i < 8; i++) {
				t = (t<<8) + d[i];
				}
				memcpy(&ret, &t, sizeof(t));
				return ret;
				}

				#endif