##// END OF EJS Templates
ui: restore behavior to ignore some I/O errors (issue5658)...
ui: restore behavior to ignore some I/O errors (issue5658) e9646ff34d55 and 1bfb9a63b98e refactored ui methods to no longer silently swallow some IOError instances. This is arguably the correct thing to do. However, it had the unfortunate side-effect of causing StdioError to bubble up to sensitive code like transaction aborts, leading to an uncaught exceptions and failures to e.g. roll back a transaction. This could occur when a remote HTTP or SSH client connection dropped. The new behavior is resulting in semi-frequent "abandonded transaction" errors on multiple high-volume repositories at Mozilla. This commit effectively reverts e9646ff34d55 and 1bfb9a63b98e to restore the old behavior. I agree with the principle that I/O errors shouldn't be ignored. That makes this change... unfortunate. However, our hands are tied for what to do on stable. I think the proper solution is for the ui's behavior to be configurable (possibly via a context manager). During critical sections like transaction rollback and abort, it should be possible to suppress errors. But this feature would not be appropriate on stable.
Gregory Szorc -
r33859:cde4cfeb stable
Show More
Name Size Modified Last Commit Author
/ mercurial / templates / static
background.png Loading ...
coal-file.png Loading ...
coal-folder.png Loading ...
excanvas.js Loading ...
feed-icon-14x14.png Loading ...
followlines.js Loading ...
hgicon.png Loading ...
hglogo.png Loading ...
mercurial.js Loading ...
style-extra-coal.css Loading ...
style-gitweb.css Loading ...
style-monoblue.css Loading ...
style-paper.css Loading ...
style.css Loading ...