##// END OF EJS Templates
bundlerepo: fix mismatches with repository and revlog classes...
bundlerepo: fix mismatches with repository and revlog classes Both pytype and PyCharm complained that `write()` and `_write()` in the bundlephasecache class aren't proper overrides- indeed they seem to be missing an argument that the base class has. PyCharm and pytype also complained that the `revlog.revlog` class doesn't have a `_chunk()` method. That looks like it was moved from revlog to `_InnerRevlog` back in e8ad6d8de8b8, and wasn't caught because this module wasn't type checked. However, I couldn't figure out a syntax with `revlog.revlog._inner._chunk(self, rev)`, as it complained about passing too many args. `bundlerevlog._rawtext()` uses this `super(...)` style to call the super class, so hopefully that works, even with the wonky dynamic subclassing. The revlog class needed the `_InnerRevlog` field typed because it isn't set in the constructor. Finally, the vfs type hints look broken. This initially failed with: File "/mnt/c/Users/Matt/hg/mercurial/bundlerepo.py", line 65, in __init__: Function readonlyvfs.__init__ was called with the wrong arguments [wrong-arg-types] Expected: (self, vfs: mercurial.vfs.vfs) Actually passed: (self, vfs: Callable) Called from (traceback): line 232, in dirlog line 214, in __init__ I don't see a raw Callable, but I tried changing some of the vfs args to be typed as `vfsmod.abstractvfs`, but that class doesn't have `options`, so it failed elsewhere. `readonlyvfs` isn't a subclass of `vfs` (it's a subclass of `abstractvfs`), so I'm not sure how to handle that. It would be a shame to have to make a union of vfs subclasses (but not all of them have `options` either).

File last commit:

r50408:467d9df9 default
r52764:cfd30df0 default
Show More
plain_info.rs
79 lines | 2.2 KiB | application/rls-services+xml | RustLexer
use crate::utils::files::get_bytes_from_os_string;
use std::env;
/// Keeps information on whether plain mode is active.
///
/// Plain mode means that all configuration variables which affect
/// the behavior and output of Mercurial should be
/// ignored. Additionally, the output should be stable,
/// reproducible and suitable for use in scripts or applications.
///
/// The only way to trigger plain mode is by setting either the
/// `HGPLAIN' or `HGPLAINEXCEPT' environment variables.
///
/// The return value can either be
/// - False if HGPLAIN is not set, or feature is in HGPLAINEXCEPT
/// - False if feature is disabled by default and not included in HGPLAIN
/// - True otherwise
#[derive(Clone)]
pub struct PlainInfo {
is_plain: bool,
except: Vec<Vec<u8>>,
}
impl PlainInfo {
fn plain_except(except: Vec<Vec<u8>>) -> Self {
PlainInfo {
is_plain: true,
except,
}
}
pub fn empty() -> PlainInfo {
PlainInfo {
is_plain: false,
except: vec![],
}
}
pub fn from_env() -> PlainInfo {
if let Some(except) = env::var_os("HGPLAINEXCEPT") {
PlainInfo::plain_except(
get_bytes_from_os_string(except)
.split(|&byte| byte == b',')
.map(|x| x.to_vec())
.collect(),
)
} else {
PlainInfo {
is_plain: env::var_os("HGPLAIN").is_some(),
except: vec![],
}
}
}
pub fn is_feature_plain(&self, feature: &str) -> bool {
return self.is_plain
&& !self
.except
.iter()
.any(|exception| exception.as_slice() == feature.as_bytes());
}
pub fn is_plain(&self) -> bool {
self.is_plain
}
pub fn plainalias(&self) -> bool {
self.is_feature_plain("alias")
}
pub fn plainrevsetalias(&self) -> bool {
self.is_feature_plain("revsetalias")
}
pub fn plaintemplatealias(&self) -> bool {
self.is_feature_plain("templatealias")
}
pub fn plaintweakdefaults(&self) -> bool {
self.is_feature_plain("tweakdefaults")
}
}