upstream/mercurial-mirror Files · tests/test-addremove-similar.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Matt Harbison - - Load All Authors

File last commit:

r23481:94091ab9 default


                r24158:d414c28d

stable

Download file

             test-addremove-similar.t
        
                    102 lines
            
             | 2.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-addremove-similar.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init rep; cd rep

        $ touch empty-file

        $ $PYTHON -c 'for x in range(10000): print x' > large-file

        $ hg addremove

        adding empty-file

        adding large-file

        $ hg commit -m A

        $ rm large-file empty-file

        $ $PYTHON -c 'for x in range(10,10000): print x' > another-file

        $ hg addremove -s50

        adding another-file

        removing empty-file

        removing large-file

        recording removal of large-file as rename to another-file (99% similar)

        $ hg commit -m B

      comparing two empty files caused ZeroDivisionError in the past

        $ hg update -C 0

        2 files updated, 0 files merged, 1 files removed, 0 files unresolved

        $ rm empty-file

        $ touch another-empty-file

        $ hg addremove -s50

        adding another-empty-file

        removing empty-file

        $ cd ..

        $ hg init rep2; cd rep2

        $ $PYTHON -c 'for x in range(10000): print x' > large-file

        $ $PYTHON -c 'for x in range(50): print x' > tiny-file

        $ hg addremove

        adding large-file

        adding tiny-file

        $ hg commit -m A

        $ $PYTHON -c 'for x in range(70): print x' > small-file

        $ rm tiny-file

        $ rm large-file

        $ hg addremove -s50

        removing large-file

        adding small-file

        removing tiny-file

        recording removal of tiny-file as rename to small-file (82% similar)

        $ hg commit -m B

      should all fail

        $ hg addremove -s foo

        abort: similarity must be a number

        [255]

        $ hg addremove -s -1

        abort: similarity must be between 0 and 100

        [255]

        $ hg addremove -s 1e6

        abort: similarity must be between 0 and 100

        [255]

        $ cd ..

      Issue1527: repeated addremove causes util.Abort

        $ hg init rep3; cd rep3

        $ mkdir d

        $ echo a > d/a

        $ hg add d/a

        $ hg commit -m 1

        $ mv d/a d/b

        $ hg addremove -s80

        removing d/a

        adding d/b

        recording removal of d/a as rename to d/b (100% similar) (glob)

        $ hg debugstate

        r   0          0 1970-01-01 00:00:00 d/a

        a   0         -1 unset               d/b

        copy: d/a -> d/b

        $ mv d/b c

      no copies found here (since the target isn't in d

        $ hg addremove -s80 d

        removing d/b (glob)

      copies here

        $ hg addremove -s80

        adding c

        recording removal of d/a as rename to c (100% similar) (glob)

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init rep; cd rep

				$ touch empty-file
				$ $PYTHON -c 'for x in range(10000): print x' > large-file

				$ hg addremove
				adding empty-file
				adding large-file

				$ hg commit -m A

				$ rm large-file empty-file
				$ $PYTHON -c 'for x in range(10,10000): print x' > another-file

				$ hg addremove -s50
				adding another-file
				removing empty-file
				removing large-file
				recording removal of large-file as rename to another-file (99% similar)

				$ hg commit -m B

				comparing two empty files caused ZeroDivisionError in the past

				$ hg update -C 0
				2 files updated, 0 files merged, 1 files removed, 0 files unresolved
				$ rm empty-file
				$ touch another-empty-file
				$ hg addremove -s50
				adding another-empty-file
				removing empty-file

				$ cd ..

				$ hg init rep2; cd rep2

				$ $PYTHON -c 'for x in range(10000): print x' > large-file
				$ $PYTHON -c 'for x in range(50): print x' > tiny-file

				$ hg addremove
				adding large-file
				adding tiny-file

				$ hg commit -m A

				$ $PYTHON -c 'for x in range(70): print x' > small-file
				$ rm tiny-file
				$ rm large-file

				$ hg addremove -s50
				removing large-file
				adding small-file
				removing tiny-file
				recording removal of tiny-file as rename to small-file (82% similar)

				$ hg commit -m B

				should all fail

				$ hg addremove -s foo
				abort: similarity must be a number
				[255]
				$ hg addremove -s -1
				abort: similarity must be between 0 and 100
				[255]
				$ hg addremove -s 1e6
				abort: similarity must be between 0 and 100
				[255]

				$ cd ..

				Issue1527: repeated addremove causes util.Abort

				$ hg init rep3; cd rep3
				$ mkdir d
				$ echo a > d/a
				$ hg add d/a
				$ hg commit -m 1

				$ mv d/a d/b
				$ hg addremove -s80
				removing d/a
				adding d/b
				recording removal of d/a as rename to d/b (100% similar) (glob)
				$ hg debugstate
				r 0 0 1970-01-01 00:00:00 d/a
				a 0 -1 unset d/b
				copy: d/a -> d/b
				$ mv d/b c

				no copies found here (since the target isn't in d

				$ hg addremove -s80 d
				removing d/b (glob)

				copies here

				$ hg addremove -s80
				adding c
				recording removal of d/a as rename to c (100% similar) (glob)

				$ cd ..