upstream/mercurial-mirror Files · tests/test-duplicateoptions.py

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Matt Mackall - - Load All Authors

File last commit:

r20622:352abbb0 default


                r24158:d414c28d

stable

Download file

             test-duplicateoptions.py
        
                    36 lines
            
             | 964 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-duplicateoptions.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      import os

      from mercurial import ui, commands, extensions

      ignore = set(['highlight', 'win32text', 'factotum'])

      if os.name != 'nt':

          ignore.add('win32mbcs')

      disabled = [ext for ext in extensions.disabled().keys() if ext not in ignore]

      hgrc = open(os.environ["HGRCPATH"], 'w')

      hgrc.write('[extensions]\n')

      for ext in disabled:

          hgrc.write(ext + '=\n')

      hgrc.close()

      u = ui.ui()

      extensions.loadall(u)

      globalshort = set()

      globallong = set()

      for option in commands.globalopts:

          option[0] and globalshort.add(option[0])

          option[1] and globallong.add(option[1])

      for cmd, entry in commands.table.iteritems():

          seenshort = globalshort.copy()

          seenlong = globallong.copy()

          for option in entry[1]:

              if (option[0] and option[0] in seenshort) or \

                 (option[1] and option[1] in seenlong):

                  print "command '" + cmd + "' has duplicate option " + str(option)

              seenshort.add(option[0])

              seenlong.add(option[1])

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				import os
				from mercurial import ui, commands, extensions

				ignore = set(['highlight', 'win32text', 'factotum'])

				if os.name != 'nt':
				ignore.add('win32mbcs')

				disabled = [ext for ext in extensions.disabled().keys() if ext not in ignore]

				hgrc = open(os.environ["HGRCPATH"], 'w')
				hgrc.write('[extensions]\n')

				for ext in disabled:
				hgrc.write(ext + '=\n')

				hgrc.close()

				u = ui.ui()
				extensions.loadall(u)

				globalshort = set()
				globallong = set()
				for option in commands.globalopts:
				option[0] and globalshort.add(option[0])
				option[1] and globallong.add(option[1])

				for cmd, entry in commands.table.iteritems():
				seenshort = globalshort.copy()
				seenlong = globallong.copy()
				for option in entry[1]:
				if (option[0] and option[0] in seenshort) or \
				(option[1] and option[1] in seenlong):
				print "command '" + cmd + "' has duplicate option " + str(option)
				seenshort.add(option[0])
				seenlong.add(option[1])