upstream/mercurial-mirror Files · tests/test-mq-symlinks.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r23749:a387b039 default


                r24158:d414c28d

stable

Download file

             test-mq-symlinks.t
        
                    111 lines
            
             | 1.8 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-mq-symlinks.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require symlink

        $ echo "[extensions]" >> $HGRCPATH

        $ echo "mq=" >> $HGRCPATH

        $ hg init

        $ hg qinit

        $ hg qnew base.patch

        $ echo aaa > a

        $ echo bbb > b

        $ echo ccc > c

        $ hg add a b c

        $ hg qrefresh

        $ "$TESTDIR/readlink.py" a

        a -> a not a symlink

      test replacing a file with a symlink

        $ hg qnew symlink.patch

        $ rm a

        $ ln -s b a

        $ hg qrefresh --git

        $ "$TESTDIR/readlink.py" a

        a -> b

        $ hg qpop

        popping symlink.patch

        now at: base.patch

        $ hg qpush

        applying symlink.patch

        now at: symlink.patch

        $ "$TESTDIR/readlink.py" a

        a -> b

      test updating a symlink

        $ rm a

        $ ln -s c a

        $ hg qnew --git -f updatelink

        $ "$TESTDIR/readlink.py" a

        a -> c

        $ hg qpop

        popping updatelink

        now at: symlink.patch

        $ hg qpush --debug

        applying updatelink

        patching file a

        committing files:

        a

        committing manifest

        committing changelog

        now at: updatelink

        $ "$TESTDIR/readlink.py" a

        a -> c

        $ hg st

      test replacing a symlink with a file

        $ ln -s c s

        $ hg add s

        $ hg qnew --git -f addlink

        $ rm s

        $ echo sss > s

        $ hg qnew --git -f replacelinkwithfile

        $ hg qpop

        popping replacelinkwithfile

        now at: addlink

        $ hg qpush

        applying replacelinkwithfile

        now at: replacelinkwithfile

        $ cat s

        sss

        $ hg st

      test symlink removal

        $ hg qnew removesl.patch

        $ hg rm a

        $ hg qrefresh --git

        $ hg qpop

        popping removesl.patch

        now at: replacelinkwithfile

        $ hg qpush

        applying removesl.patch

        now at: removesl.patch

        $ hg st -c

        C b

        C c

        C s

      replace broken symlink with another broken symlink

        $ ln -s linka linka

        $ hg add linka

        $ hg qnew link

        $ hg mv linka linkb

        $ rm linkb

        $ ln -s linkb linkb

        $ hg qnew movelink

        $ hg qpop

        popping movelink

        now at: link

        $ hg qpush

        applying movelink

        now at: movelink

        $ "$TESTDIR/readlink.py" linkb

        linkb -> linkb

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require symlink

				$ echo "[extensions]" >> $HGRCPATH
				$ echo "mq=" >> $HGRCPATH

				$ hg init
				$ hg qinit
				$ hg qnew base.patch
				$ echo aaa > a
				$ echo bbb > b
				$ echo ccc > c
				$ hg add a b c
				$ hg qrefresh
				$ "$TESTDIR/readlink.py" a
				a -> a not a symlink


				test replacing a file with a symlink

				$ hg qnew symlink.patch
				$ rm a
				$ ln -s b a
				$ hg qrefresh --git
				$ "$TESTDIR/readlink.py" a
				a -> b

				$ hg qpop
				popping symlink.patch
				now at: base.patch
				$ hg qpush
				applying symlink.patch
				now at: symlink.patch
				$ "$TESTDIR/readlink.py" a
				a -> b


				test updating a symlink

				$ rm a
				$ ln -s c a
				$ hg qnew --git -f updatelink
				$ "$TESTDIR/readlink.py" a
				a -> c
				$ hg qpop
				popping updatelink
				now at: symlink.patch
				$ hg qpush --debug
				applying updatelink
				patching file a
				committing files:
				a
				committing manifest
				committing changelog
				now at: updatelink
				$ "$TESTDIR/readlink.py" a
				a -> c
				$ hg st


				test replacing a symlink with a file

				$ ln -s c s
				$ hg add s
				$ hg qnew --git -f addlink
				$ rm s
				$ echo sss > s
				$ hg qnew --git -f replacelinkwithfile
				$ hg qpop
				popping replacelinkwithfile
				now at: addlink
				$ hg qpush
				applying replacelinkwithfile
				now at: replacelinkwithfile
				$ cat s
				sss
				$ hg st


				test symlink removal

				$ hg qnew removesl.patch
				$ hg rm a
				$ hg qrefresh --git
				$ hg qpop
				popping removesl.patch
				now at: replacelinkwithfile
				$ hg qpush
				applying removesl.patch
				now at: removesl.patch
				$ hg st -c
				C b
				C c
				C s

				replace broken symlink with another broken symlink

				$ ln -s linka linka
				$ hg add linka
				$ hg qnew link
				$ hg mv linka linkb
				$ rm linkb
				$ ln -s linkb linkb
				$ hg qnew movelink
				$ hg qpop
				popping movelink
				now at: link
				$ hg qpush
				applying movelink
				now at: movelink
				$ "$TESTDIR/readlink.py" linkb
				linkb -> linkb