upstream/mercurial-mirror Files · tests/test-push-validation.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r18506:ef60083b stable


                r24158:d414c28d

stable

Download file

             test-push-validation.t
        
                    92 lines
            
             | 1.9 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-push-validation.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init test

        $ cd test

        $ cat > .hg/hgrc <<EOF

        > [server]

        > validate=1

        > EOF

        $ echo alpha > alpha

        $ echo beta > beta

        $ hg addr

        adding alpha

        adding beta

        $ hg ci -m 1

        $ cd ..

        $ hg clone test test-clone

        updating to branch default

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

      Test spurious filelog entries:

        $ cd test-clone

        $ echo blah >> beta

        $ cp .hg/store/data/beta.i tmp1

        $ hg ci -m 2

        $ cp .hg/store/data/beta.i tmp2

        $ hg -q rollback

        $ mv tmp2 .hg/store/data/beta.i

        $ echo blah >> beta

        $ hg ci -m '2 (corrupt)'

      Expected to fail:

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

         beta@1: dddc47b3ba30 not in manifests

        2 files, 2 changesets, 4 total revisions

        1 integrity errors encountered!

        (first damaged changeset appears to be 1)

        [1]

        $ hg push

        pushing to $TESTTMP/test (glob)

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        transaction abort!

        rollback completed

        abort: received spurious file revlog entry

        [255]

        $ hg -q rollback

        $ mv tmp1 .hg/store/data/beta.i

        $ echo beta > beta

      Test missing filelog entries:

        $ cp .hg/store/data/beta.i tmp

        $ echo blah >> beta

        $ hg ci -m '2 (corrupt)'

        $ mv tmp .hg/store/data/beta.i

      Expected to fail:

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

         beta@1: dddc47b3ba30 in manifests not found

        2 files, 2 changesets, 2 total revisions

        1 integrity errors encountered!

        (first damaged changeset appears to be 1)

        [1]

        $ hg push

        pushing to $TESTTMP/test (glob)

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        transaction abort!

        rollback completed

        abort: missing file data for beta:dddc47b3ba30e54484720ce0f4f768a0f4b6efb9 - run hg verify

        [255]

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init test
				$ cd test

				$ cat > .hg/hgrc <<EOF
				> [server]
				> validate=1
				> EOF

				$ echo alpha > alpha
				$ echo beta > beta
				$ hg addr
				adding alpha
				adding beta
				$ hg ci -m 1

				$ cd ..
				$ hg clone test test-clone
				updating to branch default
				2 files updated, 0 files merged, 0 files removed, 0 files unresolved

				Test spurious filelog entries:

				$ cd test-clone
				$ echo blah >> beta
				$ cp .hg/store/data/beta.i tmp1
				$ hg ci -m 2
				$ cp .hg/store/data/beta.i tmp2
				$ hg -q rollback
				$ mv tmp2 .hg/store/data/beta.i
				$ echo blah >> beta
				$ hg ci -m '2 (corrupt)'

				Expected to fail:

				$ hg verify
				checking changesets
				checking manifests
				crosschecking files in changesets and manifests
				checking files
				beta@1: dddc47b3ba30 not in manifests
				2 files, 2 changesets, 4 total revisions
				1 integrity errors encountered!
				(first damaged changeset appears to be 1)
				[1]

				$ hg push
				pushing to $TESTTMP/test (glob)
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				transaction abort!
				rollback completed
				abort: received spurious file revlog entry
				[255]

				$ hg -q rollback
				$ mv tmp1 .hg/store/data/beta.i
				$ echo beta > beta

				Test missing filelog entries:

				$ cp .hg/store/data/beta.i tmp
				$ echo blah >> beta
				$ hg ci -m '2 (corrupt)'
				$ mv tmp .hg/store/data/beta.i

				Expected to fail:

				$ hg verify
				checking changesets
				checking manifests
				crosschecking files in changesets and manifests
				checking files
				beta@1: dddc47b3ba30 in manifests not found
				2 files, 2 changesets, 2 total revisions
				1 integrity errors encountered!
				(first damaged changeset appears to be 1)
				[1]

				$ hg push
				pushing to $TESTTMP/test (glob)
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				transaction abort!
				rollback completed
				abort: missing file data for beta:dddc47b3ba30e54484720ce0f4f768a0f4b6efb9 - run hg verify
				[255]

				$ cd ..