upstream/mercurial-mirror Files · tests/test-requires.t

largefiles: access to specific fields only if largefiles enabled (issue4547)...

largefiles: access to specific fields only if largefiles enabled (issue4547) Even if largefiles extension is enabled in a repository, "repo" object, which isn't "largefiles.reposetup()"-ed, is passed to overridden functions in the cases below unexpectedly, because extensions are enabled for each repositories strictly. (1) clone without -U: (2) pull with -U: (3) pull with --rebase: combination of "enabled@src", "disabled@dst" and "not-required@src" cause this situation. largefiles requirement @src @dst @src result -------- -------- --------------- -------------------- enabled disabled not-required aborted unexpectedly required requirement error (intentional) -------- -------- --------------- -------------------- enabled enabled * success -------- -------- --------------- -------------------- disabled enabled * success (only for "pull") -------- -------- --------------- -------------------- disabled disabled not-required success required requirement error (intentional) -------- -------- --------------- -------------------- (4) update/revert with a subrepo disabling largefiles In these cases, overridden functions cause accessing to largefiles specific fields of not "largefiles.reposetup()"-ed "repo" object, and execution is aborted. - (1), (2), (4) cause accessing to "_lfstatuswriters" in "getstatuswriter()" invoked via "updatelfiles()" - (3) causes accessing to "_lfcommithooks" in "overriderebase()" For safe accessing to these fields, this patch examines whether passed "repo" object is "largefiles.reposetup()"-ed or not before accessing to them. This patch chooses examining existence of newly introduced "_largefilesenabled" instead of "_lfcommithooks" and "_lfstatuswriters" directly, because the former is better name for the generic "largefiles is enabled in this repo" mark than the latter. In the future, all other overridden functions should avoid largefiles specific processing for efficiency, and "_largefilesenabled" is better also for such purpose. BTW, "lfstatus" can't be used for such purpose, because some code paths set it forcibly regardless of existence of it in specified "repo" object.

Mads Kiilerich - - Load All Authors

File last commit:

r20820:f8e531a3 default


                r24158:d414c28d

stable

Download file

             test-requires.t
        
                    72 lines
            
             | 2.2 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-requires.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init t

        $ cd t

        $ echo a > a

        $ hg add a

        $ hg commit -m test

        $ rm .hg/requires

        $ hg tip

        abort: index 00changelog.i unknown format 2!

        [255]

        $ echo indoor-pool > .hg/requires

        $ hg tip

        abort: repository requires features unknown to this Mercurial: indoor-pool!

        (see http://mercurial.selenic.com/wiki/MissingRequirement for more information)

        [255]

        $ echo outdoor-pool >> .hg/requires

        $ hg tip

        abort: repository requires features unknown to this Mercurial: indoor-pool outdoor-pool!

        (see http://mercurial.selenic.com/wiki/MissingRequirement for more information)

        [255]

        $ cd ..

      Test checking between features supported locally and ones required in

      another repository of push/pull/clone on localhost:

        $ mkdir supported-locally

        $ cd supported-locally

        $ hg init supported

        $ echo a > supported/a

        $ hg -R supported commit -Am '#0 at supported'

        adding a

        $ echo 'featuresetup-test' >> supported/.hg/requires

        $ cat > $TESTTMP/supported-locally/supportlocally.py <<EOF

        > from mercurial import localrepo, extensions

        > def featuresetup(ui, supported):

        >     for name, module in extensions.extensions(ui):

        >         if __name__ == module.__name__:

        >             # support specific feature locally

        >             supported |= set(['featuresetup-test'])

        >             return

        > def uisetup(ui):

        >     localrepo.localrepository.featuresetupfuncs.add(featuresetup)

        > EOF

        $ cat > supported/.hg/hgrc <<EOF

        > [extensions]

        > # enable extension locally

        > supportlocally = $TESTTMP/supported-locally/supportlocally.py

        > EOF

        $ hg -R supported status

        $ hg init push-dst

        $ hg -R supported push push-dst

        pushing to push-dst

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ hg init pull-src

        $ hg -R pull-src pull supported

        pulling from supported

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ hg clone supported clone-dst

        abort: repository requires features unknown to this Mercurial: featuresetup-test!

        (see http://mercurial.selenic.com/wiki/MissingRequirement for more information)

        [255]

        $ hg clone --pull supported clone-dst

        abort: required features are not supported in the destination: featuresetup-test

        [255]

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init t
				$ cd t
				$ echo a > a
				$ hg add a
				$ hg commit -m test
				$ rm .hg/requires
				$ hg tip
				abort: index 00changelog.i unknown format 2!
				[255]
				$ echo indoor-pool > .hg/requires
				$ hg tip
				abort: repository requires features unknown to this Mercurial: indoor-pool!
				(see http://mercurial.selenic.com/wiki/MissingRequirement for more information)
				[255]
				$ echo outdoor-pool >> .hg/requires
				$ hg tip
				abort: repository requires features unknown to this Mercurial: indoor-pool outdoor-pool!
				(see http://mercurial.selenic.com/wiki/MissingRequirement for more information)
				[255]
				$ cd ..

				Test checking between features supported locally and ones required in
				another repository of push/pull/clone on localhost:

				$ mkdir supported-locally
				$ cd supported-locally

				$ hg init supported
				$ echo a > supported/a
				$ hg -R supported commit -Am '#0 at supported'
				adding a

				$ echo 'featuresetup-test' >> supported/.hg/requires
				$ cat > $TESTTMP/supported-locally/supportlocally.py <<EOF
				> from mercurial import localrepo, extensions
				> def featuresetup(ui, supported):
				> for name, module in extensions.extensions(ui):
				> if __name__ == module.__name__:
				> # support specific feature locally
				> supported \|= set(['featuresetup-test'])
				> return
				> def uisetup(ui):
				> localrepo.localrepository.featuresetupfuncs.add(featuresetup)
				> EOF
				$ cat > supported/.hg/hgrc <<EOF
				> [extensions]
				> # enable extension locally
				> supportlocally = $TESTTMP/supported-locally/supportlocally.py
				> EOF
				$ hg -R supported status

				$ hg init push-dst
				$ hg -R supported push push-dst
				pushing to push-dst
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ hg init pull-src
				$ hg -R pull-src pull supported
				pulling from supported
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ hg clone supported clone-dst
				abort: repository requires features unknown to this Mercurial: featuresetup-test!
				(see http://mercurial.selenic.com/wiki/MissingRequirement for more information)
				[255]
				$ hg clone --pull supported clone-dst
				abort: required features are not supported in the destination: featuresetup-test
				[255]

				$ cd ..