upstream/mercurial-mirror Files · mercurial/revlogutils/concurrency_checker.py

lfs: fix various signature mismatches for vfs subclasses...

lfs: fix various signature mismatches for vfs subclasses These were flagged by PyCharm. I'm not sure why pytype doesn't catch these- only `hgext/lfs/__init__.py` in the lfs extension is excluded from being checked. I'm not sure if the `*insidef` arg to `join()` was meant as an internal convencience, because I see another class that gets flagged for the same signature problem (to be fixed next). But I don't feel bold enough to make this an internal function, and provide a simplified public `join()` on the `vfs` classes. That can still be done later, if desired. For now, process the additional args and pass them along, even though there don't appear to be any current callers that provide extra args to these classes. We need all of the subclasses to agree on the signature, or they won't be considered to implement the `Vfs` protocol being developed. While we're copy/pasting from the base class, bring the type annotations along for the ride.

Matt Harbison - - Load All Authors

File last commit:

r52757:1c5810ce default


                r52774:d6288776

default

Download file

             concurrency_checker.py
        
                    40 lines
            
             | 1.5 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / revlogutils / concurrency_checker.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import annotations

      from ..i18n import _

      from .. import error

      def get_checker(ui, revlog_name=b'changelog'):

          """Get a function that checks file handle position is as expected.

          This is used to ensure that files haven't been modified outside of our

          knowledge (such as on a networked filesystem, if `hg debuglocks` was used,

          or writes to .hg that ignored locks happened).

          Due to revlogs supporting a concept of buffered, delayed, or diverted

          writes, we're allowing the files to be shorter than expected (the data may

          not have been written yet), but they can't be longer.

          Please note that this check is not perfect; it can't detect all cases (there

          may be false-negatives/false-OKs), but it should never claim there's an

          issue when there isn't (false-positives/false-failures).

          """

          vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name)

          # Avoid any `fh.tell` cost if this isn't enabled.

          if not vpos or vpos not in [b'log', b'warn', b'fail']:

              return None

          def _checker(fh, fn, expected):

              if fh.tell() <= expected:

                  return

              msg = _(b'%s: file cursor at position %d, expected %d')

              # Always log if we're going to warn or fail.

              ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected)

              if vpos == b'warn':

                  ui.warn((msg + b'\n') % (fn, fh.tell(), expected))

              elif vpos == b'fail':

                  raise error.RevlogError(msg % (fn, fh.tell(), expected))

          return _checker

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import annotations

				from ..i18n import _
				from .. import error


				def get_checker(ui, revlog_name=b'changelog'):
				"""Get a function that checks file handle position is as expected.

				This is used to ensure that files haven't been modified outside of our
				knowledge (such as on a networked filesystem, if `hg debuglocks` was used,
				or writes to .hg that ignored locks happened).

				Due to revlogs supporting a concept of buffered, delayed, or diverted
				writes, we're allowing the files to be shorter than expected (the data may
				not have been written yet), but they can't be longer.

				Please note that this check is not perfect; it can't detect all cases (there
				may be false-negatives/false-OKs), but it should never claim there's an
				issue when there isn't (false-positives/false-failures).
				"""

				vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name)
				# Avoid any `fh.tell` cost if this isn't enabled.
				if not vpos or vpos not in [b'log', b'warn', b'fail']:
				return None

				def _checker(fh, fn, expected):
				if fh.tell() <= expected:
				return

				msg = _(b'%s: file cursor at position %d, expected %d')
				# Always log if we're going to warn or fail.
				ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected)
				if vpos == b'warn':
				ui.warn((msg + b'\n') % (fn, fh.tell(), expected))
				elif vpos == b'fail':
				raise error.RevlogError(msg % (fn, fh.tell(), expected))

				return _checker