upstream/mercurial-mirror Files · hgext/remotefilelog/shallowverifier.py

hgweb: handle None from templatedir() equally bad in webcommands.py...

hgweb: handle None from templatedir() equally bad in webcommands.py The following paragraph is based just on my reading of the code; I have not tried to test it. Before my recent work on templates in frozen binaries, it seems both `hgwebdir_mod.py` and `webcommands.py` would pass in an empty list into `staticfile()` when running in a frozen binary. That would then result in a variable in that function (`path`) not getting bound before its first use. I then changed that without thinking in D8786 so we passed a `None` value into the function, which made it break in another way (trying to iterate over `None`). Then I tried to fix it up in D8810, but I only changed `hgwebdir_mod.py` for some reason, and it still doesn't actually work in frozen binaries (which seems fair, since was broken before my changes too). This patch just replicates the half-assed "fix" from D8810 in `webcommands.py`, so they look more similar so I can start refactoring them in the same way. Differential Revision: https://phab.mercurial-scm.org/D8933

Augie Fackler - - Load All Authors

File last commit:

r43347:687b865b default


                r45937:da3b7c80

default

Download file

             shallowverifier.py
        
                    19 lines
            
             | 625 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / remotefilelog / shallowverifier.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # shallowverifier.py - shallow repository verifier

      #

      # Copyright 2015 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      from mercurial.i18n import _

      from mercurial import verify

      class shallowverifier(verify.verifier):

          def _verifyfiles(self, filenodes, filelinkrevs):

              """Skips files verification since repo's not guaranteed to have them"""

              self.repo.ui.status(

                  _(b"skipping filelog check since remotefilelog is used\n")

              )

              return 0, 0

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# shallowverifier.py - shallow repository verifier
				#
				# Copyright 2015 Facebook, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.
				from __future__ import absolute_import

				from mercurial.i18n import _
				from mercurial import verify


				class shallowverifier(verify.verifier):
				def _verifyfiles(self, filenodes, filelinkrevs):
				"""Skips files verification since repo's not guaranteed to have them"""
				self.repo.ui.status(
				_(b"skipping filelog check since remotefilelog is used\n")
				)
				return 0, 0