upstream/mercurial-mirror Files · mercurial/typelib.py

statichttprepo: fix `httprangereader.read()` for py3...

statichttprepo: fix `httprangereader.read()` for py3 It looks like there were a bunch of problems, not all of them py3 related: 1) The signature of BinaryIO.read() is -1, not None 2) The `end` variable can't be bytes and interpolate into str with "%s" 3) The `end` variable can't be an int and interpolate into str with "%s" 4) The result slicing could be out of bounds if more is requested than returned I guess if somebody would have called `read(-1)` (either directly or because a wrapper defaults to that), it wouldn't have been handled correctly. The fact that it is a valid value meaning to read everything requires some additional changes later in the method around when it slices the byte string that was read, but that seems to have already been broken.

Matt Harbison - - Load All Authors

File last commit:

r52757:1c5810ce default


                r52792:e26a0856

default

Download file

             typelib.py
        
                    50 lines
            
             | 1.3 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / typelib.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # typelib.py - type hint aliases and support

      #

      # Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import annotations

      import typing

      from typing import (

          Callable,

      )

      # Note: this is slightly different from pycompat.TYPE_CHECKING, as using

      # pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when

      # used as the base class during a pytype run.

      TYPE_CHECKING = typing.TYPE_CHECKING

      # The BinaryIO class provides empty methods, which at runtime means that

      # ``__getattr__`` on the proxy classes won't get called for the methods that

      # should delegate to the internal object.  So to avoid runtime changes because

      # of the required typing inheritance, just use BinaryIO when typechecking, and

      # ``object`` otherwise.

      if TYPE_CHECKING:

          from typing import (

              BinaryIO,

              Union,

          )

          from . import (

              node,

              posix,

              windows,

          )

          BinaryIO_Proxy = BinaryIO

          CacheStat = Union[posix.cachestat, windows.cachestat]

          NodeConstants = node.sha1nodeconstants

      else:

          from typing import Any

          BinaryIO_Proxy = object

          CacheStat = Any

          NodeConstants = Any

      # scmutil.getuipathfn() related callback.

      UiPathFn = Callable[[bytes], bytes]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# typelib.py - type hint aliases and support
				#
				# Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import annotations

				import typing

				from typing import (
				Callable,
				)

				# Note: this is slightly different from pycompat.TYPE_CHECKING, as using
				# pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when
				# used as the base class during a pytype run.
				TYPE_CHECKING = typing.TYPE_CHECKING


				# The BinaryIO class provides empty methods, which at runtime means that
				# ``__getattr__`` on the proxy classes won't get called for the methods that
				# should delegate to the internal object. So to avoid runtime changes because
				# of the required typing inheritance, just use BinaryIO when typechecking, and
				# ``object`` otherwise.
				if TYPE_CHECKING:
				from typing import (
				BinaryIO,
				Union,
				)

				from . import (
				node,
				posix,
				windows,
				)

				BinaryIO_Proxy = BinaryIO
				CacheStat = Union[posix.cachestat, windows.cachestat]
				NodeConstants = node.sha1nodeconstants
				else:
				from typing import Any

				BinaryIO_Proxy = object
				CacheStat = Any
				NodeConstants = Any

				# scmutil.getuipathfn() related callback.
				UiPathFn = Callable[[bytes], bytes]