##// END OF EJS Templates
streamclone: disable the volatile file open handle optimization on Windows...
streamclone: disable the volatile file open handle optimization on Windows Leaving files open caused new failures like this, since a47f09da8bd1: diff --git a/tests/test-persistent-nodemap-stream-clone.t b/tests/test-persistent-nodemap-stream-clone.t --- a/tests/test-persistent-nodemap-stream-clone.t +++ b/tests/test-persistent-nodemap-stream-clone.t @@ -115,7 +115,12 @@ Do a mix of clone and commit at the same $ (hg clone -U --stream ssh://user@dummy/test-repo stream-clone-race-1 --debug 2>> clone-output | grep -E '00(changelog|manifest)' >> clone-output; touch $HG_TEST_STREAM_WALKED_FILE_3) & $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1 $ hg -R test-repo/ commit -m foo - created new head + transaction abort! + failed to recover 00changelog.n ([WinError 32] The process cannot access the file because it is being used by another process: b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n' -> b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n-f418dcd6') + rollback failed - please run hg recover + (failure reason: [WinError 32] The process cannot access the file because it is being used by another process: b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n' -> b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n-f418dcd6') + abort: The process cannot access the file because it is being used by another process: '$TESTTMP\test-repo\.hg\store\00changelog.n' + [255] $ touch $HG_TEST_STREAM_WALKED_FILE_2 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3 $ cat clone-output Since the `VolatileManager` falls back to the old copy method when the open file threshold is exceeded, this just drops the threshold so that only 1 file is open. The actual value used (2) is unexpected, and explained inline. I'd like to have a config option for this so that we can test both ways (in theory, it could resort to copies on non-Windows systems too), but I don't see a `uimod.ui` handy. Alternately, I tried replacing the 3 `open()` calls in the `VolatileManager` with `util.posixfile()`, but that simply hung the test on Windows for some reason, I think on the same line that's indicated as failing above. (There was a `grep` command hanging around, as well as `hg -R test-repo serve --stdio`.)

File last commit:

r49730:6000f5b2 default
r53081:e4b242f9 stable
Show More
phab-clean.py
92 lines | 2.4 KiB | text/x-python | PythonLexer
#!/usr/bin/env python3
#
# A small script to automatically reject idle Diffs
#
# you need to set the PHABBOT_USER and PHABBOT_TOKEN environment variable for authentication
import datetime
import os
import sys
import phabricator
MESSAGE = """There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back to `need-review` without hesitation if this diff should still be discussed.
:baymax:need-review-idle:
"""
PHAB_URL = "https://phab.mercurial-scm.org/api/"
USER = os.environ.get("PHABBOT_USER", "baymax")
TOKEN = os.environ.get("PHABBOT_TOKEN")
NOW = datetime.datetime.now()
# 3 months in seconds
DELAY = 60 * 60 * 24 * 30 * 3
def get_all_diff(phab):
"""Fetch all the diff that the need review"""
return phab.differential.query(
status="status-needs-review",
order="order-modified",
paths=[('HG', None)],
)
def filter_diffs(diffs, older_than):
"""filter diffs to only keep the one unmodified sin <older_than> seconds"""
olds = []
for d in diffs:
modified = int(d['dateModified'])
modified = datetime.datetime.fromtimestamp(modified)
d["idleFor"] = idle_for = NOW - modified
if idle_for.total_seconds() > older_than:
olds.append(d)
return olds
def nudge_diff(phab, diff):
"""Comment on the idle diff and reject it"""
diff_id = int(d['id'])
phab.differential.createcomment(
revision_id=diff_id, message=MESSAGE, action="reject"
)
if not USER:
print(
"not user specified please set PHABBOT_USER and PHABBOT_TOKEN",
file=sys.stderr,
)
elif not TOKEN:
print(
"not api-token specified please set PHABBOT_USER and PHABBOT_TOKEN",
file=sys.stderr,
)
sys.exit(1)
phab = phabricator.Phabricator(USER, host=PHAB_URL, token=TOKEN)
phab.connect()
phab.update_interfaces()
print('Hello "%s".' % phab.user.whoami()['realName'])
diffs = get_all_diff(phab)
print("Found %d Diffs" % len(diffs))
olds = filter_diffs(diffs, DELAY)
print("Found %d old Diffs" % len(olds))
for d in olds:
diff_id = d['id']
status = d['statusName']
modified = int(d['dateModified'])
idle_for = d["idleFor"]
msg = 'nudging D%s in "%s" state for %s'
print(msg % (diff_id, status, idle_for))
# uncomment to actually affect phab
nudge_diff(phab, d)