upstream/mercurial-mirror Files · contrib/phab-refresh-stack.sh

streamclone: disable the volatile file open handle optimization on Windows...

streamclone: disable the volatile file open handle optimization on Windows Leaving files open caused new failures like this, since a47f09da8bd1: diff --git a/tests/test-persistent-nodemap-stream-clone.t b/tests/test-persistent-nodemap-stream-clone.t --- a/tests/test-persistent-nodemap-stream-clone.t +++ b/tests/test-persistent-nodemap-stream-clone.t @@ -115,7 +115,12 @@ Do a mix of clone and commit at the same $ (hg clone -U --stream ssh://user@dummy/test-repo stream-clone-race-1 --debug 2>> clone-output | grep -E '00(changelog|manifest)' >> clone-output; touch $HG_TEST_STREAM_WALKED_FILE_3) & $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1 $ hg -R test-repo/ commit -m foo - created new head + transaction abort! + failed to recover 00changelog.n ([WinError 32] The process cannot access the file because it is being used by another process: b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n' -> b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n-f418dcd6') + rollback failed - please run hg recover + (failure reason: [WinError 32] The process cannot access the file because it is being used by another process: b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n' -> b'$STR_REPR_TESTTMP\\test-repo/.hg/store/00changelog.n-f418dcd6') + abort: The process cannot access the file because it is being used by another process: '$TESTTMP\test-repo\.hg\store\00changelog.n' + [255] $ touch $HG_TEST_STREAM_WALKED_FILE_2 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3 $ cat clone-output Since the `VolatileManager` falls back to the old copy method when the open file threshold is exceeded, this just drops the threshold so that only 1 file is open. The actual value used (2) is unexpected, and explained inline. I'd like to have a config option for this so that we can test both ways (in theory, it could resort to copies on non-Windows systems too), but I don't see a `uimod.ui` handy. Alternately, I tried replacing the 3 `open()` calls in the `VolatileManager` with `util.posixfile()`, but that simply hung the test on Windows for some reason, I think on the same line that's indicated as failing above. (There was a `grep` command hanging around, as well as `hg -R test-repo serve --stdio`.)

marmoute - - Load All Authors

File last commit:

r49546:fba2d7fa default


                r53081:e4b242f9

stable

Download file

             phab-refresh-stack.sh
        
                    47 lines
            
             | 1.3 KiB
            
                | application/x-sh
            
             |
                BashLexer
            
             / contrib / phab-refresh-stack.sh
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/bin/bash

      set -eu

      if [[ "$PHABRICATOR_TOKEN" == "NO-PHAB" ]]; then

          echo 'Skipping Phabricator Step' >&2

          exit 0

      fi

      revision_in_stack=`hg log \

          --rev '.#stack and ::. and topic()' \

          -T '\nONE-REV\n' \

          | grep 'ONE-REV' | wc -l`

      revision_on_phab=`hg log \

          --rev '.#stack and ::. and topic() and desc("re:\nDifferential Revision: [^\n]+D\d+$")'\

          -T '\nONE-REV\n' \

          | grep 'ONE-REV' | wc -l`

      if [[ $revision_in_stack -eq 0 ]]; then

          echo "stack is empty" >&2

          exit 0

      fi

      if [[ $revision_on_phab -eq 0 ]]; then

          echo "no tracked diff in this stack" >&2

          exit 0

      fi

      if [[ $revision_on_phab -lt $revision_in_stack ]]; then

          echo "not all stack changesets (${revision_in_stack}) have matching Phabricator Diff (${revision_on_phab})" >&2

          exit 2

      fi

      if [[ "$PHABRICATOR_TOKEN" == "" ]]; then

          echo 'missing $PHABRICATOR_TOKEN variable' >&2

          echo '(use PHABRICATOR_TOKEN="NO-PHAB" to disable this step)' >&2

          exit 2

      fi

      hg \

      --config extensions.phabricator= \

      --config phabricator.url=https://phab.mercurial-scm.org/ \

      --config phabricator.callsign=HG \

      --config auth.phabricator.schemes=https \

      --config auth.phabricator.prefix=phab.mercurial-scm.org \

      --config auth.phabricator.phabtoken=$PHABRICATOR_TOKEN \

      phabsend --rev '.#stack and ::. and topic()' \

      "$@"

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/bin/bash
				set -eu

				if [[ "$PHABRICATOR_TOKEN" == "NO-PHAB" ]]; then
				echo 'Skipping Phabricator Step' >&2
				exit 0
				fi

				revision_in_stack=`hg log \
				--rev '.#stack and ::. and topic()' \
				-T '\nONE-REV\n' \
				\| grep 'ONE-REV' \| wc -l`
				revision_on_phab=`hg log \
				--rev '.#stack and ::. and topic() and desc("re:\nDifferential Revision: [^\n]+D\d+$")'\
				-T '\nONE-REV\n' \
				\| grep 'ONE-REV' \| wc -l`

				if [[ $revision_in_stack -eq 0 ]]; then
				echo "stack is empty" >&2
				exit 0
				fi

				if [[ $revision_on_phab -eq 0 ]]; then
				echo "no tracked diff in this stack" >&2
				exit 0
				fi

				if [[ $revision_on_phab -lt $revision_in_stack ]]; then
				echo "not all stack changesets (${revision_in_stack}) have matching Phabricator Diff (${revision_on_phab})" >&2
				exit 2
				fi

				if [[ "$PHABRICATOR_TOKEN" == "" ]]; then
				echo 'missing $PHABRICATOR_TOKEN variable' >&2
				echo '(use PHABRICATOR_TOKEN="NO-PHAB" to disable this step)' >&2
				exit 2
				fi

				hg \
				--config extensions.phabricator= \
				--config phabricator.url=https://phab.mercurial-scm.org/ \
				--config phabricator.callsign=HG \
				--config auth.phabricator.schemes=https \
				--config auth.phabricator.prefix=phab.mercurial-scm.org \
				--config auth.phabricator.phabtoken=$PHABRICATOR_TOKEN \
				phabsend --rev '.#stack and ::. and topic()' \
				"$@"