upstream/mercurial-mirror Files · contrib/debugcmdserver.py

rust-cpython: mark all PyLeaked methods as unsafe...

rust-cpython: mark all PyLeaked methods as unsafe Unfortunately, these methods can be abused to obtain the inner 'static reference. The simplest (pseudo-code) example is: let leaked: PyLeaked<&'static _> = shared.leak_immutable(); let static_ref: &'static _ = &*leaked.try_borrow(py)?; // PyLeakedRef::deref() tries to bound the lifetime to itself, but // the underlying data is a &'static reference, so the returned // reference can be &'static. This problem can be easily fixed by coercing the lifetime, but there are many other ways to achieve that, and there wouldn't be a generic solution: let leaked: PyLeaked<&'static [_]> = shared.leak_immutable(); let leaked_iter: PyLeaked<slice::Iter<'static, _>> = unsafe { leaked.map(|v| v.iter()) }; let static_slice: &'static [_] = leaked_iter.try_borrow(py)?.as_slice(); So basically I failed to design the safe borrowing interface. Maybe we'll instead have to add much more restricted interface on top of the unsafe PyLeaked methods? For instance, Iterator::next() could be implemented if its Item type is not &'a (where 'a may be cheated.) Anyway, this seems not an easy issue, so it's probably better to leave the current interface as unsafe, and get broader comments while upstreaming this feature.

Augie Fackler - - Load All Authors

File last commit:

r43346:2372284d default


                r44689:e960c30d

default

Download file

             debugcmdserver.py
        
                    51 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / debugcmdserver.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #!/usr/bin/env python

      #

      # Dumps output generated by Mercurial's command server in a formatted style to a

      # given file or stderr if '-' is specified. Output is also written in its raw

      # format to stdout.

      #

      # $ ./hg serve --cmds pipe | ./contrib/debugcmdserver.py -

      # o, 52   -> 'capabilities: getencoding runcommand\nencoding: UTF-8'

      from __future__ import absolute_import, print_function

      import struct

      import sys

      if len(sys.argv) != 2:

          print('usage: debugcmdserver.py FILE')

          sys.exit(1)

      outputfmt = '>cI'

      outputfmtsize = struct.calcsize(outputfmt)

      if sys.argv[1] == '-':

          log = sys.stderr

      else:

          log = open(sys.argv[1], 'a')

      def read(size):

          data = sys.stdin.read(size)

          if not data:

              raise EOFError

          sys.stdout.write(data)

          sys.stdout.flush()

          return data

      try:

          while True:

              header = read(outputfmtsize)

              channel, length = struct.unpack(outputfmt, header)

              log.write('%s, %-4d' % (channel, length))

              if channel in 'IL':

                  log.write(' -> waiting for input\n')

              else:

                  data = read(length)

                  log.write(' -> %r\n' % data)

              log.flush()

      except EOFError:

          pass

      finally:

          if log != sys.stderr:

              log.close()

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#!/usr/bin/env python
				#
				# Dumps output generated by Mercurial's command server in a formatted style to a
				# given file or stderr if '-' is specified. Output is also written in its raw
				# format to stdout.
				#
				# $ ./hg serve --cmds pipe \| ./contrib/debugcmdserver.py -
				# o, 52 -> 'capabilities: getencoding runcommand\nencoding: UTF-8'

				from __future__ import absolute_import, print_function
				import struct
				import sys

				if len(sys.argv) != 2:
				print('usage: debugcmdserver.py FILE')
				sys.exit(1)

				outputfmt = '>cI'
				outputfmtsize = struct.calcsize(outputfmt)

				if sys.argv[1] == '-':
				log = sys.stderr
				else:
				log = open(sys.argv[1], 'a')


				def read(size):
				data = sys.stdin.read(size)
				if not data:
				raise EOFError
				sys.stdout.write(data)
				sys.stdout.flush()
				return data


				try:
				while True:
				header = read(outputfmtsize)
				channel, length = struct.unpack(outputfmt, header)
				log.write('%s, %-4d' % (channel, length))
				if channel in 'IL':
				log.write(' -> waiting for input\n')
				else:
				data = read(length)
				log.write(' -> %r\n' % data)
				log.flush()
				except EOFError:
				pass
				finally:
				if log != sys.stderr:
				log.close()