upstream/mercurial-mirror Files · rust/hg-core/src/operations/debugdata.rs

rust: Add type annotation to fix inference on Rust Nightly...

rust: Add type annotation to fix inference on Rust Nightly When compiling with Rust Nightly, the im-rs crate silently makes use of the experimental language feature for trait impl specialization. This apperently changes public its APIs in subtle ways such that type inference of some user code can fail where it succeeds when specialization is disabled. This made Mercurial’s Rust unit tests have compilation errors on Nightly. I have not managed to find the exactl root cause, but I wrote down my findings so far at https://github.com/bodil/im-rs/issues/188 This adds type annotation to make unit tests rely less on type inference and work around the issue. Differential Revision: https://phab.mercurial-scm.org/D10742

Simon Sapin - - Load All Authors

File last commit:

r47166:b274aa2f default


                r48062:ebf84336

default

Download file

             debugdata.rs
        
                    33 lines
            
             | 911 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / operations / debugdata.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // debugdata.rs

      //

      // Copyright 2020 Antoine Cezar <antoine.cezar@octobus.net>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      use crate::repo::Repo;

      use crate::revlog::revlog::{Revlog, RevlogError};

      /// Kind of data to debug

      #[derive(Debug, Copy, Clone)]

      pub enum DebugDataKind {

          Changelog,

          Manifest,

      }

      /// Dump the contents data of a revision.

      pub fn debug_data(

          repo: &Repo,

          revset: &str,

          kind: DebugDataKind,

      ) -> Result<Vec<u8>, RevlogError> {

          let index_file = match kind {

              DebugDataKind::Changelog => "00changelog.i",

              DebugDataKind::Manifest => "00manifest.i",

          };

          let revlog = Revlog::open(repo, index_file, None)?;

          let rev =

              crate::revset::resolve_rev_number_or_hex_prefix(revset, &revlog)?;

          let data = revlog.get_rev_data(rev)?;

          Ok(data)

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// debugdata.rs
				//
				// Copyright 2020 Antoine Cezar <antoine.cezar@octobus.net>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				use crate::repo::Repo;
				use crate::revlog::revlog::{Revlog, RevlogError};

				/// Kind of data to debug
				#[derive(Debug, Copy, Clone)]
				pub enum DebugDataKind {
				Changelog,
				Manifest,
				}

				/// Dump the contents data of a revision.
				pub fn debug_data(
				repo: &Repo,
				revset: &str,
				kind: DebugDataKind,
				) -> Result<Vec<u8>, RevlogError> {
				let index_file = match kind {
				DebugDataKind::Changelog => "00changelog.i",
				DebugDataKind::Manifest => "00manifest.i",
				};
				let revlog = Revlog::open(repo, index_file, None)?;
				let rev =
				crate::revset::resolve_rev_number_or_hex_prefix(revset, &revlog)?;
				let data = revlog.get_rev_data(rev)?;
				Ok(data)
				}