##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

server: add an error feedback mechanism for when the daemon fails to launch...
server: add an error feedback mechanism for when the daemon fails to launch There's a recurring problem on Windows where `hg serve -d` will randomly fail to spawn a detached process. The reason for the failure is completely hidden, and it takes hours to get a single failure on my laptop. All this does is redirect stdout/stderr of the child to a file until the lock file is freed, and then the parent dumps it out if it fails to spawn. I chose to put the output into the lock file because that is always cleaned up. There's no way to report errors after that anyway. On Windows, killdaemons.py is roughly `kill -9`, so this ensures that junk won't pile up. This may end up being a case of EADDRINUSE. At least that's what I saw spit out a few times (among other odd errors and missing output on Windows). But I also managed to get the same thing on Fedora 26 by running test-hgwebdir.t with --loop -j10 for several hours. Running `netstat` immediately after killing that run printed a wall of sockets in the TIME_WAIT state, which were gone a couple seconds later. I couldn't match up ports that failed, because --loop doesn't print out the message about the port that was used. So maybe the fix is to rotate the use of HGPORT[12] in the tests. But, let's collect some more data first.
Augie Fackler - - Load All Authors

File last commit:

r36121:9b5df6e1 default
r37229:f09a2eab default
Show More
TODO.rst
37 lines | 1.7 KiB | text/x-rst | RstLexer
/ hgext / narrow / TODO.rst
History | Annotation | Raw |Copy content |Copy permalink

Integration with the share extension needs improvement. Right now we've seen some odd bugs, and the way we modify the contents of the .hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

Resolve commentary on narrowrepo.wraprepo.narrowrepository.status about the filtering of status being done at an awkward layer. This came up the import to hgext, but nobody's got concrete improvement ideas as of then.

Fold most (or preferably all) of narrowrevlog.py into core.

Address commentary in narrowrevlog.excludedmanifestrevlog.add - specifically we should improve the collaboration with core so that add() never gets called on an excluded directory and we can improve the stand-in to raise a ProgrammingError.

Figure out how to correctly produce narrowmanifestrevlog and narrowfilelog instances instead of monkeypatching regular revlogs at runtime to our subclass. Even better, merge the narrowing logic directly into core.

Reason more completely about rename-filtering logic in narrowfilelog. There could be some surprises lurking there.

Formally document the narrowspec format. Unify with sparse, if at all possible. For bonus points, unify with the server-specified narrowspec format.

narrowrepo.setnarrowpats() or narrowspec.save() need to make sure they're holding the wlock.

Implement a simple version of the expandnarrow wireproto command for core. Having configurable shorthands for narrowspecs has been useful at Google (and sparse has a similar feature from Facebook), so it probably makes sense to implement the feature in core. (Google's handler is entirely custom to Google, with a custom format related to bazel's build language, so it's not in the narrowhg distribution.)