upstream/mercurial-mirror Files · hgext/infinitepush/common.py

fix: reduce number of tool executions...

fix: reduce number of tool executions By grouping together (path, ctx) pairs according to the inputs they would provide to fixer tools, we can deduplicate executions of fixer tools to significantly reduce the amount of time spent running slow tools. This change does not handle clean files in the working copy, which could still be deduplicated against the files in the checked out commit. It's a little harder to do that because the filerev is not available in the workingfilectx (and it doesn't exist for added files). Anecdotally, this change makes some real uses cases at Google 10x faster. I think we were originally hesitant to do this because the benefits weren't obvious, and implementing it efficiently is kind of tricky. If we simply memoized the formatter execution function, we would be keeping tons of file content in memory. Also included is a regression test for a corner case that I broke with my first attempt at optimizing this code. Differential Revision: https://phab.mercurial-scm.org/D11280

Augie Fackler - - Load All Authors

File last commit:

r43812:2fe6121c default


                r48992:f12a19d0

default

Download file

             common.py
        
                    52 lines
            
             | 1.2 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / infinitepush / common.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # Copyright 2017 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      import os

      from mercurial.node import hex

      from mercurial import (

          error,

          extensions,

          pycompat,

      )

      def isremotebooksenabled(ui):

          return b'remotenames' in extensions._extensions and ui.configbool(

              b'remotenames', b'bookmarks'

          )

      def downloadbundle(repo, unknownbinhead):

          index = repo.bundlestore.index

          store = repo.bundlestore.store

          bundleid = index.getbundle(hex(unknownbinhead))

          if bundleid is None:

              raise error.Abort(b'%s head is not known' % hex(unknownbinhead))

          bundleraw = store.read(bundleid)

          return _makebundlefromraw(bundleraw)

      def _makebundlefromraw(data):

          fp = None

          fd, bundlefile = pycompat.mkstemp()

          try:  # guards bundlefile

              try:  # guards fp

                  fp = os.fdopen(fd, 'wb')

                  fp.write(data)

              finally:

                  fp.close()

          except Exception:

              try:

                  os.unlink(bundlefile)

              except Exception:

                  # we would rather see the original exception

                  pass

              raise

          return bundlefile

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# Copyright 2017 Facebook, Inc.
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				from __future__ import absolute_import

				import os

				from mercurial.node import hex

				from mercurial import (
				error,
				extensions,
				pycompat,
				)


				def isremotebooksenabled(ui):
				return b'remotenames' in extensions._extensions and ui.configbool(
				b'remotenames', b'bookmarks'
				)


				def downloadbundle(repo, unknownbinhead):
				index = repo.bundlestore.index
				store = repo.bundlestore.store
				bundleid = index.getbundle(hex(unknownbinhead))
				if bundleid is None:
				raise error.Abort(b'%s head is not known' % hex(unknownbinhead))
				bundleraw = store.read(bundleid)
				return _makebundlefromraw(bundleraw)


				def _makebundlefromraw(data):
				fp = None
				fd, bundlefile = pycompat.mkstemp()
				try: # guards bundlefile
				try: # guards fp
				fp = os.fdopen(fd, 'wb')
				fp.write(data)
				finally:
				fp.close()
				except Exception:
				try:
				os.unlink(bundlefile)
				except Exception:
				# we would rather see the original exception
				pass
				raise

				return bundlefile