upstream/mercurial-mirror Files · hgext/color.py

sslutil: issue warning when [hostfingerprint] is used...

sslutil: issue warning when [hostfingerprint] is used Mercurial 3.9 added the [hostsecurity] section, which is better than [hostfingerprints] in every way. One of the ways that [hostsecurity] is better is that it supports SHA-256 and SHA-512 fingerprints, not just SHA-1 fingerprints. The world is moving away from SHA-1 because it is borderline secure. Mercurial should be part of that movement. This patch adds a warning when a valid SHA-1 fingerprint from the [hostfingerprints] section is being used. The warning informs users to switch to [hostsecurity]. It even prints the config option they should set. It uses the SHA-256 fingerprint because recommending a SHA-1 fingerprint in 2017 would be ill-advised. The warning will print itself on every connection to a server until it is fixed. There is no way to suppress the warning. I admit this is annoying. But given the security implications of sticking with SHA-1, I think this is justified. If this patch is accepted, I'll likely send a follow-up to start warning on SHA-1 certificates in [hostsecurity] as well. Then sometime down the road, we can drop support for SHA-1 fingerprints. Credit for this idea comes from timeless in issue 5466.

Pierre-Yves David - - Load All Authors

File last commit:

r31123:df0a0734 default


                r31290:f819aa9d

default

Download file

             color.py
        
                    31 lines
            
             | 933 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / color.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # color.py color output for Mercurial commands

      #

      # Copyright (C) 2007 Kevin Christen <kevin.christen@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      '''enable Mercurial color mode (DEPRECATED)

      This extensions enable Mercurial color mode. The feature is now directly

      available in Mercurial core. You can access it using::

        [ui]

        color = auto

      See :hg:`help color` for details.

      '''

      from __future__ import absolute_import

      from mercurial import color

      # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for

      # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should

      # be specifying the version(s) of Mercurial they are tested with, or

      # leave the attribute unspecified.

      testedwith = 'ships-with-hg-core'

      def extsetup(ui):

          # change default color config

          color._enabledbydefault = True

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# color.py color output for Mercurial commands
				#
				# Copyright (C) 2007 Kevin Christen <kevin.christen@gmail.com>
				#
				# This software may be used and distributed according to the terms of the
				# GNU General Public License version 2 or any later version.

				'''enable Mercurial color mode (DEPRECATED)

				This extensions enable Mercurial color mode. The feature is now directly
				available in Mercurial core. You can access it using::

				[ui]
				color = auto

				See :hg:`help color` for details.
				'''

				from __future__ import absolute_import

				from mercurial import color

				# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
				# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
				# be specifying the version(s) of Mercurial they are tested with, or
				# leave the attribute unspecified.
				testedwith = 'ships-with-hg-core'

				def extsetup(ui):
				# change default color config
				color._enabledbydefault = True