pr: Rename update response flag `success` -> `executed`

The name `success` may be misleading beacuse a skipped updated can be
interpreted as success or failure. The new name `executed` is clearer
because its only `True` if the update is really executed.

rhodecode/controllers/pullrequests.py

@@ -520,7 +520,7 b' class PullrequestsController(BaseRepoCon'
     def _update_commits(self, pull_request):
         resp = PullRequestModel().update_commits(pull_request)
 
-        if resp.success:
+        if resp.executed:
             msg = _(
                 u'Pull request updated to "{source_commit_id}" with '
                 u'{count_added} added, {count_removed} removed commits.')

rhodecode/model/pull_request.py

@@ -63,7 +63,7 b' log = logging.getLogger(__name__)'
 # Data structure to hold the response data when updating commits during a pull
 # request update.
 UpdateResponse = namedtuple(
-    'UpdateResponse', 'success, reason, new, old, changes')
+    'UpdateResponse', 'executed, reason, new, old, changes')
 
 
 class PullRequestModel(BaseModel):
@@ -521,7 +521,7 b' class PullRequestModel(BaseModel):'
                 "Skipping update of pull request %s due to ref type: %s",
                 pull_request, source_ref_type)
             return UpdateResponse(
-                success=False,
+                executed=False,
                 reason=UpdateFailureReason.WRONG_REF_TPYE,
                 old=pull_request, new=None, changes=None)
 
@@ -530,14 +530,14 b' class PullRequestModel(BaseModel):'
             source_commit = source_repo.get_commit(commit_id=source_ref_name)
         except CommitDoesNotExistError:
             return UpdateResponse(
-                success=False,
+                executed=False,
                 reason=UpdateFailureReason.MISSING_SOURCE_REF,
                 old=pull_request, new=None, changes=None)
 
         if source_ref_id == source_commit.raw_id:
             log.debug("Nothing changed in pull request %s", pull_request)
             return UpdateResponse(
-                success=False,
+                executed=False,
                 reason=UpdateFailureReason.NO_CHANGE,
                 old=pull_request, new=None, changes=None)
 
@@ -557,7 +557,7 b' class PullRequestModel(BaseModel):'
                 target_commit = target_repo.get_commit(target_ref_id)
         except CommitDoesNotExistError:
             return UpdateResponse(
-                success=False,
+                executed=False,
                 reason=UpdateFailureReason.MISSING_TARGET_REF,
                 old=pull_request, new=None, changes=None)
 
@@ -630,7 +630,7 b' class PullRequestModel(BaseModel):'
                                         'update')
 
         return UpdateResponse(
-            success=True, reason=UpdateFailureReason.NONE,
+            executed=True, reason=UpdateFailureReason.NONE,
             old=pull_request, new=pull_request_version, changes=changes)
 
     def _create_version_from_snapshot(self, pull_request):