##// END OF EJS Templates
diffs: fixed diff rendering when a common ancestor was a different commit than the source of changes.
milka -
r4593:16e47051 stable
parent child Browse files
Show More
@@ -221,9 +221,13 b' class RepoPullRequestsView(RepoAppView, '
221 target_commit, source_commit, diff_limit, file_limit,
221 target_commit, source_commit, diff_limit, file_limit,
222 fulldiff, hide_whitespace_changes, diff_context, use_ancestor=True):
222 fulldiff, hide_whitespace_changes, diff_context, use_ancestor=True):
223
223
224 target_commit_final = target_commit
225 source_commit_final = source_commit
226
224 if use_ancestor:
227 if use_ancestor:
225 # we might want to not use it for versions
228 # we might want to not use it for versions
226 target_ref_id = ancestor_commit.raw_id
229 target_ref_id = ancestor_commit.raw_id
230 target_commit_final = ancestor_commit
227
231
228 vcs_diff = PullRequestModel().get_diff(
232 vcs_diff = PullRequestModel().get_diff(
229 source_repo, source_ref_id, target_ref_id,
233 source_repo, source_ref_id, target_ref_id,
@@ -238,11 +242,11 b' class RepoPullRequestsView(RepoAppView, '
238 diffset = codeblocks.DiffSet(
242 diffset = codeblocks.DiffSet(
239 repo_name=self.db_repo_name,
243 repo_name=self.db_repo_name,
240 source_repo_name=source_repo_name,
244 source_repo_name=source_repo_name,
241 source_node_getter=codeblocks.diffset_node_getter(target_commit),
245 source_node_getter=codeblocks.diffset_node_getter(target_commit_final),
242 target_node_getter=codeblocks.diffset_node_getter(source_commit),
246 target_node_getter=codeblocks.diffset_node_getter(source_commit_final),
243 )
247 )
244 diffset = self.path_filter.render_patchset_filtered(
248 diffset = self.path_filter.render_patchset_filtered(
245 diffset, _parsed, target_commit.raw_id, source_commit.raw_id)
249 diffset, _parsed, target_ref_id, source_ref_id)
246
250
247 return diffset
251 return diffset
248
252
General Comments 0
You need to be logged in to leave comments. Login now