##// END OF EJS Templates
pull-requests: forbid browsing versions on closed pull request.
marcink -
r1446:2af6893f default
parent child Browse files
Show More
@@ -644,6 +644,13 b' class PullrequestsController(BaseRepoCon'
644 pull_request_display_obj,
644 pull_request_display_obj,
645 at_version) = self._get_pr_version(
645 at_version) = self._get_pr_version(
646 pull_request_id, version=version)
646 pull_request_id, version=version)
647 pr_closed = pull_request_latest.is_closed()
648
649 if pr_closed and (version or from_version):
650 # not allow to browse versions
651 return redirect(h.url('pullrequest_show', repo_name=repo_name,
652 pull_request_id=pull_request_id))
653
647 versions = pull_request_display_obj.versions()
654 versions = pull_request_display_obj.versions()
648
655
649 c.at_version = at_version
656 c.at_version = at_version
@@ -681,7 +688,6 b' class PullrequestsController(BaseRepoCon'
681 c.pull_request = pull_request_display_obj
688 c.pull_request = pull_request_display_obj
682 c.pull_request_latest = pull_request_latest
689 c.pull_request_latest = pull_request_latest
683
690
684 pr_closed = pull_request_latest.is_closed()
685 if compare or (at_version and not at_version == 'latest'):
691 if compare or (at_version and not at_version == 'latest'):
686 c.allowed_to_change_status = False
692 c.allowed_to_change_status = False
687 c.allowed_to_update = False
693 c.allowed_to_update = False
General Comments 0
You need to be logged in to leave comments. Login now