vcs: Add flag to indicate if repository is a shadow repository.

rhodecode/lib/base.py

@@ -163,7 +163,8 b' def get_access_path(environ):'
 
 
 def vcs_operation_context(
-        environ, repo_name, username, action, scm, check_locking=True):
+        environ, repo_name, username, action, scm, check_locking=True,
+        is_shadow_repo=False):
     """
     Generate the context for a vcs operation, e.g. push or pull.
 
@@ -200,6 +201,7 b' def vcs_operation_context('
         'locked_by': locked_by,
         'server_url': utils2.get_server_url(environ),
         'hooks': get_enabled_hook_classes(ui_settings),
+        'is_shadow_repo': is_shadow_repo,
     }
     return extras
 

rhodecode/lib/middleware/simplevcs.py

@@ -109,7 +109,7 b' class SimpleVCS(object):'
     def set_repo_names(self, environ):
         """
         This will populate the attributes acl_repo_name, url_repo_name,
-        vcs_repo_name and pr_id on the current instance.
+        vcs_repo_name and is_shadow_repo on the current instance.
         """
         # TODO: martinb: Move to class or module scope.
         # TODO: martinb: Check if we have to use re.UNICODE.
@@ -143,14 +143,14 b' class SimpleVCS(object):'
                 workspace_id)
 
             # Store names for later usage.
-            self.pr_id = pr_id
             self.vcs_repo_name = vcs_repo_name
             self.acl_repo_name = pull_request.target_repo.repo_name
+            self.is_shadow_repo = True
         else:
             # All names are equal for normal (non shadow) repositories.
             self.acl_repo_name = self.url_repo_name
             self.vcs_repo_name = self.url_repo_name
-            self.pr_id = None
+            self.is_shadow_repo = False
 
     @property
     def scm_app(self):
@@ -305,7 +305,7 b' class SimpleVCS(object):'
         # Check if this is a request to a shadow repository of a pull request.
         # In this case only pull action is allowed.
         # ======================================================================
-        if self.pr_id is not None and action != 'pull':
+        if self.is_shadow_repo and action != 'pull':
             reason = 'Only pull action is allowed for shadow repositories.'
             log.debug('User not allowed to proceed, %s', reason)
             return HTTPNotAcceptable(reason)(environ, start_response)
@@ -393,8 +393,9 b' class SimpleVCS(object):'
         check_locking = _should_check_locking(environ.get('QUERY_STRING'))
         extras = vcs_operation_context(
             environ, repo_name=self.acl_repo_name, username=username,
-            action=action, scm=self.SCM,
-            check_locking=check_locking)
+            action=action, scm=self.SCM, check_locking=check_locking,
+            is_shadow_repo=self.is_shadow_repo
+        )
 
         # ======================================================================
         # REQUEST HANDLING