fix(submodules): fixed an error if reaching out submodule path.

- small UI fixes
- cleanups of submodule code

rhodecode/apps/repository/views/repo_files.py

@@ -647,6 +647,13 b' class RepoFilesView(RepoAppView):'
         c.f_path = f_path
         at_rev = self.request.GET.get('at')
 
+        # files or dirs
+        try:
+            c.file = c.commit.get_node(f_path, pre_load=['is_binary', 'size', 'data'])
+
+            c.file_author = True
+            c.file_tree = ''
+
         # prev link
         try:
             prev_commit = c.commit.prev(c.branch)
@@ -673,15 +680,9 b' class RepoFilesView(RepoAppView):'
             c.url_next = '#'
             c.next_commit = EmptyCommit()
 
-        # files or dirs
-        try:
-            c.file = c.commit.get_node(f_path, pre_load=['is_binary', 'size', 'data'])
-
-            c.file_author = True
-            c.file_tree = ''
-
             # load file content
             if c.file.is_file():
+
                 c.lf_node = {}
 
                 has_lf_enabled = self._is_lf_enabled(self.db_repo)

rhodecode/model/repo.py

@@ -39,6 +39,7 b' from rhodecode.lib.utils2 import ('
     safe_str, remove_prefix, obfuscate_url_pw,
     get_current_rhodecode_user, safe_int, action_logger_generic)
 from rhodecode.lib.vcs.backends import get_backend
+from rhodecode.lib.vcs.nodes import NodeKind
 from rhodecode.model import BaseModel
 from rhodecode.model.db import (
     _hash_key, func, case, joinedload, or_, in_filter_generator,
@@ -1128,6 +1129,10 b' class ReadmeFinder:'
         """
         Find a readme in the given `commit`.
         """
+        # firstly, check the PATH type if it is actually a DIR
+        if commit.get_node(path).kind != NodeKind.DIR:
+            return None
+
         nodes = commit.get_nodes(path)
         matches = self._match_readmes(nodes)
         matches = self._sort_according_to_priority(matches)

rhodecode/templates/ejs_templates/templates.html

@@ -264,7 +264,10 b' They are permanent until deleted, or con'
 
 </script>
 
-
+<script id="ejs_submoduleHovercard" type="text/template" class="ejsTemplate">
+    <strong>Submodule Node</strong><br/>
+    <pre><%= submodule_url %></pre>
+</script>
 
 ##// END OF EJS Templates
 </div>

rhodecode/templates/files/files_browser_tree.mako

@@ -1,5 +1,13 b''
 <%namespace name="base" file="/base/base.mako"/>
 
+<%doc>
+Please note the content of this file is cached, so changes here might not be reflected when editing.
+add ?no-cache=true into the file url to disable caches.
+
+e.g
+http://docker-dev:10020/ipython/files/master/IPython/frontend/html/notebook/static?no-cache=1
+
+</%doc>
 <%
     at_ref = request.GET.get('at')
     if at_ref:
@@ -29,6 +37,7 b''
         </tr>
 
         <% has_files = False %>
+        % if not c.file.is_submodule():
         % for cnt,node in enumerate(c.file):
         <% has_files = True %>
         <tr class="parity${(cnt % 2)}">
@@ -37,10 +46,10 b''
               <span class="submodule-dir">
                 % if node.url.startswith('http://') or node.url.startswith('https://'):
                   <a href="${node.url}">
-                      <i class="icon-directory browser-dir"></i>${node.name}
+                          <i class="icon-directory browser-dir"></i><span class="tooltip-hovercard" data-hovercard-alt="${node.url}" data-hovercard-url="javascript:renderTemplate('submoduleHovercard', {'submodule_url':'${node.url}'})">${node.name}</span>
                   </a>
                 % else:
-                  <i class="icon-directory browser-dir"></i>${node.name}
+                      <i class="icon-directory browser-dir"></i><span class="tooltip-hovercard" data-hovercard-alt="${node.url}" data-hovercard-url="javascript:renderTemplate('submoduleHovercard', {'submodule_url':'${node.url}'})">${node.name}</span>
                 % endif
               </span>
             % else:
@@ -82,12 +91,17 b''
             %endif
           </tr>
         % endfor
+        % endif
 
         % if not has_files:
         <tr>
             <td colspan="5">
                 ##empty-dir mostly SVN
-                &nbsp;
+
+                ## submodule if we somehow endup
+                % if c.file.is_submodule():
+                    <span class="submodule-dir">Submodule ${h.escape(c.file.name)}</span>
+                %endif
             </td>
         </tr>
         % endif

rhodecode/templates/files/files_pjax.mako

@@ -15,17 +15,15 b''
         <div class="summary-detail-header">
 
         </div><!--end summary-detail-header-->
-
-        % if c.file.is_submodule():
-            <span class="submodule-dir">Submodule ${h.escape(c.file.name)}</span>
-        % elif c.file.is_dir():
+        % if c.file.is_dir() or c.file.is_submodule():
             <%include file='files_tree_header.mako'/>
         % else:
             <%include file='files_source_header.mako'/>
         % endif
 
     </div> <!--end summary-detail-->
-    % if c.file.is_dir():
+
+    % if c.file.is_dir() or c.file.is_submodule():
         <%include file='files_browser.mako'/>
     % else:
         <%include file='files_source.mako'/>