##// END OF EJS Templates
exception-handling: nicer error catching on repository creation.
marcink -
r1203:5a5d1405 stable
parent child Browse files
Show More
@@ -159,8 +159,7 b' def create_repo(form_data, cur_user):'
159 159 state=state
160 160 )
161 161
162 action_logger(cur_user, 'user_created_repo',
163 repo_name_full, '', DBS)
162 action_logger(cur_user, 'user_created_repo', repo_name_full, '', DBS)
164 163 DBS.commit()
165 164
166 165 # now create this repo on Filesystem
@@ -179,9 +178,9 b' def create_repo(form_data, cur_user):'
179 178 # set new created state
180 179 repo.set_state(Repository.STATE_CREATED)
181 180 DBS.commit()
182 except Exception as e:
183 log.warning('Exception %s occurred when creating repository, '
184 'doing cleanup...', e)
181 except Exception:
182 log.warning('Exception occurred when creating repository, '
183 'doing cleanup...', exc_info=True)
185 184 # rollback things manually !
186 185 repo = Repository.get_by_repo_name(repo_name_full)
187 186 if repo:
@@ -264,7 +264,8 b' class SettingsModel(BaseModel):'
264 264 repo = self._get_repo(self.repo)
265 265 if not repo:
266 266 raise Exception(
267 'Repository {} cannot be found'.format(self.repo))
267 'Repository `{}` cannot be found inside the database'.format(
268 self.repo))
268 269 return repo
269 270
270 271 def _filter_by_repo(self, model, query):
General Comments 0
You need to be logged in to leave comments. Login now