##// END OF EJS Templates
pull-requests: make sure we process comments in the order of IDS when...
marcink -
r1705:69c8cca7 default
parent child Browse files
Show More
@@ -806,13 +806,15 b' class PullRequestModel(BaseModel):'
806
806
807 """
807 """
808 pull_request = pull_request_version.pull_request
808 pull_request = pull_request_version.pull_request
809 comments = ChangesetComment.query().filter(
809 comments = ChangesetComment.query()\
810 .filter(
810 # TODO: johbo: Should we query for the repo at all here?
811 # TODO: johbo: Should we query for the repo at all here?
811 # Pending decision on how comments of PRs are to be related
812 # Pending decision on how comments of PRs are to be related
812 # to either the source repo, the target repo or no repo at all.
813 # to either the source repo, the target repo or no repo at all.
813 ChangesetComment.repo_id == pull_request.target_repo.repo_id,
814 ChangesetComment.repo_id == pull_request.target_repo.repo_id,
814 ChangesetComment.pull_request == pull_request,
815 ChangesetComment.pull_request == pull_request,
815 ChangesetComment.pull_request_version == None)
816 ChangesetComment.pull_request_version == None)\
817 .order_by(ChangesetComment.comment_id.asc())
816
818
817 # TODO: johbo: Find out why this breaks if it is done in a bulk
819 # TODO: johbo: Find out why this breaks if it is done in a bulk
818 # operation.
820 # operation.
General Comments 0
You need to be logged in to leave comments. Login now