files: use a common function to handle url-by-refs, and fix landing refs for SVN.

- fixes  #5619

rhodecode/apps/_base/__init__.py

@@ -531,8 +531,6 b' class BaseReferencesView(RepoAppView):'
     """
     def load_default_context(self):
         c = self._get_local_tmpl_context()
-
-
         return c
 
     def load_refs_context(self, ref_items, partials_template):
@@ -562,7 +560,9 b' class BaseReferencesView(RepoAppView):'
                     'repo_files',
                     repo_name=self.db_repo_name,
                     f_path=ref_name if is_svn else '',
-                    commit_id=commit_id)
+                    commit_id=commit_id,
+                    _query=dict(at=ref_name)
+                )
 
             else:
                 files_url = h.route_path(
@@ -570,7 +570,8 b' class BaseReferencesView(RepoAppView):'
                     repo_name=self.db_repo_name,
                     f_path=ref_name if is_svn else '',
                     commit_id=ref_name,
-                    _query=dict(at=ref_name))
+                    _query=dict(at=ref_name)
+                )
 
             data.append({
                 "name": _render('name', ref_name, files_url, closed),

rhodecode/apps/repository/views/repo_files.py

@@ -594,11 +594,15 b' class RepoFilesView(RepoAppView):'
         renderer=None)
     def repo_files_default(self):
         c = self.load_default_context()
-
-        landing_url = h.route_path(
-            'repo_files', repo_name=c.repo_name,
-            commit_id=c.rhodecode_db_repo.landing_ref_name, f_path='',
-            _query={'at': c.rhodecode_db_repo.landing_ref_name})
+        ref_name = c.rhodecode_db_repo.landing_ref_name
+        landing_url = h.repo_files_by_ref_url(
+            c.rhodecode_db_repo.repo_name,
+            c.rhodecode_db_repo.repo_type,
+            f_path='',
+            ref_name=ref_name,
+            commit_id='tip',
+            query=dict(at=ref_name)
+        )
 
         raise HTTPFound(landing_url)
 

rhodecode/lib/helpers.py

@@ -256,29 +256,34 b' tooltip = _ToolTip()'
 files_icon = u'<i class="file-breadcrumb-copy tooltip icon-clipboard clipboard-action" data-clipboard-text="{}" title="Copy file path"></i>'
 
 
-def files_breadcrumbs(repo_name, commit_id, file_path, landing_ref_name=None, at_ref=None,
-                      limit_items=False, linkify_last_item=False, hide_last_item=False, copy_path_icon=True):
+def files_breadcrumbs(repo_name, repo_type, commit_id, file_path, landing_ref_name=None, at_ref=None,
+                      limit_items=False, linkify_last_item=False, hide_last_item=False,
+                      copy_path_icon=True):
     if isinstance(file_path, str):
         file_path = safe_unicode(file_path)
 
     if at_ref:
         route_qry = {'at': at_ref}
-        default_commit_id = at_ref or landing_ref_name or commit_id
+        default_landing_ref = at_ref or landing_ref_name or commit_id
     else:
         route_qry = None
-        default_commit_id = commit_id
+        default_landing_ref = commit_id
 
-    # first segment is a `..` link to repo files
+    # first segment is a `HOME` link to repo files root location
     root_name = literal(u'<i class="icon-home"></i>')
+
     url_segments = [
         link_to(
             root_name,
-            route_path(
-                'repo_files',
-                repo_name=repo_name,
-                commit_id=default_commit_id,
-                f_path='',
-                _query=route_qry),
+            repo_files_by_ref_url(
+                repo_name,
+                repo_type,
+                f_path=None,  # None here is a special case for SVN repos,
+                              # that won't prefix with a ref
+                ref_name=default_landing_ref,
+                commit_id=commit_id,
+                query=route_qry
+            )
         )]
 
     path_segments = file_path.split('/')
@@ -301,12 +306,14 b' def files_breadcrumbs(repo_name, commit_'
             url_segments.append(
                 link_to(
                     segment_html,
-                    route_path(
-                        'repo_files',
-                        repo_name=repo_name,
-                        commit_id=default_commit_id,
+                    repo_files_by_ref_url(
+                        repo_name,
+                        repo_type,
                         f_path='/'.join(path_segments[:cnt + 1]),
-                        _query=route_qry),
+                        ref_name=default_landing_ref,
+                        commit_id=commit_id,
+                        query=route_qry
+                    ),
                 ))
 
     limited_url_segments = url_segments[:1] + ['...'] + url_segments[-5:]
@@ -337,6 +344,54 b' def files_url_data(request):'
     return json.dumps(matchdict)
 
 
+def repo_files_by_ref_url(db_repo_name, db_repo_type, f_path, ref_name, commit_id, query=None, ):
+    _is_svn = is_svn(db_repo_type)
+    final_f_path = f_path
+
+    if _is_svn:
+        """
+        For SVN the ref_name cannot be used as a commit_id, it needs to be prefixed with
+        actually commit_id followed by the ref_name. This should be done only in case
+        This is a initial landing url, without additional paths.
+
+        like: /1000/tags/1.0.0/?at=tags/1.0.0
+        """
+
+        if ref_name and ref_name != 'tip':
+            # NOTE(marcink): for svn the ref_name is actually the stored path, so we prefix it
+            # for SVN we only do this magic prefix if it's root, .eg landing revision
+            # of files link. If we are in the tree we don't need this since we traverse the url
+            # that has everything stored
+            if f_path in ['', '/']:
+                final_f_path = '/'.join([ref_name, f_path])
+
+        # SVN always needs a commit_id explicitly, without a named REF
+        default_commit_id = commit_id
+    else:
+        """
+        For git and mercurial we construct a new URL using the names instead of commit_id
+        like: /master/some_path?at=master
+        """
+        # We currently do not support branches with slashes
+        if '/' in ref_name:
+            default_commit_id = commit_id
+        else:
+            default_commit_id = ref_name
+
+    # sometimes we pass f_path as None, to indicate explicit no prefix,
+    # we translate it to string to not have None
+    final_f_path = final_f_path or ''
+
+    files_url = route_path(
+        'repo_files',
+        repo_name=db_repo_name,
+        commit_id=default_commit_id,
+        f_path=final_f_path,
+        _query=query
+    )
+    return files_url
+
+
 def code_highlight(code, lexer, formatter, use_hl_filter=False):
     """
     Lex ``code`` with ``lexer`` and format it with the formatter ``formatter``.

rhodecode/lib/rc_cache/__init__.py

@@ -47,7 +47,7 b' from .utils import ('
     FreshRegionCache, ActiveRegionCache)
 
 
-FILE_TREE_CACHE_VER = 'v3'
+FILE_TREE_CACHE_VER = 'v4'
 
 
 def configure_dogpile_cache(settings):

rhodecode/templates/base/base.mako

@@ -365,7 +365,7 b''
       <ul id="context-pages" class="navigation horizontal-list">
         <li class="${h.is_active('summary', active)}"><a class="menulink" href="${h.route_path('repo_summary', repo_name=c.repo_name)}"><div class="menulabel">${_('Summary')}</div></a></li>
         <li class="${h.is_active('commits', active)}"><a class="menulink" href="${h.route_path('repo_commits', repo_name=c.repo_name)}"><div class="menulabel">${_('Commits')}</div></a></li>
-        <li class="${h.is_active('files', active)}"><a class="menulink" href="${h.route_path('repo_files', repo_name=c.repo_name, commit_id=c.rhodecode_db_repo.landing_ref_name, f_path='', _query={'at':c.rhodecode_db_repo.landing_ref_name})}"><div class="menulabel">${_('Files')}</div></a></li>
+        <li class="${h.is_active('files', active)}"><a class="menulink" href="${h.repo_files_by_ref_url(c.repo_name, c.rhodecode_db_repo.repo_type, f_path='', ref_name=c.rhodecode_db_repo.landing_ref_name, commit_id='tip', query={'at':c.rhodecode_db_repo.landing_ref_name})}"><div class="menulabel">${_('Files')}</div></a></li>
         <li class="${h.is_active('compare', active)}"><a class="menulink" href="${h.route_path('repo_compare_select',repo_name=c.repo_name)}"><div class="menulabel">${_('Compare')}</div></a></li>
 
         ## TODO: anderson: ideally it would have a function on the scm_instance "enable_pullrequest() and enable_fork()"

rhodecode/templates/files/files_add.mako

@@ -36,7 +36,7 b''
             <ul>
             <li class="breadcrumb-path">
                 <div>
-                    ${h.files_breadcrumbs(c.repo_name, c.commit.raw_id, c.f_path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=False, linkify_last_item=True, copy_path_icon=False)} /
+                    ${h.files_breadcrumbs(c.repo_name, c.rhodecode_db_repo.repo_type, c.commit.raw_id, c.f_path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=False, linkify_last_item=True, copy_path_icon=False)} /
                 </div>
             </li>
             <li class="location-path">

rhodecode/templates/files/files_browser_tree.mako

@@ -4,10 +4,10 b''
     at_ref = request.GET.get('at')
     if at_ref:
         query={'at': at_ref}
-        default_commit_id = at_ref or c.rhodecode_db_repo.landing_ref_name
+        default_landing_ref = at_ref or c.rhodecode_db_repo.landing_ref_name
     else:
         query=None
-        default_commit_id = c.commit.raw_id
+        default_landing_ref = c.commit.raw_id
 %>
 <div id="file-tree-wrapper" class="browser-body ${('full-load' if c.full_load else '')}">
     <table class="code-browser rctable repo_summary">
@@ -24,7 +24,7 b''
         <tbody id="tbody">
         <tr>
             <td colspan="5">
-                ${h.files_breadcrumbs(c.repo_name, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True)}
+                ${h.files_breadcrumbs(c.repo_name, c.rhodecode_db_repo.repo_type, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True)}
             </td>
         </tr>
 
@@ -44,7 +44,7 b''
                 % endif
               </span>
             % else:
-              <a href="${h.route_path('repo_files',repo_name=c.repo_name,commit_id=default_commit_id,f_path=h.safe_unicode(node.path), _query=query)}">
+              <a href="${h.repo_files_by_ref_url(c.repo_name, c.rhodecode_db_repo.repo_type, f_path=h.safe_unicode(node.path), ref_name=default_landing_ref, commit_id=c.commit.raw_id, query=query)}">
                 <i class="${('icon-file-text browser-file' if node.is_file() else 'icon-directory browser-dir')}"></i>${node.name}
               </a>
             % endif

rhodecode/templates/files/files_delete.mako

@@ -35,7 +35,7 b''
         <div class="path-items">
             <li class="breadcrumb-path">
                 <div>
-                    ${h.files_breadcrumbs(c.repo_name, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=True, copy_path_icon=False)} /
+                    ${h.files_breadcrumbs(c.repo_name, c.rhodecode_db_repo.repo_type, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=True, copy_path_icon=False)} /
                 </div>
             </li>
             <li class="location-path">

rhodecode/templates/files/files_edit.mako

@@ -36,7 +36,7 b''
             <ul>
             <li class="breadcrumb-path">
                 <div>
-                    ${h.files_breadcrumbs(c.repo_name, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=True, copy_path_icon=False)} /
+                    ${h.files_breadcrumbs(c.repo_name, c.rhodecode_db_repo.repo_type, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'), limit_items=True, hide_last_item=True, copy_path_icon=False)} /
                 </div>
             </li>
             <li class="location-path">

rhodecode/templates/files/files_source.mako

@@ -98,7 +98,7 b''
 
       <div class="path clear-fix">
           <div class="pull-left">
-            ${h.files_breadcrumbs(c.repo_name, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'))}
+            ${h.files_breadcrumbs(c.repo_name, c.rhodecode_db_repo.repo_type, c.commit.raw_id, c.file.path, c.rhodecode_db_repo.landing_ref_name, request.GET.get('at'))}
           </div>
 
           <div class="pull-right stats">

rhodecode/templates/search/search_content.mako

@@ -93,7 +93,7 b''
 
         <div class="path clear-fix">
             <div class="pull-left">
-                ${h.files_breadcrumbs(entry['repository'], entry.get('commit_id', 'tip'), entry['f_path'], linkify_last_item=True)}
+                ${h.files_breadcrumbs(entry['repository'], repo_type, entry.get('commit_id', 'tip'), entry['f_path'], linkify_last_item=True)}
             </div>
 
             <div class="pull-right stats">