url-parsing: fix for bug #5218, remove not allowed chars from uri

- Quoting special chars in  uri, instead of removing them.

rhodecode/lib/utils2.py

@@ -515,6 +515,16 b' def age(prevdate, now=None, show_short_v'
     return _(u'just now')
 
 
+def cleaned_uri(uri):
+    """
+    Quotes '[' and ']' from uri if there is only one of them.
+        according to RFC3986 we cannot use such chars in uri
+    :param uri:
+    :return: uri without this chars
+    """
+    return urllib.quote(uri, safe='@$:/')
+
+
 def uri_filter(uri):
     """
     Removes user:password from given url string

rhodecode/model/db.py

@@ -53,7 +53,7 b' from rhodecode.lib.vcs.backends.base imp'
 from rhodecode.lib.utils2 import (
     str2bool, safe_str, get_commit_safe, safe_unicode, md5_safe,
     time_to_datetime, aslist, Optional, safe_int, get_clone_url, AttributeDict,
-    glob2re, StrictAttributeDict)
+    glob2re, StrictAttributeDict, cleaned_uri)
 from rhodecode.lib.jsonalchemy import MutationObj, MutationList, JsonType
 from rhodecode.lib.ext_json import json
 from rhodecode.lib.caching_query import FromCache
@@ -1822,7 +1822,7 b' class Repository(Base, BaseModel):'
         clone_uri = self.clone_uri
         if clone_uri:
             import urlobject
-            url_obj = urlobject.URLObject(clone_uri)
+            url_obj = urlobject.URLObject(cleaned_uri(clone_uri))
             if url_obj.password:
                 clone_uri = url_obj.with_password('*****')
         return clone_uri