##// END OF EJS Templates
reviewers: use common function to obtain reviewers with filter of role.
marcink -
r4514:96651613 stable
parent child
Show More
@@ -399,7 +399,7 class CommentsModel(BaseModel):
399 recipients += [pull_request_obj.author]
399 recipients += [pull_request_obj.author]
400
400
401 # add the reviewers to notification
401 # add the reviewers to notification
402 recipients += [x.user for x in pull_request_obj.reviewers]
402 recipients += [x.user for x in pull_request_obj.get_pull_request_reviewers()]
403
403
404 pr_target_repo = pull_request_obj.target_repo
404 pr_target_repo = pull_request_obj.target_repo
405 pr_source_repo = pull_request_obj.source_repo
405 pr_source_repo = pull_request_obj.source_repo
@@ -1526,7 +1526,7 class PullRequestModel(BaseModel):
1526 commit_changes, file_changes):
1526 commit_changes, file_changes):
1527
1527
1528 updating_user_id = updating_user.user_id
1528 updating_user_id = updating_user.user_id
1529 reviewers = set([x.user.user_id for x in pull_request.reviewers])
1529 reviewers = set([x.user.user_id for x in pull_request.get_pull_request_reviewers()])
1530 # NOTE(marcink): send notification to all other users except to
1530 # NOTE(marcink): send notification to all other users except to
1531 # person who updated the PR
1531 # person who updated the PR
1532 recipients = reviewers.difference(set([updating_user_id]))
1532 recipients = reviewers.difference(set([updating_user_id]))
General Comments 0
You need to be logged in to leave comments. Login now