tests: fixed few possible cases of detached instance errors.

rhodecode/apps/repository/tests/test_vcs_settings.py

@@ -22,6 +22,7 b' import mock'
 import pytest
 
 import rhodecode
+from rhodecode.model.db import Repository
 from rhodecode.model.settings import SettingsModel
 from rhodecode.tests import url
 from rhodecode.tests.utils import AssertResponse
@@ -87,10 +88,11 b' class TestAdminRepoVcsSettings(object):'
             pytest.skip('Setting not available for backend {}'.format(backend))
 
         repo = backend.create_repo()
+        repo_name = repo.repo_name
 
         settings_model = SettingsModel(repo=repo)
         vcs_settings_url = url(
-            'repo_vcs_settings', repo_name=repo.repo_name)
+            'repo_vcs_settings', repo_name=repo_name)
 
         self.app.post(
             vcs_settings_url,
@@ -101,6 +103,7 b' class TestAdminRepoVcsSettings(object):'
                 'rhodecode_{}'.format(setting_name): 'true',
                 'csrf_token': csrf_token,
             })
+        settings_model = SettingsModel(repo=Repository.get_by_repo_name(repo_name))
         setting = settings_model.get_setting_by_name(setting_name)
         assert setting.app_settings_value
 
@@ -113,5 +116,6 b' class TestAdminRepoVcsSettings(object):'
                 'rhodecode_{}'.format(setting_name): 'false',
                 'csrf_token': csrf_token,
             })
+        settings_model = SettingsModel(repo=Repository.get_by_repo_name(repo_name))
         setting = settings_model.get_setting_by_name(setting_name)
         assert not setting.app_settings_value

rhodecode/tests/functional/test_admin_repos_issuetracker.py

@@ -21,6 +21,7 b''
 import pytest
 
 from rhodecode.lib.utils2 import md5
+from rhodecode.model.db import Repository
 from rhodecode.model.meta import Session
 from rhodecode.model.settings import SettingsModel, IssueTrackerSettingsModel
 from rhodecode.tests import url
@@ -100,6 +101,7 b' class TestAdminRepos:'
     def test_delete_issuetracker_pattern(
             self, autologin_user, backend, csrf_token, settings_util):
         repo = backend.create_repo()
+        repo_name = repo.repo_name
         entry_key = 'issuetracker_pat_'
         pattern = 'issuetracker_pat3'
         uid = md5(pattern)
@@ -115,5 +117,6 b' class TestAdminRepos:'
                 'uid': uid,
                 'csrf_token': csrf_token
             }, status=302)
-        settings = IssueTrackerSettingsModel(repo=repo).get_repo_settings()
+        settings = IssueTrackerSettingsModel(
+            repo=Repository.get_by_repo_name(repo_name)).get_repo_settings()
         assert 'rhodecode_%s%s' % (entry_key, uid) not in settings