integrations: add repo group integrations, fixes #4175

rhodecode/integrations/routes.py

@@ -1,133 +1,200 b''
 # -*- coding: utf-8 -*-
 
 # Copyright (C) 2012-2016  RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import logging
 
-from rhodecode.model.db import Repository, Integration
+from rhodecode.model.db import Repository, Integration, RepoGroup
 from rhodecode.config.routing import (
     ADMIN_PREFIX, add_route_requirements, URL_NAME_REQUIREMENTS)
 from rhodecode.integrations import integration_type_registry
 
 log = logging.getLogger(__name__)
 
 
 def includeme(config):
+
+    # global integrations
     config.add_route('global_integrations_home',
                      ADMIN_PREFIX + '/integrations')
     config.add_route('global_integrations_list',
                      ADMIN_PREFIX + '/integrations/{integration}')
     for route_name in ['global_integrations_home', 'global_integrations_list']:
         config.add_view('rhodecode.integrations.views.GlobalIntegrationsView',
                         attr='index',
                         renderer='rhodecode:templates/admin/integrations/list.html',
                         request_method='GET',
                         route_name=route_name)
 
     config.add_route('global_integrations_create',
                      ADMIN_PREFIX + '/integrations/{integration}/new',
                      custom_predicates=(valid_integration,))
     config.add_route('global_integrations_edit',
                      ADMIN_PREFIX + '/integrations/{integration}/{integration_id}',
                      custom_predicates=(valid_integration,))
     for route_name in ['global_integrations_create', 'global_integrations_edit']:
         config.add_view('rhodecode.integrations.views.GlobalIntegrationsView',
                         attr='settings_get',
                         renderer='rhodecode:templates/admin/integrations/edit.html',
                         request_method='GET',
                         route_name=route_name)
         config.add_view('rhodecode.integrations.views.GlobalIntegrationsView',
                         attr='settings_post',
                         renderer='rhodecode:templates/admin/integrations/edit.html',
                         request_method='POST',
                         route_name=route_name)
 
+
+    # repo integrations
     config.add_route('repo_integrations_home',
                      add_route_requirements(
                         '{repo_name}/settings/integrations',
                         URL_NAME_REQUIREMENTS
                      ),
                      custom_predicates=(valid_repo,))
     config.add_route('repo_integrations_list',
                      add_route_requirements(
                         '{repo_name}/settings/integrations/{integration}',
                         URL_NAME_REQUIREMENTS
                      ),
                      custom_predicates=(valid_repo, valid_integration))
     for route_name in ['repo_integrations_home', 'repo_integrations_list']:
         config.add_view('rhodecode.integrations.views.RepoIntegrationsView',
                         attr='index',
                         request_method='GET',
                         route_name=route_name)
 
     config.add_route('repo_integrations_create',
                      add_route_requirements(
                         '{repo_name}/settings/integrations/{integration}/new',
                         URL_NAME_REQUIREMENTS
                      ),
                      custom_predicates=(valid_repo, valid_integration))
     config.add_route('repo_integrations_edit',
                      add_route_requirements(
                         '{repo_name}/settings/integrations/{integration}/{integration_id}',
                         URL_NAME_REQUIREMENTS
                      ),
                      custom_predicates=(valid_repo, valid_integration))
     for route_name in ['repo_integrations_edit', 'repo_integrations_create']:
         config.add_view('rhodecode.integrations.views.RepoIntegrationsView',
                         attr='settings_get',
                         renderer='rhodecode:templates/admin/integrations/edit.html',
                         request_method='GET',
                         route_name=route_name)
         config.add_view('rhodecode.integrations.views.RepoIntegrationsView',
                         attr='settings_post',
                         renderer='rhodecode:templates/admin/integrations/edit.html',
                         request_method='POST',
                         route_name=route_name)
 
 
+    # repo group integrations
+    config.add_route('repo_group_integrations_home',
+                     add_route_requirements(
+                        '{repo_group_name}/settings/integrations',
+                        URL_NAME_REQUIREMENTS
+                     ),
+                     custom_predicates=(valid_repo_group,))
+    config.add_route('repo_group_integrations_list',
+                     add_route_requirements(
+                        '{repo_group_name}/settings/integrations/{integration}',
+                        URL_NAME_REQUIREMENTS
+                     ),
+                     custom_predicates=(valid_repo_group, valid_integration))
+    for route_name in ['repo_group_integrations_home', 'repo_group_integrations_list']:
+        config.add_view('rhodecode.integrations.views.RepoGroupIntegrationsView',
+                        attr='index',
+                        request_method='GET',
+                        route_name=route_name)
+
+    config.add_route('repo_group_integrations_create',
+                     add_route_requirements(
+                        '{repo_group_name}/settings/integrations/{integration}/new',
+                        URL_NAME_REQUIREMENTS
+                     ),
+                     custom_predicates=(valid_repo_group, valid_integration))
+    config.add_route('repo_group_integrations_edit',
+                     add_route_requirements(
+                        '{repo_group_name}/settings/integrations/{integration}/{integration_id}',
+                        URL_NAME_REQUIREMENTS
+                     ),
+                     custom_predicates=(valid_repo_group, valid_integration))
+    for route_name in ['repo_group_integrations_edit', 'repo_group_integrations_create']:
+        config.add_view('rhodecode.integrations.views.RepoGroupIntegrationsView',
+                        attr='settings_get',
+                        renderer='rhodecode:templates/admin/integrations/edit.html',
+                        request_method='GET',
+                        route_name=route_name)
+        config.add_view('rhodecode.integrations.views.RepoGroupIntegrationsView',
+                        attr='settings_post',
+                        renderer='rhodecode:templates/admin/integrations/edit.html',
+                        request_method='POST',
+                        route_name=route_name)
+
+
 def valid_repo(info, request):
     repo = Repository.get_by_repo_name(info['match']['repo_name'])
     if repo:
         return True
 
 
+def valid_repo_group(info, request):
+    repo_group = RepoGroup.get_by_group_name(info['match']['repo_group_name'])
+    if repo_group:
+        return True
+    return False
+
+
 def valid_integration(info, request):
     integration_type = info['match']['integration']
     integration_id = info['match'].get('integration_id')
     repo_name = info['match'].get('repo_name')
+    repo_group_name = info['match'].get('repo_group_name')
 
     if integration_type not in integration_type_registry:
         return False
 
-    repo = None
+    repo, repo_group = None, None
     if repo_name:
-        repo = Repository.get_by_repo_name(info['match']['repo_name'])
+        repo = Repository.get_by_repo_name(repo_name)
         if not repo:
             return False
 
+    if repo_group_name:
+        repo_group = RepoGroup.get_by_group_name(repo_group_name)
+        if not repo_group:
+            return False
+
+    if repo_name and repo_group:
+        raise Exception('Either repo or repo_group can be set, not both')
+
+
     if integration_id:
         integration = Integration.get(integration_id)
         if not integration:
             return False
         if integration.integration_type != integration_type:
             return False
         if repo and repo.repo_id != integration.repo_id:
             return False
+        if repo_group and repo_group.repo_group_id != integration.repo_group_id:
+            return False
 
     return True

rhodecode/integrations/views.py

@@ -1,272 +1,299 b''
 # -*- coding: utf-8 -*-
 
 # Copyright (C) 2012-2016  RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 import colander
 import logging
 import pylons
 import deform
 
 from pyramid.httpexceptions import HTTPFound, HTTPForbidden
 from pyramid.renderers import render
 from pyramid.response import Response
 
 from rhodecode.lib import auth
 from rhodecode.lib.auth import LoginRequired, HasPermissionAllDecorator
-from rhodecode.model.db import Repository, Session, Integration
+from rhodecode.model.db import Repository, RepoGroup, Session, Integration
 from rhodecode.model.scm import ScmModel
 from rhodecode.model.integration import IntegrationModel
 from rhodecode.admin.navigation import navigation_list
 from rhodecode.translation import _
 from rhodecode.integrations import integration_type_registry
 
 log = logging.getLogger(__name__)
 
 
 class IntegrationSettingsViewBase(object):
     """ Base Integration settings view used by both repo / global settings """
 
     def __init__(self, context, request):
         self.context = context
         self.request = request
         self._load_general_context()
 
         if not self.perm_check(request.user):
             raise HTTPForbidden()
 
     def _load_general_context(self):
         """
         This avoids boilerplate for repo/global+list/edit+views/templates
         by doing all possible contexts at the same time however it should
         be split up into separate functions once more "contexts" exist
         """
 
         self.IntegrationType = None
         self.repo = None
+        self.repo_group = None
         self.integration = None
         self.integrations = {}
 
         request = self.request
 
         if 'repo_name' in request.matchdict:  # we're in a repo context
             repo_name = request.matchdict['repo_name']
             self.repo = Repository.get_by_repo_name(repo_name)
 
+        if 'repo_group_name' in request.matchdict: # we're in repo_group context
+            repo_group_name = request.matchdict['repo_group_name']
+            self.repo_group = RepoGroup.get_by_group_name(repo_group_name)
+
         if 'integration' in request.matchdict:  # we're in integration context
             integration_type = request.matchdict['integration']
             self.IntegrationType = integration_type_registry[integration_type]
 
         if 'integration_id' in request.matchdict:  # single integration context
             integration_id = request.matchdict['integration_id']
             self.integration = Integration.get(integration_id)
         else:                                      # list integrations context
-            for integration in IntegrationModel().get_integrations(self.repo):
+            integrations = IntegrationModel().get_integrations(
+                repo=self.repo, repo_group=self.repo_group)
+
+            for integration in integrations:
                 self.integrations.setdefault(integration.integration_type, []
                     ).append(integration)
 
         self.settings = self.integration and self.integration.settings or {}
 
     def _template_c_context(self):
         # TODO: dan: this is a stopgap in order to inherit from current pylons
         # based admin/repo settings templates - this should be removed entirely
         # after port to pyramid
 
         c = pylons.tmpl_context
         c.active = 'integrations'
         c.rhodecode_user = self.request.user
         c.repo = self.repo
+        c.repo_group = self.repo_group
         c.repo_name = self.repo and self.repo.repo_name or None
+        c.repo_group_name = self.repo_group and self.repo_group.group_name or None
         if self.repo:
             c.repo_info = self.repo
             c.rhodecode_db_repo = self.repo
             c.repository_pull_requests = ScmModel().get_pull_requests(self.repo)
         else:
             c.navlist = navigation_list(self.request)
 
         return c
 
     def _form_schema(self):
         if self.integration:
             settings = self.integration.settings
         else:
             settings = {}
         return self.IntegrationType(settings=settings).settings_schema()
 
     def settings_get(self, defaults=None, errors=None, form=None):
         """
         View that displays the plugin settings as a form.
         """
         defaults = defaults or {}
         errors = errors or {}
 
         if self.integration:
             defaults = self.integration.settings or {}
             defaults['name'] = self.integration.name
             defaults['enabled'] = self.integration.enabled
         else:
             if self.repo:
-                scope = self.repo.repo_name
+                scope = _('{repo_name} repository').format(
+                    repo_name=self.repo.repo_name)
+            elif self.repo_group:
+                scope = _('{repo_group_name} repo group').format(
+                    repo_group_name=self.repo_group.group_name)
             else:
                 scope = _('Global')
 
             defaults['name'] = '{} {} integration'.format(scope,
                 self.IntegrationType.display_name)
             defaults['enabled'] = True
 
         schema = self._form_schema().bind(request=self.request)
 
         if self.integration:
             buttons = ('submit', 'delete')
         else:
             buttons = ('submit',)
 
         form = form or deform.Form(schema, appstruct=defaults, buttons=buttons)
 
         for node in schema:
             setting = self.settings.get(node.name)
             if setting is not None:
                 defaults.setdefault(node.name, setting)
             else:
                 if node.default:
                     defaults.setdefault(node.name, node.default)
 
         template_context = {
             'form': form,
             'defaults': defaults,
             'errors': errors,
             'schema': schema,
             'current_IntegrationType': self.IntegrationType,
             'integration': self.integration,
             'settings': self.settings,
             'resource': self.context,
             'c': self._template_c_context(),
         }
 
         return template_context
 
     @auth.CSRFRequired()
     def settings_post(self):
         """
         View that validates and stores the plugin settings.
         """
         if self.request.params.get('delete'):
             Session().delete(self.integration)
             Session().commit()
             self.request.session.flash(
                 _('Integration {integration_name} deleted successfully.').format(
                     integration_name=self.integration.name),
                 queue='success')
             if self.repo:
                 redirect_to = self.request.route_url(
                     'repo_integrations_home', repo_name=self.repo.repo_name)
             else:
                 redirect_to = self.request.route_url('global_integrations_home')
             raise HTTPFound(redirect_to)
 
         schema = self._form_schema().bind(request=self.request)
 
         form = deform.Form(schema, buttons=('submit', 'delete'))
 
         params = {}
         for node in schema.children:
             if type(node.typ) in (colander.Set, colander.List):
                 val = self.request.params.getall(node.name)
             else:
                 val = self.request.params.get(node.name)
             if val:
                 params[node.name] = val
 
         controls = self.request.POST.items()
         try:
             valid_data = form.validate(controls)
         except deform.ValidationFailure as e:
             self.request.session.flash(
                 _('Errors exist when saving integration settings. '
                   'Please check the form inputs.'),
                 queue='error')
             return self.settings_get(errors={}, defaults=params, form=e)
 
         if not self.integration:
             self.integration = Integration()
             self.integration.integration_type = self.IntegrationType.key
             if self.repo:
                 self.integration.repo = self.repo
+            elif self.repo_group:
+                self.integration.repo_group = self.repo_group
             Session().add(self.integration)
 
         self.integration.enabled = valid_data.pop('enabled', False)
         self.integration.name = valid_data.pop('name')
         self.integration.settings = valid_data
 
         Session().commit()
 
         # Display success message and redirect.
         self.request.session.flash(
             _('Integration {integration_name} updated successfully.').format(
                 integration_name=self.IntegrationType.display_name),
             queue='success')
 
         if self.repo:
             redirect_to = self.request.route_url(
                 'repo_integrations_edit', repo_name=self.repo.repo_name,
                 integration=self.integration.integration_type,
                 integration_id=self.integration.integration_id)
+        elif self.repo:
+            redirect_to = self.request.route_url(
+                'repo_group_integrations_edit',
+                repo_group_name=self.repo_group.group_name,
+                integration=self.integration.integration_type,
+                integration_id=self.integration.integration_id)
         else:
             redirect_to = self.request.route_url(
                 'global_integrations_edit',
                 integration=self.integration.integration_type,
                 integration_id=self.integration.integration_id)
 
         return HTTPFound(redirect_to)
 
     def index(self):
         current_integrations = self.integrations
         if self.IntegrationType:
             current_integrations = {
                 self.IntegrationType.key: self.integrations.get(
                     self.IntegrationType.key, [])
             }
 
         template_context = {
             'current_IntegrationType': self.IntegrationType,
             'current_integrations': current_integrations,
             'available_integrations': integration_type_registry,
             'c': self._template_c_context()
         }
 
         if self.repo:
             html = render('rhodecode:templates/admin/integrations/list.html',
                           template_context,
                           request=self.request)
         else:
             html = render('rhodecode:templates/admin/integrations/list.html',
                           template_context,
                           request=self.request)
 
         return Response(html)
 
 
 class GlobalIntegrationsView(IntegrationSettingsViewBase):
     def perm_check(self, user):
         return auth.HasPermissionAll('hg.admin').check_permissions(user=user)
 
 
 class RepoIntegrationsView(IntegrationSettingsViewBase):
     def perm_check(self, user):
         return auth.HasRepoPermissionAll('repository.admin'
             )(repo_name=self.repo.repo_name, user=user)
+
+class RepoGroupIntegrationsView(IntegrationSettingsViewBase):
+    def perm_check(self, user):
+        return auth.HasRepoGroupPermissionAll('group.admin'
+            )(group_name=self.repo_group.group_name, user=user)

rhodecode/model/integration.py

@@ -1,132 +1,140 b''
 # -*- coding: utf-8 -*-
 
 # Copyright (C) 2011-2016  RhodeCode GmbH
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU Affero General Public License, version 3
 # (only), as published by the Free Software Foundation.
 #
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # This program is dual-licensed. If you wish to learn more about the
 # RhodeCode Enterprise Edition, including its added features, Support services,
 # and proprietary license terms, please see https://rhodecode.com/licenses/
 
 
 """
 Model for integrations
 """
 
 
 import logging
 import traceback
 
 from pylons import tmpl_context as c
 from pylons.i18n.translation import _, ungettext
 from sqlalchemy import or_
 from sqlalchemy.sql.expression import false, true
 from mako import exceptions
 
 import rhodecode
 from rhodecode import events
 from rhodecode.lib import helpers as h
 from rhodecode.lib.caching_query import FromCache
 from rhodecode.lib.utils import PartialRenderer
 from rhodecode.model import BaseModel
 from rhodecode.model.db import Integration, User
 from rhodecode.model.meta import Session
 from rhodecode.integrations import integration_type_registry
 from rhodecode.integrations.types.base import IntegrationTypeBase
 
 log = logging.getLogger(__name__)
 
 
 class IntegrationModel(BaseModel):
 
     cls = Integration
 
     def __get_integration(self, integration):
         if isinstance(integration, Integration):
             return integration
         elif isinstance(integration, (int, long)):
             return self.sa.query(Integration).get(integration)
         else:
             if integration:
                 raise Exception('integration must be int, long or Instance'
                                 ' of Integration got %s' % type(integration))
 
     def create(self, IntegrationType, enabled, name, settings, repo=None):
         """ Create an IntegrationType integration """
         integration = Integration()
         integration.integration_type = IntegrationType.key
         integration.settings = {}
         integration.repo = repo
         integration.enabled = enabled
         integration.name = name
 
         self.sa.add(integration)
         self.sa.commit()
         return integration
 
     def delete(self, integration):
         try:
             integration = self.__get_integration(integration)
             if integration:
                 self.sa.delete(integration)
                 return True
         except Exception:
             log.error(traceback.format_exc())
             raise
         return False
 
     def get_integration_handler(self, integration):
         TypeClass = integration_type_registry.get(integration.integration_type)
         if not TypeClass:
             log.error('No class could be found for integration type: {}'.format(
                 integration.integration_type))
             return None
 
         return TypeClass(integration.settings)
 
     def send_event(self, integration, event):
         """ Send an event to an integration """
         handler = self.get_integration_handler(integration)
         if handler:
             handler.send_event(event)
 
-    def get_integrations(self, repo=None):
+    def get_integrations(self, repo=None, repo_group=None):
         if repo:
             return self.sa.query(Integration).filter(
                 Integration.repo_id==repo.repo_id).all()
+        elif repo_group:
+            return self.sa.query(Integration).filter(
+                Integration.repo_group_id==repo_group.group_id).all()
 
         # global integrations
         return self.sa.query(Integration).filter(
             Integration.repo_id==None).all()
 
     def get_for_event(self, event, cache=False):
         """
         Get integrations that match an event
         """
         query = self.sa.query(Integration).filter(Integration.enabled==True)
 
         if isinstance(event, events.RepoEvent): # global + repo integrations
+                                                # + repo_group integrations
+            parent_groups = event.repo.groups_with_parents
             query = query.filter(
                         or_(Integration.repo_id==None,
-                            Integration.repo_id==event.repo.repo_id))
+                            Integration.repo_id==event.repo.repo_id,
+                            Integration.repo_group_id.in_(
+                                [group.group_id for group in parent_groups]
+                            )))
             if cache:
                 query = query.options(FromCache(
                     "sql_cache_short",
                     "get_enabled_repo_integrations_%i" % event.repo.repo_id))
         else: # only global integrations
             query = query.filter(Integration.repo_id==None)
             if cache:
                 query = query.options(FromCache(
                     "sql_cache_short", "get_enabled_global_integrations"))
 
         return query.all()

rhodecode/templates/admin/integrations/base.html

@@ -1,40 +1,42 b''
 ## -*- coding: utf-8 -*-
 <%!
    def inherit(context):
       if context['c'].repo:
         return "/admin/repos/repo_edit.html"
+      elif context['c'].repo_group:
+        return "/admin/repo_groups/repo_group_edit.html"
       else:
         return "/admin/settings/settings.html"
 %>
 <%inherit file="${inherit(context)}" />
 
 <%def name="title()">
     ${_('Integrations Settings')}
     %if c.rhodecode_name:
         &middot; ${h.branding(c.rhodecode_name)}
     %endif
 </%def>
 
 <%def name="breadcrumbs_links()">
     ${h.link_to(_('Admin'),h.url('admin_home'))}
     &raquo;
     ${_('Integrations')}
 </%def>
 
 <%def name="menu_bar_nav()">
   %if c.repo:
     ${self.menu_items(active='repositories')}
   %else:
     ${self.menu_items(active='admin')}
   %endif
 </%def>
 
 <%def name="menu_bar_subnav()">
   %if c.repo:
     ${self.repo_menu(active='options')}
   %endif
 </%def>
 
 <%def name="main_content()">
   ${next.body()}
 </%def>

rhodecode/templates/admin/integrations/list.html

@@ -1,147 +1,156 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="base.html"/>
 
 <%def name="breadcrumbs_links()">
   %if c.repo:
     ${h.link_to('Settings',h.url('edit_repo', repo_name=c.repo.repo_name))}
   %else:
     ${h.link_to(_('Admin'),h.url('admin_home'))}
     &raquo;
     ${h.link_to(_('Settings'),h.url('admin_settings'))}
   %endif
   %if current_IntegrationType:
     &raquo;
     %if c.repo:
     ${h.link_to(_('Integrations'),
       request.route_url(route_name='repo_integrations_home',
                         repo_name=c.repo.repo_name))}
     %else:
     ${h.link_to(_('Integrations'),
       request.route_url(route_name='global_integrations_home'))}
     %endif
     &raquo;
     ${current_IntegrationType.display_name}
   %else:
     &raquo;
     ${_('Integrations')}
   %endif
 </%def>
 <div class="panel panel-default">
   <div class="panel-heading">
     <h3 class="panel-title">${_('Create New Integration')}</h3>
   </div>
   <div class="panel-body">
   %if not available_integrations:
     ${_('No integrations available.')}
   %else:
     %for integration in available_integrations:
       <%
       if c.repo:
-        create_url = request.route_url('repo_integrations_create',
+        create_url = request.route_path('repo_integrations_create',
                                         repo_name=c.repo.repo_name,
                                         integration=integration)
+      elif c.repo_group:
+        create_url = request.route_path('repo_group_integrations_create',
+                                        repo_group_name=c.repo_group.group_name,
+                                        integration=integration)
       else:
-        create_url = request.route_url('global_integrations_create',
+        create_url = request.route_path('global_integrations_create',
                                         integration=integration)
       %>
       <a href="${create_url}" class="btn">
         ${integration}
       </a>
     %endfor
   %endif
   </div>
 </div>
 <div class="panel panel-default">
   <div class="panel-heading">
     <h3 class="panel-title">${_('Current Integrations')}</h3>
   </div>
   <div class="panel-body">
     <table class="rctable issuetracker">
       <thead>
         <tr>
             <th>${_('Enabled')}</th>
             <th>${_('Description')}</th>
             <th>${_('Type')}</th>
             <th>${_('Actions')}</th>
             <th></th>
         </tr>
       </thead>
       <tbody>
 
   %for integration_type, integrations in sorted(current_integrations.items()):
     %for integration in sorted(integrations, key=lambda x: x.name):
         <tr id="integration_${integration.integration_id}">
           <td class="td-enabled">
             %if integration.enabled:
             <div class="flag_status approved pull-left"></div>
             %else:
             <div class="flag_status rejected pull-left"></div>
             %endif
           </td>
           <td class="td-description">
             ${integration.name}
           </td>
           <td class="td-regex">
             ${integration.integration_type}
           </td>
           <td class="td-action">
           %if integration_type not in available_integrations:
           ${_('unknown integration')}
           %else:
             <%
             if c.repo:
-              edit_url = request.route_url('repo_integrations_edit',
+              edit_url = request.route_path('repo_integrations_edit',
                                             repo_name=c.repo.repo_name,
                                             integration=integration.integration_type,
                                             integration_id=integration.integration_id)
+            elif c.repo_group:
+              edit_url = request.route_path('repo_group_integrations_edit',
+                                            repo_group_name=c.repo_group.group_name,
+                                            integration=integration.integration_type,
+                                            integration_id=integration.integration_id)
             else:
-              edit_url = request.route_url('global_integrations_edit',
+              edit_url = request.route_path('global_integrations_edit',
                                            integration=integration.integration_type,
                                            integration_id=integration.integration_id)
             %>
             <div class="grid_edit">
               <a href="${edit_url}">${_('Edit')}</a>
             </div>
             <div class="grid_delete">
               <a href="${edit_url}"
                  class="btn btn-link btn-danger delete_integration_entry"
                  data-desc="${integration.name}"
                  data-uid="${integration.integration_id}">
                   ${_('Delete')}
               </a>
             </div>
           %endif
           </td>
         </tr>
       %endfor
     %endfor
       <tr id="last-row"></tr>
       </tbody>
     </table>
   </div>
 </div>
 <script type="text/javascript">
   var delete_integration = function(entry) {
     if (confirm("Confirm to remove this integration: "+$(entry).data('desc'))) {
       var request = $.ajax({
         type: "POST",
         url: $(entry).attr('href'),
         data: {
           'delete': 'delete',
           'csrf_token': CSRF_TOKEN
         },
         success: function(){
           location.reload();
         },
         error: function(data, textStatus, errorThrown){
           alert("Error while deleting entry.\nError code {0} ({1}). URL: {2}".format(data.status,data.statusText,$(entry)[0].url));
         }
       });
     };
   }
 
   $('.delete_integration_entry').on('click', function(e){
     e.preventDefault();
     delete_integration(this);
   });
 </script>
  No newline at end of file

rhodecode/templates/admin/repo_groups/repo_group_edit.html

@@ -1,56 +1,61 b''
 ## -*- coding: utf-8 -*-
 <%inherit file="/base/base.html"/>
 
 <%def name="title()">
     ${_('%s repository group settings') % c.repo_group.name}
     %if c.rhodecode_name:
         &middot; ${h.branding(c.rhodecode_name)}
     %endif
 </%def>
 
 <%def name="breadcrumbs_links()">
     ${h.link_to(_('Admin'),h.url('admin_home'))}
     &raquo;
     ${h.link_to(_('Repository Groups'),h.url('repo_groups'))}
     %if c.repo_group.parent_group:
         &raquo; ${h.link_to(c.repo_group.parent_group.name,h.url('repo_group_home',group_name=c.repo_group.parent_group.group_name))}
     %endif
     &raquo; ${c.repo_group.name}
 </%def>
 
 <%def name="breadcrumbs_side_links()">
     <ul class="links">
       <li>
           <a href="${h.url('new_repo_group', parent_group=c.repo_group.group_id)}" class="btn btn-small btn-success">${_(u'Add Child Group')}</a>
       </li>
     </ul>
 </%def>
 
 <%def name="menu_bar_nav()">
     ${self.menu_items(active='admin')}
 </%def>
 
+<%def name="main_content()">
+    <%include file="/admin/repo_groups/repo_group_edit_${c.active}.html"/>
+</%def>
+
 <%def name="main()">
 <div class="box">
   <div class="title">
       ${self.breadcrumbs()}
       ${self.breadcrumbs_side_links()}
   </div>
 
   <div class="sidebar-col-wrapper">
     ##main
     <div class="sidebar">
         <ul class="nav nav-pills nav-stacked">
           <li class="${'active' if c.active=='settings' else ''}"><a href="${h.url('edit_repo_group', group_name=c.repo_group.group_name)}">${_('Settings')}</a></li>
           <li class="${'active' if c.active=='perms' else ''}"><a href="${h.url('edit_repo_group_perms', group_name=c.repo_group.group_name)}">${_('Permissions')}</a></li>
           <li class="${'active' if c.active=='advanced' else ''}"><a href="${h.url('edit_repo_group_advanced', group_name=c.repo_group.group_name)}">${_('Advanced')}</a></li>
+          <li class="${'active' if c.active=='integrations' else ''}"><a href="${h.route_path('repo_group_integrations_home', repo_group_name=c.repo_group.group_name)}">${_('Integrations')}</a></li>
         </ul>
     </div>
 
     <div class="main-content-full-width">
-        <%include file="/admin/repo_groups/repo_group_edit_${c.active}.html"/>
+      ${self.main_content()}
     </div>
 
   </div>
 </div>
 </%def>