release: merge back stable branch into default

docs/release-notes/release-notes-4.23.1.rst

@@ -0,0 +1,43
+|RCE| 4.23.1 |RNS|
+------------------
+
+Release Date
+^^^^^^^^^^^^
+
+- 2020-11-25
+
+
+New Features
+^^^^^^^^^^^^
+
+
+
+General
+^^^^^^^
+
+
+
+Security
+^^^^^^^^
+
+
+
+Performance
+^^^^^^^^^^^
+
+-
+
+
+Fixes
+^^^^^
+
+- Comments: fixed inline comments TODO resolution
+- Comments: fixed some styling for TODO resolution.
+- Comments: fixed general comments live push.
+- Comments: fixed reply-to links from emails.
+- Reviewers: fixed some UI issues on larger screen when editing reviewers.
+
+Upgrade notes
+^^^^^^^^^^^^^
+
+- Un-scheduled release addressing problems in 4.23.X releases.

docs/release-notes/release-notes-4.23.2.rst

@@ -0,0 +1,48
+|RCE| 4.23.2 |RNS|
+------------------
+
+Release Date
+^^^^^^^^^^^^
+
+- 2020-12-06
+
+
+New Features
+^^^^^^^^^^^^
+
+
+
+General
+^^^^^^^
+
+- Repo extra keys: fixed some texts to improve UI.
+
+
+Security
+^^^^^^^^
+
+
+
+Performance
+^^^^^^^^^^^
+
+- Core: speed up cache loading on application startup.
+
+
+Fixes
+^^^^^
+
+- Diffs: added scroll down/scroll up helper. Fixes #5643
+- Diffs: fixed diff rendering when a common ancestor was a different commit than the source of changes.
+- Commits / changelog: small fixes from found problems.
+- Comments: side-bar comments hover also shows an ID of comment now.
+- Comments: make dismiss less prominent, and text only to not mix icons/text together.
+- Comments: UX improvements for comment buttons.
+- Reviewers: small ui fixes for display of review rules, and added new reviewer entries.
+- Pull-requests: fixed source/target in PR creation, affecting how we load default reviewers based on branches.
+
+
+Upgrade notes
+^^^^^^^^^^^^^
+
+- Un-scheduled release addressing problems in 4.23.X releases.

.hgtags

@@ -70,3 +70,6 3e635489bb7961df93b01e42454ad1a8730ae968
 7e2eb896a02ca7cd2cd9f0f853ef3dac3f0039e3 v4.20.1
 8bb5fece08ab65986225b184e46f53d2a71729cb v4.21.0
 90734aac31ee4563bbe665a43ff73190cc762275 v4.22.0
+a9655707f7cf4146affc51c12fe5ed8e02898a57 v4.23.0
+56310d93b33b97535908ef9c7b0985b89bb7fad2 v4.23.1
+7637c38528fa38c1eabc1fde6a869c20995a0da7 v4.23.2

docs/admin/system_admin/nginx/nginx-proxy-conf.rst

@@ -36,6 +36,8 timeout during large pushes.
     proxy_set_header            X-Host $http_host;
     proxy_set_header            X-Real-IP $remote_addr;
     proxy_set_header            X-Forwarded-For $proxy_add_x_forwarded_for;
+    proxy_set_header            X-Forwarded-Proto $proto;
+    proxy_set_header            X-Url-Scheme $scheme;
     proxy_set_header            Proxy-host $proxy_host;
 
     proxy_connect_timeout       7200;

docs/release-notes/release-notes.rst

@@ -9,6 +9,8 Release Notes
 .. toctree::
    :maxdepth: 1
 
+   release-notes-4.23.2.rst
+   release-notes-4.23.1.rst
    release-notes-4.23.0.rst
    release-notes-4.22.0.rst
    release-notes-4.21.0.rst

pkgs/python-packages.nix

@@ -1883,7 +1883,7 self: super: {
     };
   };
   "rhodecode-enterprise-ce" = super.buildPythonPackage {
-    name = "rhodecode-enterprise-ce-4.23.0";
+    name = "rhodecode-enterprise-ce-4.23.2";
     buildInputs = [
       self."pytest"
       self."py"

rhodecode/api/__init__.py

@@ -527,6 +527,14 class jsonrpc_deprecated_method(object):
         return result
 
 
+def add_api_methods(config):
+    from rhodecode.api.views import (
+        deprecated_api, gist_api, pull_request_api, repo_api, repo_group_api,
+        server_api, search_api, testing_api, user_api, user_group_api)
+
+    config.scan('rhodecode.api.views')
+
+
 def includeme(config):
     plugin_module = 'rhodecode.api'
     plugin_settings = get_plugin_settings(
@@ -549,7 +557,8 def includeme(config):
     config.add_route(
         'apiv2', plugin_settings.get('url', DEFAULT_URL), jsonrpc_call=True)
 
-    config.scan(plugin_module, ignore='rhodecode.api.tests')
     # register some exception handling view
     config.add_view(exception_view, context=JSONRPCBaseError)
     config.add_notfound_view(exception_view, jsonrpc_method_not_found=True)
+
+    add_api_methods(config)

rhodecode/apps/_base/navigation.py

@@ -144,3 +144,5 def includeme(config):
     labs_active = str2bool(settings.get('labs_settings_active', False))
     navigation_registry_instance = NavigationRegistry(labs_active=labs_active)
     config.registry.registerUtility(navigation_registry_instance)
+    log.debug('Created new nabigation instance, %s', navigation_registry_instance)
+

rhodecode/apps/admin/__init__.py

@@ -26,441 +26,1030 def admin_routes(config):
     """
     Admin prefixed routes
     """
+    from rhodecode.apps.admin.views.audit_logs import AdminAuditLogsView
+    from rhodecode.apps.admin.views.defaults import AdminDefaultSettingsView
+    from rhodecode.apps.admin.views.exception_tracker import ExceptionsTrackerView
+    from rhodecode.apps.admin.views.main_views import AdminMainView
+    from rhodecode.apps.admin.views.open_source_licenses import OpenSourceLicensesAdminSettingsView
+    from rhodecode.apps.admin.views.permissions import AdminPermissionsView
+    from rhodecode.apps.admin.views.process_management import AdminProcessManagementView
+    from rhodecode.apps.admin.views.repo_groups import AdminRepoGroupsView 
+    from rhodecode.apps.admin.views.repositories import AdminReposView
+    from rhodecode.apps.admin.views.sessions import AdminSessionSettingsView
+    from rhodecode.apps.admin.views.settings import AdminSettingsView
+    from rhodecode.apps.admin.views.svn_config import AdminSvnConfigView
+    from rhodecode.apps.admin.views.system_info import AdminSystemInfoSettingsView
+    from rhodecode.apps.admin.views.user_groups import AdminUserGroupsView
+    from rhodecode.apps.admin.views.users import AdminUsersView, UsersView
+    
     config.add_route(
         name='admin_audit_logs',
         pattern='/audit_logs')
+    config.add_view(
+        AdminAuditLogsView,
+        attr='admin_audit_logs',
+        route_name='admin_audit_logs', request_method='GET',
+        renderer='rhodecode:templates/admin/admin_audit_logs.mako')
 
     config.add_route(
         name='admin_audit_log_entry',
         pattern='/audit_logs/{audit_log_id}')
-
-    config.add_route(
-        name='pull_requests_global_0',  # backward compat
-        pattern='/pull_requests/{pull_request_id:\d+}')
-    config.add_route(
-        name='pull_requests_global_1',  # backward compat
-        pattern='/pull-requests/{pull_request_id:\d+}')
-    config.add_route(
-        name='pull_requests_global',
-        pattern='/pull-request/{pull_request_id:\d+}')
+    config.add_view(
+        AdminAuditLogsView,
+        attr='admin_audit_log_entry',
+        route_name='admin_audit_log_entry', request_method='GET',
+        renderer='rhodecode:templates/admin/admin_audit_log_entry.mako')
 
     config.add_route(
         name='admin_settings_open_source',
         pattern='/settings/open_source')
+    config.add_view(
+        OpenSourceLicensesAdminSettingsView,
+        attr='open_source_licenses',
+        route_name='admin_settings_open_source', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_vcs_svn_generate_cfg',
         pattern='/settings/vcs/svn_generate_cfg')
+    config.add_view(
+        AdminSvnConfigView,
+        attr='vcs_svn_generate_config',
+        route_name='admin_settings_vcs_svn_generate_cfg',
+        request_method='POST', renderer='json')
 
     config.add_route(
         name='admin_settings_system',
         pattern='/settings/system')
+    config.add_view(
+        AdminSystemInfoSettingsView,
+        attr='settings_system_info',
+        route_name='admin_settings_system', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_system_update',
         pattern='/settings/system/updates')
+    config.add_view(
+        AdminSystemInfoSettingsView,
+        attr='settings_system_info_check_update',
+        route_name='admin_settings_system_update', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings_system_update.mako')
 
     config.add_route(
         name='admin_settings_exception_tracker',
         pattern='/settings/exceptions')
+    config.add_view(
+        ExceptionsTrackerView,
+        attr='browse_exceptions',
+        route_name='admin_settings_exception_tracker', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_exception_tracker_delete_all',
-        pattern='/settings/exceptions/delete')
+        pattern='/settings/exceptions_delete_all')
+    config.add_view(
+        ExceptionsTrackerView,
+        attr='exception_delete_all',
+        route_name='admin_settings_exception_tracker_delete_all', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_exception_tracker_show',
         pattern='/settings/exceptions/{exception_id}')
+    config.add_view(
+        ExceptionsTrackerView,
+        attr='exception_show',
+        route_name='admin_settings_exception_tracker_show', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_exception_tracker_delete',
         pattern='/settings/exceptions/{exception_id}/delete')
+    config.add_view(
+        ExceptionsTrackerView,
+        attr='exception_delete',
+        route_name='admin_settings_exception_tracker_delete', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_sessions',
         pattern='/settings/sessions')
+    config.add_view(
+        AdminSessionSettingsView,
+        attr='settings_sessions',
+        route_name='admin_settings_sessions', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_sessions_cleanup',
         pattern='/settings/sessions/cleanup')
+    config.add_view(
+        AdminSessionSettingsView,
+        attr='settings_sessions_cleanup',
+        route_name='admin_settings_sessions_cleanup', request_method='POST')
 
     config.add_route(
         name='admin_settings_process_management',
         pattern='/settings/process_management')
+    config.add_view(
+        AdminProcessManagementView,
+        attr='process_management',
+        route_name='admin_settings_process_management', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_process_management_data',
         pattern='/settings/process_management/data')
+    config.add_view(
+        AdminProcessManagementView,
+        attr='process_management_data',
+        route_name='admin_settings_process_management_data', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings_process_management_data.mako')
+
     config.add_route(
         name='admin_settings_process_management_signal',
         pattern='/settings/process_management/signal')
+    config.add_view(
+        AdminProcessManagementView,
+        attr='process_management_signal',
+        route_name='admin_settings_process_management_signal',
+        request_method='POST', renderer='json_ext')
+
     config.add_route(
         name='admin_settings_process_management_master_signal',
         pattern='/settings/process_management/master_signal')
+    config.add_view(
+        AdminProcessManagementView,
+        attr='process_management_master_signal',
+        route_name='admin_settings_process_management_master_signal',
+        request_method='POST', renderer='json_ext')
 
     # default settings
     config.add_route(
         name='admin_defaults_repositories',
         pattern='/defaults/repositories')
+    config.add_view(
+        AdminDefaultSettingsView,
+        attr='defaults_repository_show',
+        route_name='admin_defaults_repositories', request_method='GET',
+        renderer='rhodecode:templates/admin/defaults/defaults.mako')
+
     config.add_route(
         name='admin_defaults_repositories_update',
         pattern='/defaults/repositories/update')
+    config.add_view(
+        AdminDefaultSettingsView,
+        attr='defaults_repository_update',
+        route_name='admin_defaults_repositories_update', request_method='POST',
+        renderer='rhodecode:templates/admin/defaults/defaults.mako')
 
     # admin settings
 
     config.add_route(
         name='admin_settings',
         pattern='/settings')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_global',
+        route_name='admin_settings', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_update',
         pattern='/settings/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_global_update',
+        route_name='admin_settings_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_global',
         pattern='/settings/global')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_global',
+        route_name='admin_settings_global', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_global_update',
         pattern='/settings/global/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_global_update',
+        route_name='admin_settings_global_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_vcs',
         pattern='/settings/vcs')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_vcs',
+        route_name='admin_settings_vcs', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_vcs_update',
         pattern='/settings/vcs/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_vcs_update',
+        route_name='admin_settings_vcs_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_vcs_svn_pattern_delete',
         pattern='/settings/vcs/svn_pattern_delete')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_vcs_delete_svn_pattern',
+        route_name='admin_settings_vcs_svn_pattern_delete', request_method='POST',
+        renderer='json_ext', xhr=True)
 
     config.add_route(
         name='admin_settings_mapping',
         pattern='/settings/mapping')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_mapping',
+        route_name='admin_settings_mapping', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_mapping_update',
         pattern='/settings/mapping/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_mapping_update',
+        route_name='admin_settings_mapping_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_visual',
         pattern='/settings/visual')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_visual',
+        route_name='admin_settings_visual', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_visual_update',
         pattern='/settings/visual/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_visual_update',
+        route_name='admin_settings_visual_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_issuetracker',
         pattern='/settings/issue-tracker')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_issuetracker',
+        route_name='admin_settings_issuetracker', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_issuetracker_update',
         pattern='/settings/issue-tracker/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_issuetracker_update',
+        route_name='admin_settings_issuetracker_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_issuetracker_test',
         pattern='/settings/issue-tracker/test')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_issuetracker_test',
+        route_name='admin_settings_issuetracker_test', request_method='POST',
+        renderer='string', xhr=True)
+
     config.add_route(
         name='admin_settings_issuetracker_delete',
         pattern='/settings/issue-tracker/delete')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_issuetracker_delete',
+        route_name='admin_settings_issuetracker_delete', request_method='POST',
+        renderer='json_ext', xhr=True)
 
     config.add_route(
         name='admin_settings_email',
         pattern='/settings/email')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_email',
+        route_name='admin_settings_email', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_email_update',
         pattern='/settings/email/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_email_update',
+        route_name='admin_settings_email_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_hooks',
         pattern='/settings/hooks')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_hooks',
+        route_name='admin_settings_hooks', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_hooks_update',
         pattern='/settings/hooks/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_hooks_update',
+        route_name='admin_settings_hooks_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_hooks_delete',
         pattern='/settings/hooks/delete')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_hooks_update',
+        route_name='admin_settings_hooks_delete', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_search',
         pattern='/settings/search')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_search',
+        route_name='admin_settings_search', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     config.add_route(
         name='admin_settings_labs',
         pattern='/settings/labs')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_labs',
+        route_name='admin_settings_labs', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
+
     config.add_route(
         name='admin_settings_labs_update',
         pattern='/settings/labs/update')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_labs_update',
+        route_name='admin_settings_labs_update', request_method='POST',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     # Automation EE feature
     config.add_route(
         'admin_settings_automation',
         pattern=ADMIN_PREFIX + '/settings/automation')
+    config.add_view(
+        AdminSettingsView,
+        attr='settings_automation',
+        route_name='admin_settings_automation', request_method='GET',
+        renderer='rhodecode:templates/admin/settings/settings.mako')
 
     # global permissions
 
     config.add_route(
         name='admin_permissions_application',
         pattern='/permissions/application')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_application',
+        route_name='admin_permissions_application', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
+
     config.add_route(
         name='admin_permissions_application_update',
         pattern='/permissions/application/update')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_application_update',
+        route_name='admin_permissions_application_update', request_method='POST',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_global',
         pattern='/permissions/global')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_global',
+        route_name='admin_permissions_global', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
+    
     config.add_route(
         name='admin_permissions_global_update',
         pattern='/permissions/global/update')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_global_update',
+        route_name='admin_permissions_global_update', request_method='POST',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_object',
         pattern='/permissions/object')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_objects',
+        route_name='admin_permissions_object', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
+
     config.add_route(
         name='admin_permissions_object_update',
         pattern='/permissions/object/update')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_objects_update',
+        route_name='admin_permissions_object_update', request_method='POST',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     # Branch perms EE feature
     config.add_route(
         name='admin_permissions_branch',
         pattern='/permissions/branch')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_branch',
+        route_name='admin_permissions_branch', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_ips',
         pattern='/permissions/ips')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_ips',
+        route_name='admin_permissions_ips', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_overview',
         pattern='/permissions/overview')
+    config.add_view(
+        AdminPermissionsView,
+        attr='permissions_overview',
+        route_name='admin_permissions_overview', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_auth_token_access',
         pattern='/permissions/auth_token_access')
+    config.add_view(
+        AdminPermissionsView,
+        attr='auth_token_access',
+        route_name='admin_permissions_auth_token_access', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
 
     config.add_route(
         name='admin_permissions_ssh_keys',
         pattern='/permissions/ssh_keys')
+    config.add_view(
+        AdminPermissionsView,
+        attr='ssh_keys',
+        route_name='admin_permissions_ssh_keys', request_method='GET',
+        renderer='rhodecode:templates/admin/permissions/permissions.mako')
+
     config.add_route(
         name='admin_permissions_ssh_keys_data',
         pattern='/permissions/ssh_keys/data')
+    config.add_view(
+        AdminPermissionsView,
+        attr='ssh_keys_data',
+        route_name='admin_permissions_ssh_keys_data', request_method='GET',
+        renderer='json_ext', xhr=True)
+
     config.add_route(
         name='admin_permissions_ssh_keys_update',