repositories: handle in a nicer way a filesystem damaged repositories.

- redirect with proper flash message about damaged filesystem.

rhodecode/apps/_base/__init__.py

@@ -127,6 +127,23 b' class BaseAppView(object):'
                 raise HTTPFound(
                     self.request.route_path('my_account_password'))
 
+    def _log_creation_exception(self, e, repo_name):
+        _ = self.request.translate
+        reason = None
+        if len(e.args) == 2:
+            reason = e.args[1]
+
+        if reason == 'INVALID_CERTIFICATE':
+            log.exception(
+                'Exception creating a repository: invalid certificate')
+            msg = (_('Error creating repository %s: invalid certificate')
+                   % repo_name)
+        else:
+            log.exception("Exception creating a repository")
+            msg = (_('Error creating repository %s')
+                   % repo_name)
+        return msg
+
     def _get_local_tmpl_context(self, include_app_defaults=False):
         c = TemplateArgs()
         c.auth_user = self.request.user
@@ -196,6 +213,7 b' class RepoAppView(BaseAppView):'
             self.db_repo_name, error.message)
 
     def _get_local_tmpl_context(self, include_app_defaults=False):
+        _ = self.request.translate
         c = super(RepoAppView, self)._get_local_tmpl_context(
             include_app_defaults=include_app_defaults)
 
@@ -210,6 +228,17 b' class RepoAppView(BaseAppView):'
         except RepositoryRequirementError as e:
             c.repository_requirements_missing = True
             self._handle_missing_requirements(e)
+            self.rhodecode_vcs_repo = None
+
+        if (not c.repository_requirements_missing
+            and self.rhodecode_vcs_repo is None):
+            # unable to fetch this repo as vcs instance, report back to user
+            h.flash(_(
+                "The repository `%(repo_name)s` cannot be loaded in filesystem. "
+                "Please check if it exist, or is not damaged.") %
+                    {'repo_name': c.repo_name},
+                    category='error', ignore_duplicate=True)
+            raise HTTPFound(h.route_path('home'))
 
         return c
 

rhodecode/apps/repository/tests/test_repo_summary.py

@@ -26,7 +26,7 b' import pytest'
 from rhodecode.apps.repository.views.repo_summary import RepoSummaryView
 from rhodecode.lib import helpers as h
 from rhodecode.lib.compat import OrderedDict
-from rhodecode.lib.utils2 import AttributeDict
+from rhodecode.lib.utils2 import AttributeDict, safe_str
 from rhodecode.lib.vcs.exceptions import RepositoryRequirementError
 from rhodecode.model.db import Repository
 from rhodecode.model.meta import Session
@@ -259,7 +259,8 b' class TestSummaryView(object):'
 class TestRepoLocation(object):
 
     @pytest.mark.parametrize("suffix", [u'', u'ąęł'], ids=['', 'non-ascii'])
-    def test_manual_delete(self, autologin_user, backend, suffix, csrf_token):
+    def test_missing_filesystem_repo(
+            self, autologin_user, backend, suffix, csrf_token):
         repo = backend.create_repo(name_suffix=suffix)
         repo_name = repo.repo_name
 
@@ -272,13 +273,41 b' class TestRepoLocation(object):'
 
         # check if repo is not in the filesystem
         assert not repo_on_filesystem(repo_name)
-        self.assert_repo_not_found_redirect(repo_name)
+
+        response = self.app.get(
+            route_path('repo_summary', repo_name=safe_str(repo_name)), status=302)
+
+        msg = 'The repository `%s` cannot be loaded in filesystem. ' \
+              'Please check if it exist, or is not damaged.' % repo_name
+        assert_session_flash(response, msg)
+
+    @pytest.mark.parametrize("suffix", [u'', u'ąęł'], ids=['', 'non-ascii'])
+    def test_missing_filesystem_repo_on_repo_check(
+            self, autologin_user, backend, suffix, csrf_token):
+        repo = backend.create_repo(name_suffix=suffix)
+        repo_name = repo.repo_name
+
+        # delete from file system
+        RepoModel()._delete_filesystem_repo(repo)
 
-    def assert_repo_not_found_redirect(self, repo_name):
-        # run the check page that triggers the other flash message
-        response = self.app.get(h.url('repo_check_home', repo_name=repo_name))
-        assert_session_flash(
-            response, 'The repository at %s cannot be located.' % repo_name)
+        # test if the repo is still in the database
+        new_repo = RepoModel().get_by_repo_name(repo_name)
+        assert new_repo.repo_name == repo_name
+
+        # check if repo is not in the filesystem
+        assert not repo_on_filesystem(repo_name)
+
+        # flush the session
+        self.app.get(
+            route_path('repo_summary', repo_name=safe_str(repo_name)),
+            status=302)
+
+        response = self.app.get(
+            route_path('repo_creating_check', repo_name=safe_str(repo_name)),
+            status=200)
+        msg = 'The repository `%s` cannot be loaded in filesystem. ' \
+              'Please check if it exist, or is not damaged.' % repo_name
+        assert_session_flash(response, msg )
 
 
 @pytest.fixture()