landing-refs: create helpers for landing ref to make clear indication about type/name

rhodecode/apps/repository/tests/test_repo_files.py

@@ -178,7 +178,7 b' class TestFilesViews(object):'
                        commit_id='tip', f_path='/'))
 
         # make sure Files menu url is not tip but new commit
-        landing_rev = backend.repo.landing_rev[1]
+        landing_rev = backend.repo.landing_ref_name
         files_url = route_path('repo_files:default_path',
                                repo_name=backend.repo_name,
                                commit_id=landing_rev)

rhodecode/apps/repository/views/repo_files.py

@@ -137,7 +137,7 b' class RepoFilesView(RepoAppView):'
             raise HTTPFound(files_url)
 
     def _get_commit_and_path(self):
-        default_commit_id = self.db_repo.landing_rev[1]
+        default_commit_id = self.db_repo.landing_ref_name
         default_f_path = '/'
 
         commit_id = self.request.matchdict.get(

rhodecode/apps/repository/views/repo_forks.py

@@ -138,10 +138,10 b' class RepoForksView(RepoAppView, DataGri'
             url_link = h.route_path(
                 'repo_compare',
                 repo_name=fork.repo_name,
-                source_ref_type=self.db_repo.landing_rev[0],
-                source_ref=self.db_repo.landing_rev[1],
-                target_ref_type=self.db_repo.landing_rev[0],
-                target_ref=self.db_repo.landing_rev[1],
+                source_ref_type=self.db_repo.landing_ref_type,
+                source_ref=self.db_repo.landing_ref_name,
+                target_ref_type=self.db_repo.landing_ref_type,
+                target_ref=self.db_repo.landing_ref_name,
                 _query=dict(merge=1, target_repo=f.repo_name))
             return h.link_to(_('Compare fork'), url_link, class_='btn-link')
 

rhodecode/model/db.py

@@ -1758,7 +1758,7 b' class Repository(Base, BaseModel):'
 
     @hybrid_property
     def landing_rev(self):
-        # always should return [rev_type, rev]
+        # always should return [rev_type, rev], e.g ['branch', 'master']
         if self._landing_revision:
             _rev_info = self._landing_revision.split(':')
             if len(_rev_info) < 2:
@@ -1766,6 +1766,14 b' class Repository(Base, BaseModel):'
             return [_rev_info[0], _rev_info[1]]
         return [None, None]
 
+    @property
+    def landing_ref_type(self):
+        return self.landing_rev[0]
+
+    @property
+    def landing_ref_name(self):
+        return self.landing_rev[1]
+
     @landing_rev.setter
     def landing_rev(self, val):
         if ':' not in val:

rhodecode/templates/base/base.mako

@@ -365,7 +365,7 b''
       <ul id="context-pages" class="navigation horizontal-list">
         <li class="${h.is_active('summary', active)}"><a class="menulink" href="${h.route_path('repo_summary', repo_name=c.repo_name)}"><div class="menulabel">${_('Summary')}</div></a></li>
         <li class="${h.is_active('commits', active)}"><a class="menulink" href="${h.route_path('repo_commits', repo_name=c.repo_name)}"><div class="menulabel">${_('Commits')}</div></a></li>
-        <li class="${h.is_active('files', active)}"><a class="menulink" href="${h.route_path('repo_files', repo_name=c.repo_name, commit_id=c.rhodecode_db_repo.landing_rev[1], f_path='')}"><div class="menulabel">${_('Files')}</div></a></li>
+        <li class="${h.is_active('files', active)}"><a class="menulink" href="${h.route_path('repo_files', repo_name=c.repo_name, commit_id=c.rhodecode_db_repo.landing_ref_name, f_path='')}"><div class="menulabel">${_('Files')}</div></a></li>
         <li class="${h.is_active('compare', active)}"><a class="menulink" href="${h.route_path('repo_compare_select',repo_name=c.repo_name)}"><div class="menulabel">${_('Compare')}</div></a></li>
 
         ## TODO: anderson: ideally it would have a function on the scm_instance "enable_pullrequest() and enable_fork()"

rhodecode/templates/base/root.mako

@@ -6,7 +6,7 b" c.template_context['repo_name'] = getatt"
 go_import_header = ''
 if hasattr(c, 'rhodecode_db_repo'):
     c.template_context['repo_type'] = c.rhodecode_db_repo.repo_type
-    c.template_context['repo_landing_commit'] = c.rhodecode_db_repo.landing_rev[1]
+    c.template_context['repo_landing_commit'] = c.rhodecode_db_repo.landing_ref_name
     c.template_context['repo_id'] = c.rhodecode_db_repo.repo_id
     c.template_context['repo_view_type'] = h.get_repo_view_type(request)
 

rhodecode/templates/commits/changelog.mako

@@ -60,10 +60,10 b''
                             class="btn btn-small"
                             href="${h.route_path('repo_compare',
                                 repo_name=c.rhodecode_db_repo.fork.repo_name,
-                                source_ref_type=c.rhodecode_db_repo.landing_rev[0],
-                                source_ref=c.rhodecode_db_repo.landing_rev[1],
-                                target_ref_type='branch' if request.GET.get('branch') else c.rhodecode_db_repo.landing_rev[0],
-                                target_ref=request.GET.get('branch') or c.rhodecode_db_repo.landing_rev[1],
+                                source_ref_type=c.rhodecode_db_repo.landing_ref_type,
+                                source_ref=c.rhodecode_db_repo.landing_ref_name,
+                                target_ref_type='branch' if request.GET.get('branch') else c.rhodecode_db_repo.landing_ref_type,
+                                target_ref=request.GET.get('branch') or c.rhodecode_db_repo.landing_ref_name,
                                 _query=dict(merge=1, target_repo=c.repo_name))}"
                         >
                         ${_('Compare fork with Parent (%s)' % c.rhodecode_db_repo.fork.repo_name)}

rhodecode/templates/compare/compare_diff.mako

@@ -93,10 +93,10 b''
                                        <a class="btn btn-default" title="${h.tooltip(_('Compare fork with %s' % c.rhodecode_db_repo.fork.repo_name))}"
                                           href="${h.route_path('repo_compare',
                                                 repo_name=c.rhodecode_db_repo.fork.repo_name,
-                                                source_ref_type=c.rhodecode_db_repo.landing_rev[0],
-                                                source_ref=c.rhodecode_db_repo.landing_rev[1],
-                                                target_repo=c.repo_name,target_ref_type='branch' if request.GET.get('branch') else c.rhodecode_db_repo.landing_rev[0],
-                                                target_ref=request.GET.get('branch') or c.rhodecode_db_repo.landing_rev[1],
+                                                source_ref_type=c.rhodecode_db_repo.landing_ref_type,
+                                                source_ref=c.rhodecode_db_repo.landing_ref_name,
+                                                target_repo=c.repo_name,target_ref_type='branch' if request.GET.get('branch') else c.rhodecode_db_repo.landing_ref_type,
+                                                target_ref=request.GET.get('branch') or c.rhodecode_db_repo.landing_ref_name,
                                                 _query=dict(merge=1))}"
                                         >
                                        ${_('Compare with origin')}

rhodecode/templates/files/files_browser.mako

@@ -64,10 +64,10 b''
     %if c.readme_data:
     <div id="readme" class="anchor">
     <div class="box">
-        <div class="readme-title" title="${h.tooltip(_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_rev[0], c.rhodecode_db_repo.landing_rev[1]))}">
+        <div class="readme-title" title="${h.tooltip(_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_ref_type, c.rhodecode_db_repo.landing_ref_name))}">
             <div>
                 <i class="icon-file-text"></i>
-                <a href="${h.route_path('repo_files',repo_name=c.repo_name,commit_id=c.rhodecode_db_repo.landing_rev[1],f_path=c.readme_file)}">
+                <a href="${h.route_path('repo_files',repo_name=c.repo_name,commit_id=c.rhodecode_db_repo.landing_ref_name,f_path=c.readme_file)}">
                     ${c.readme_file}
                 </a>
             </div>

rhodecode/templates/summary/summary.mako

@@ -34,10 +34,10 b''
 <div id="readme" class="anchor">
 <div class="box">
 
-    <div class="readme-title" title="${h.tooltip(_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_rev[0], c.rhodecode_db_repo.landing_rev[1]))}">
+    <div class="readme-title" title="${h.tooltip(_('Readme file from commit %s:%s') % (c.rhodecode_db_repo.landing_ref_type, c.rhodecode_db_repo.landing_ref_name))}">
         <div>
             <i class="icon-file-text"></i>
-            <a href="${h.route_path('repo_files',repo_name=c.repo_name,commit_id=c.rhodecode_db_repo.landing_rev[1],f_path=c.readme_file)}">
+            <a href="${h.route_path('repo_files',repo_name=c.repo_name,commit_id=c.rhodecode_db_repo.landing_ref_name,f_path=c.readme_file)}">
                 ${c.readme_file}
             </a>
         </div>