##// END OF EJS Templates
logging: skip certain very large args/kwargs reporting in logs of called methods
super-admin -
r1073:176bb96a python3
parent child Browse files
Show More
@@ -336,16 +336,26 b' class HTTPApplication(object):'
336
336
337 # NOTE(marcink): trading complexity for slight performance
337 # NOTE(marcink): trading complexity for slight performance
338 if log.isEnabledFor(logging.DEBUG):
338 if log.isEnabledFor(logging.DEBUG):
339 no_args_methods = [
339 # also we SKIP printing out any of those methods args since they maybe excessive
340
340 just_args_methods = {
341 ]
341 'commitctx': ('content', 'removed', 'updated')
342 if method in no_args_methods:
342 }
343 if method in just_args_methods:
344 skip_args = just_args_methods[method]
343 call_args = ''
345 call_args = ''
346 call_kwargs = {}
347 for k in kwargs:
348 if k in skip_args:
349 # replace our skip key with dummy
350 call_kwargs[k] = f'RemovedParam({k})'
351 else:
352 call_kwargs[k] = kwargs[k]
344 else:
353 else:
345 call_args = args[1:]
354 call_args = args[1:]
355 call_kwargs = kwargs
346
356
347 log.debug('Method requested:`%s` with args:%s kwargs:%s context_uid: %s, repo_state_uid:%s',
357 log.debug('Method requested:`%s` with args:%s kwargs:%s context_uid: %s, repo_state_uid:%s',
348 method, call_args, kwargs, context_uid, repo_state_uid)
358 method, call_args, call_kwargs, context_uid, repo_state_uid)
349
359
350 statsd = request.registry.statsd
360 statsd = request.registry.statsd
351 if statsd:
361 if statsd:
@@ -418,7 +428,7 b' class HTTPApplication(object):'
418 'id': payload_id,
428 'id': payload_id,
419 'result': resp
429 'result': resp
420 }
430 }
421
431 log.debug('Serving data for method %s', method)
422 return resp
432 return resp
423
433
424 def vcs_stream_view(self, request):
434 def vcs_stream_view(self, request):
General Comments 0
You need to be logged in to leave comments. Login now