##// END OF EJS Templates
hooks: better error reporting for hooks module errors
super-admin -
r1159:90d8161d default
parent child Browse files
Show More
@@ -173,7 +173,12 b' def _get_hooks_client(extras):'
173 elif is_shadow_repo:
173 elif is_shadow_repo:
174 return HooksShadowRepoClient()
174 return HooksShadowRepoClient()
175 else:
175 else:
176 return HooksDummyClient(extras['hooks_module'])
176 try:
177 import_module = extras['hooks_module']
178 except KeyError:
179 log.error('Failed to get "hooks_module" from extras: %s', extras)
180 raise
181 return HooksDummyClient(import_module)
177
182
178
183
179 def _call_hook(hook_name, extras, writer):
184 def _call_hook(hook_name, extras, writer):
@@ -186,7 +186,6 b' class SvnRemote(RemoteBase):'
186 # NOTE(marcink): short circuit the check for SVN repo
186 # NOTE(marcink): short circuit the check for SVN repo
187 # the repos.open might be expensive to check, but we have one cheap
187 # the repos.open might be expensive to check, but we have one cheap
188 # pre condition that we can use, to check for 'format' file
188 # pre condition that we can use, to check for 'format' file
189
190 if not os.path.isfile(os.path.join(path, 'format')):
189 if not os.path.isfile(os.path.join(path, 'format')):
191 return False
190 return False
192
191
General Comments 0
You need to be logged in to leave comments. Login now