Refactoring in all threads view

boards/views/all_threads.py

@@ -13,6 +13,8 b' from boards.views.base import BaseBoardV'
 from boards.views.posting_mixin import PostMixin
 import neboard
 
+TAG_DELIMITER = ' '
+
 PARAMETER_CURRENT_PAGE = 'current_page'
 PARAMETER_PAGINATOR = 'paginator'
 PARAMETER_THREADS = 'threads'
@@ -48,7 +50,7 b' class AllThreadsView(PostMixin, BaseBoar'
         form.session = request.session
 
         if form.is_valid():
-            return self._new_post(request, form)
+            return self.create_thread(request, form)
         if form.need_to_ban:
             # Ban user because he is suspected to be a bot
             self._ban_current_user(request)
@@ -64,11 +66,27 b' class AllThreadsView(PostMixin, BaseBoar'
         context[PARAMETER_PAGINATOR] = paginator
         context[PARAMETER_CURRENT_PAGE] = paginator.page(int(page))
 
-    # TODO This method should be refactored
+    def parse_tags_string(self, tag_strings):
+        """
+        Parses tag list string and returns tag object list.
+        """
+
+        tags = []
+
+        if tag_strings:
+            tag_strings = tag_strings.split(TAG_DELIMITER)
+            for tag_name in tag_strings:
+                tag_name = string.lower(tag_name.strip())
+                if len(tag_name) > 0:
+                    tag, created = Tag.objects.get_or_create(name=tag_name)
+                    tags.append(tag)
+
+        return tags
+
     @transaction.atomic
-    def _new_post(self, request, form, opening_post=None, html_response=True):
+    def create_thread(self, request, form, html_response=True):
         """
-        Add a new thread opening post.
+        Creates a new thread with an opening post.
         """
 
         ip = utils.get_client_ip(request)
@@ -92,31 +110,20 b' class AllThreadsView(PostMixin, BaseBoar'
         else:
             image = None
 
-        tags = []
-
         tag_strings = data['tags']
 
-        if tag_strings:
-            tag_strings = tag_strings.split(' ')
-            for tag_name in tag_strings:
-                tag_name = string.lower(tag_name.strip())
-                if len(tag_name) > 0:
-                    tag, created = Tag.objects.get_or_create(name=tag_name)
-                    tags.append(tag)
+        tags = self.parse_tags_string(tag_strings)
 
         post = Post.objects.create_post(title=title, text=text, ip=ip,
                                         image=image, tags=tags,
                                         user=self._get_user(request))
 
-        thread_to_show = (opening_post.id if opening_post else post.id)
-
         if html_response:
-            if opening_post:
-                return redirect(
-                    reverse('thread', kwargs={'post_id': thread_to_show}) +
-                    '#' + str(post.id))
-            else:
-                return redirect('thread', post_id=thread_to_show)
+            return redirect(post.get_url())
 
     def get_threads(self):
+        """
+        Gets list of threads that will be shown on a page.
+        """
+
         return Thread.objects.filter(archived=False).order_by('-bump_time')

boards/views/tag_threads.py

@@ -39,7 +39,7 b' class TagView(AllThreadsView, Dispatcher'
         form.session = request.session
 
         if form.is_valid():
-            return self._new_post(request, form)
+            return self.create_thread(request, form)
         if form.need_to_ban:
             # Ban user because he is suspected to be a bot
             self._ban_current_user(request)