Updating last_update time if the thread in autoupdate

boards/static/js/thread_update.js

@@ -1,241 +1,270 b''
 /*
  @licstart  The following is the entire license notice for the
  JavaScript code in this page.
 
 
  Copyright (C) 2013  neko259
 
  The JavaScript code in this page is free software: you can
  redistribute it and/or modify it under the terms of the GNU
  General Public License (GNU GPL) as published by the Free Software
  Foundation, either version 3 of the License, or (at your option)
  any later version.  The code is distributed WITHOUT ANY WARRANTY;
  without even the implied warranty of MERCHANTABILITY or FITNESS
  FOR A PARTICULAR PURPOSE.  See the GNU GPL for more details.
 
  As additional permission under GNU GPL version 3 section 7, you
  may distribute non-source (e.g., minimized or compacted) forms of
  that code without the copy of the GNU GPL normally required by
  section 4, provided you include this license notice and a URL
  through which recipients can access the Corresponding Source.
 
  @licend  The above is the entire license notice
  for the JavaScript code in this page.
  */
 
 var THREAD_UPDATE_DELAY = 10000;
 
 var loading = false;
 var lastUpdateTime = null;
 var unreadPosts = 0
 
 function blink(node) {
     var blinkCount = 2;
 
     var nodeToAnimate = node;
     for (var i = 0; i < blinkCount; i++) {
         nodeToAnimate = nodeToAnimate.fadeTo('fast', 0.5).fadeTo('fast', 1.0);
     }
 }
 
 function updateThread() {
     if (loading) {
         return;
     }
 
     loading = true;
 
     var threadPosts = $('div.thread').children('.post');
 
     var lastPost = threadPosts.last();
     var threadId = threadPosts.first().attr('id');
 
     var diffUrl = '/api/diff_thread/' + threadId + '/' + lastUpdateTime + '/';
     $.getJSON(diffUrl)
         .success(function(data) {
             var bottom = isPageBottom();
 
+            var lastUpdate = '';
+
             var addedPosts = data.added;
             for (var i = 0; i < addedPosts.length; i++) {
                 var postText = addedPosts[i];
 
                 var post = $(postText);
+
+                if (lastUpdate === '') {
+                    lastUpdate = post.find('.pub_time').text();
+                }
+
                 post.appendTo(lastPost.parent());
                 addRefLinkPreview(post[0]);
 
                 lastPost = post;
                 blink(post);
             }
 
             var updatedPosts = data.updated;
             for (var i = 0; i < updatedPosts.length; i++) {
                 var postText = updatedPosts[i];
 
                 var post = $(postText);
+
+                if (lastUpdate === '') {
+                    lastUpdate = post.find('.pub_time').text();
+                }
+
                 var postId = post.attr('id');
 
                 var oldPost = $('div.thread').children('.post[id=' + postId + ']');
                 
                 oldPost.replaceWith(post);
                 addRefLinkPreview(post[0]);
 
                 blink(post);
             }
             
             // TODO Process deleted posts
 
             lastUpdateTime = data.last_update;
             loading = false;
 
             if (bottom) {
                 var $target = $('html,body');
                 $target.animate({scrollTop: $target.height()}, 1000);
             }
 
-            $('#reply-count').text(getReplyCount());
-            $('#image-count').text(getImageCount());
+            var hasPostChanges = (updatedPosts.length > 0)
+                || (addedPosts.length > 0);
+            if (hasPostChanges) {
+                updateMetadataPanel(lastUpdate);
+            }
 
             updateBumplimitProgress(data.added.length);
             updatePostBumpableStatus();
 
             if (data.added.length + data.updated.length > 0) {
                 showNewPostsTitle(data.added.length);
             }
         })
         .error(function(data) {
             // TODO Show error message that server is unavailable?
 
             loading = false;
         });
 }
 
 function isPageBottom() {
     var scroll = $(window).scrollTop() / ($(document).height()
         - $(window).height())
 
     return scroll == 1
 }
 
 function initAutoupdate() {
     loading = false;
 
     lastUpdateTime = $('.metapanel').attr('data-last-update');
 
     setInterval(updateThread, THREAD_UPDATE_DELAY);
 }
 
 function getReplyCount() {
     return $('.thread').children('.post').length
 }
 
 function getImageCount() {
     return $('.thread').find('img').length
 }
 
+function updateMetadataPanel(lastUpdate) {
+    var replyCountField = $('#reply-count');
+    var imageCountField = $('#image-count');
+
+    replyCountField.text(getReplyCount());
+    imageCountField.text(getImageCount());
+
+    if (lastUpdate !== '') {
+        var lastUpdateField = $('#last-update');
+        lastUpdateField.text(lastUpdate);
+        blink(lastUpdateField);
+    }
+
+    blink(replyCountField);
+    blink(imageCountField);
+}
+
 /**
  * Update bumplimit progress bar
  */
 function updateBumplimitProgress(postDelta) {
     var progressBar = $('#bumplimit_progress');
     if (progressBar) {
         var postsToLimitElement = $('#left_to_limit');
 
         var oldPostsToLimit = parseInt(postsToLimitElement.text());
         var postCount = getReplyCount();
         var bumplimit = postCount - postDelta + oldPostsToLimit;
 
         var newPostsToLimit = bumplimit - postCount;
         if (newPostsToLimit <= 0) {
             $('.bar-bg').remove();
         } else {
             postsToLimitElement.text(newPostsToLimit);
             progressBar.width((100 - postCount / bumplimit * 100.0) + '%');
         }
     }
 }
 
 /**
  * If the bumplimit is reached, add dead_post class to all posts
  */
 function updatePostBumpableStatus() {
-    var postCount = getReplyCount();
     var postsToLimitElement = $('#left_to_limit');
-    var postsToLimit = parseInt(postsToLimitElement.text());
 
-    if (postsToLimit <= 0) {
-        $('.thread').find('.post').addClass('dead_post');
+    if (postsToLimitElement === null) {
+        $('.thread').children('.post').addClass('dead_post');
     }
 }
 
 var documentOriginalTitle = '';
 /**
  * Show 'new posts' text in the title if the document is not visible to a user
  */
 function showNewPostsTitle(newPostCount) {
     if (document.hidden) {
         if (documentOriginalTitle === '') {
             documentOriginalTitle = document.title;
         }
         unreadPosts = unreadPosts + newPostCount;
         document.title = '[' + unreadPosts + '] ' + documentOriginalTitle;
 
         document.addEventListener('visibilitychange', function() {
             if (documentOriginalTitle !== '') {
                 document.title = documentOriginalTitle;
                 documentOriginalTitle = '';
                 unreadPosts = 0;
             }
 
             document.removeEventListener('visibilitychange', null);
         });
     }
 }
 
 /**
  * Clear all entered values in the form fields
  */
 function resetForm(form) {
     form.find('input:text, input:password, input:file, select, textarea').val('');
     form.find('input:radio, input:checkbox')
              .removeAttr('checked').removeAttr('selected');
 }
 
 
 $(document).ready(function(){
     initAutoupdate();
 
     // Post form data over AJAX
     var threadId = $('div.thread').children('.post').first().attr('id');;
 
     var form = $('#form');
     var options = {
         success: updateOnPost,
         url: '/api/add_post/' + threadId + '/',
     };
 
     form.ajaxForm(options);
 
     function updateOnPost(response, statusText, xhr, $form) {
          var json = $.parseJSON(response);
          var status = json.status;
 
          form.children('.form-errors').remove();
 
          if (status === 'ok') {
              resetForm(form);
              updateThread();
          } else {
              var errors = json.errors;
              for (var i = 0; i < errors.length; i++) {
-                 var error = errors[i];
+                 var fieldErrors = errors[i];
 
-                 var fieldName = error.field;
-                 var error = error.errors;
+                 var error = fieldErrors.errors;
 
                  var errorList = $('<div class="form-errors">' + error
                      + '<div>');
                  errorList.appendTo(form);
              }
          }
      }
 });

boards/templates/boards/post.html

@@ -1,74 +1,74 b''
 {% load i18n %}
 {% load board %}
 
 {% spaceless %}
 {% if post.thread_new.archived %}
     <div class="post archive_post" id="{{ post.id }}">
 {% elif post.thread_new.can_bump %}
     <div class="post" id="{{ post.id }}">
 {% else %}
     <div class="post dead_post" id="{{ post.id }}">
 {% endif %}
 
 {% if post.image %}
     <div class="image">
         <a
                 class="thumb"
                 href="{{ post.image.url }}"><img
                 src="{{ post.image.url_200x150 }}"
                 alt="{{ post.id }}"
                 width="{{ post.image_pre_width }}"
                 height="{{ post.image_pre_height }}"
                 data-width="{{ post.image_width }}"
                 data-height="{{ post.image_height }}"/>
         </a>
     </div>
 {% endif %}
 <div class="message">
     <div class="post-info">
         <span class="title">{{ post.title }}</span>
         <a class="post_id" href="{% post_url post.id %}">
             ({{ post.id }})</a>
-        [{{ post.pub_time }}]
+        [<span class="pub_time">{{ post.pub_time }}</span>]
         [<a href="#" onclick="javascript:addQuickReply('{{ post.id }}')
             ; return false;">&gt;&gt;</a>]
 
         {% if moderator %}
             <span class="moderator_info">
                             [<a href="{% url 'delete' post_id=post.id %}"
                     >{% trans 'Delete' %}</a>]
                             ({{ post.poster_ip }})
                             [<a href="{% url 'ban' post_id=post.id %}?next={{ request.path }}"
                     >{% trans 'Ban IP' %}</a>]
                         </span>
         {% endif %}
     </div>
     {% autoescape off %}
         {% if truncated %}
             {{ post.text.rendered|truncatewords_html:50 }}
         {% else %}
             {{ post.text.rendered }}
         {% endif %}
     {% endautoescape %}
     {% if post.is_referenced %}
         <div class="refmap">
         {% trans "Replies" %}:
         {% for ref_post in post.get_sorted_referenced_posts %}
         <a href="{% post_url ref_post.id %}">&gt;&gt;{{ ref_post.id }}</a
             >{% if not forloop.last %},{% endif %}
         {% endfor %}
         </div>
     {% endif %}
 </div>
 {% if post.is_opening and post.thread_new.tags.exists %}
     <div class="metadata">
         <span class="tags">
             {% for tag in post.thread_new.get_tags %}
                 <a class="tag" href="{% url 'tag' tag.name %}">
                     #{{ tag.name }}</a>{% if not forloop.last %},{% endif %}
             {% endfor %}
         </span>
     </div>
 {% endif %}
 </div>
 {% endspaceless %}

boards/templates/boards/thread.html

@@ -1,145 +1,145 b''
 {% extends "boards/base.html" %}
 
 {% load i18n %}
 {% load cache %}
 {% load static from staticfiles %}
 {% load board %}
 
 {% block head %}
     <title>{{ thread.get_opening_post.get_title|striptags|truncatewords:10 }} - Neboard</title>
 {% endblock %}
 
 {% block content %}
     {% spaceless %}
     {% get_current_language as LANGUAGE_CODE %}
 
     {% cache 600 thread_view thread.id thread.last_edit_time moderator LANGUAGE_CODE %}
 
         <div class="image-mode-tab">
             <a class="current_mode" href="{% url 'thread' thread.get_opening_post.id %}">{% trans 'Normal mode' %}</a>,
             <a href="{% url 'thread_mode' thread.get_opening_post.id 'gallery' %}">{% trans 'Gallery mode' %}</a>
         </div>
 
         {% if bumpable %}
             <div class="bar-bg">
                 <div class="bar-value" style="width:{{ bumplimit_progress }}%" id="bumplimit_progress">
                 </div>
                 <div class="bar-text">
                     <span id="left_to_limit">{{ posts_left }}</span> {% trans 'posts to bumplimit' %}
                 </div>
             </div>
         {% endif %}
     <div class="thread">
     {% for post in posts %}
         {% if bumpable %}
             <div class="post" id="{{ post.id }}">
         {% elif thread.archived %}
             <div class="post archive_post" id="{{ post.id }}">
         {% else %}
             <div class="post dead_post" id="{{ post.id }}">
         {% endif %}
         {% if post.image %}
             <div class="image">
                 <a
                         class="thumb"
                         href="{{ post.image.url }}"><img
                         src="{{ post.image.url_200x150 }}"
                         alt="{{ post.id }}"
                         width="{{ post.image_pre_width }}"
                         height="{{ post.image_pre_height }}"
                         data-width="{{ post.image_width }}"
                         data-height="{{ post.image_height }}"/>
                 </a>
             </div>
         {% endif %}
         <div class="message">
             <div class="post-info">
                 <span class="title">{{ post.title }}</span>
                 <a class="post_id" href="#{{ post.id }}">
                     ({{ post.id }})</a>
-                [{{ post.pub_time }}]
+                [<span class="pub_time">{{ post.pub_time }}</span>]
             {% if not thread.archived %}
             [<a href="#" onclick="javascript:addQuickReply('{{ post.id }}')
                 ; return false;">&gt;&gt;</a>]
             {% endif %}
 
                 {% if moderator %}
                     <span class="moderator_info">
                         [<a href="{% url 'delete' post_id=post.id %}"
                             >{% trans 'Delete' %}</a>]
                         ({{ post.poster_ip }})
                         [<a href="{% url 'ban' post_id=post.id %}?next={{ request.path }}"
                             >{% trans 'Ban IP' %}</a>]
                     </span>
                 {% endif %}
             </div>
             {% autoescape off %}
             {{ post.text.rendered }}
             {% endautoescape %}
     {% if post.is_referenced %}
         <div class="refmap">
         {% trans "Replies" %}:
         {% for ref_post in post.get_sorted_referenced_posts %}
         <a href="{% post_url ref_post.id %}">&gt;&gt;{{ ref_post.id }}</a
                 >{% if not forloop.last %},{% endif %}
         {% endfor %}
         </div>
     {% endif %}
         </div>
         {% if forloop.first %}
             <div class="metadata">
                 <span class="tags">
                     {% for tag in thread.get_tags %}
                         <a class="tag" href="{% url 'tag' tag.name %}">
                             #{{ tag.name }}</a
                                 >{% if not forloop.last %},{% endif %}
                     {% endfor %}
                 </span>
             </div>
         {% endif %}
         </div>
     {% endfor %}
     </div>
     {% endcache %}
 
     {% if not thread.archived %}
 
     <div class="post-form-w">
         <script src="{% static 'js/panel.js' %}"></script>
         <div class="form-title">{% trans "Reply to thread" %} #{{ thread.get_opening_post.id }}</div>
         <div class="post-form">
             <form id="form" enctype="multipart/form-data" method="post"
                     >{% csrf_token %}
                 {{ form.as_div }}
                 <div class="form-submit">
                     <input type="submit" value="{% trans "Post" %}"/>
                 </div>
             </form>
             <div><a href="{% url "staticpage" name="help" %}">
                 {% trans 'Text syntax' %}</a></div>
         </div>
     </div>
 
     <script src="{% static 'js/jquery.form.min.js' %}"></script>
     <script src="{% static 'js/thread_update.js' %}"></script>
     {% endif %}
 
     <script src="{% static 'js/thread.js' %}"></script>
 
     {% endspaceless %}
 {% endblock %}
 
 {% block metapanel %}
 
     {% get_current_language as LANGUAGE_CODE %}
 
     <span class="metapanel" data-last-update="{{ last_update }}">
         {% cache 600 thread_meta thread.last_edit_time moderator LANGUAGE_CODE %}
             <span id="reply-count">{{ thread.get_reply_count }}</span> {% trans 'replies' %},
             <span id="image-count">{{ thread.get_images_count }}</span> {% trans 'images' %}.
-            {% trans 'Last update: ' %}{{ thread.last_edit_time }}
+            {% trans 'Last update: ' %}<span id="last-update">{{ thread.last_edit_time }}</span>
             [<a href="rss/">RSS</a>]
         {% endcache %}
     </span>
 
 {% endblock %}

todo.txt

@@ -1,48 +1,27 b''
 = Features =
-[DONE] Connecting tags to each other
-[DONE] Connect posts to the replies (in messages), get rid of the JS reply map
-[DONE] Better django admin pages to simplify admin operations
-[DONE] Regen script to update all posts
-[DONE] Remove jump links from refmaps
-[DONE] Ban reasons. Split bans into 2 types "read-only" and "read
-denied". Use second only for autoban for spam
-[DONE] Clean up tests and make them run ALWAYS
-[DONE] Use transactions in tests
-[DONE] Thread autoupdate (JS + API)
-[DONE] Split up post model into post and thread,
-and move everything that is used only in 1st post to thread model.
-[DONE] Show board speed in the lower panel (posts per day)
-[DONE] Save image thumbnails size to the separate field
-
 [NOT STARTED] Tree view (JS)
 [NOT STARTED] Adding tags to images filename
 [NOT STARTED] Federative network for s2s communication
 [NOT STARTED] XMPP gate
 [NOT STARTED] Bitmessage gate
 [NOT STARTED] Notification engine
 [NOT STARTED] Javascript disabling engine
 [NOT STARTED] Group tags by first letter in all tags list
 [NOT STARTED] Character counter in the post field
 [NOT STARTED] Whitelist functionality. Permin autoban of an address
 [NOT STARTED] Statistics module. Count views (optional, may result in bad
  performance), posts per day/week/month, users (or IPs)
 [NOT STARTED] Quote button next to "reply" for posts in thread to include full
 post or its part (delimited by N characters) into quote of the new post.
 [NOT STARTED] Ban confirmation page with reason
 [NOT STARTED] Post deletion confirmation page
 [NOT STARTED] Moderating page. Tags editing and adding
 [NOT STARTED] Get thread graph image using pygraphviz
-[NOT STARTED] Creating post via AJAX without reloading page
 [NOT STARTED] Subscribing to tag via AJAX
 
 = Bugs =
-[DONE] Fix bug with creating threads from tag view
-[DONE] Quote characters within quote causes quote parsing to fail
-
-[IN PROGRESS] Replies, images, last update time in bottom panel doesn't change when
-thread updates (last update changing left)
 
 = Testing =
 [NOT STARTED] Make tests for every view
 [NOT STARTED] Make tests for every model
 [NOT STARTED] Make tests for every form