Rename "pull" request to "list"

boards/management/commands/sync_with_server.py

@@ -27,7 +27,7 b' class Command(BaseCommand):'
     def handle(self, *args, **options):
         url = options.get('url')
 
-        pull_url = url + 'api/sync/pull/'
+        list_url = url + 'api/sync/list/'
         get_url = url + 'api/sync/get/'
         file_url = url[:-1]
 
@@ -52,8 +52,8 b' class Command(BaseCommand):'
                 raise Exception('Invalid global ID')
         else:
             h = httplib2.Http()
-            xml = GlobalId.objects.generate_request_pull()
-            response, content = h.request(pull_url, method="POST", body=xml)
+            xml = GlobalId.objects.generate_request_list()
+            response, content = h.request(list_url, method="POST", body=xml)
 
             print(content.decode() + '\n')
 

boards/models/post/sync.py

@@ -231,7 +231,7 b' class SyncManager:'
             raise SyncException(EXCEPTION_NODE.format(tag_status.text))
 
     @staticmethod
-    def generate_response_pull():
+    def generate_response_list():
         response = et.Element(TAG_RESPONSE)
 
         status = et.SubElement(response, TAG_STATUS)

boards/models/signature.py

@@ -8,7 +8,7 b" TAG_REQUEST = 'request'"
 TAG_ID = 'id'
 
 TYPE_GET = 'get'
-TYPE_PULL = 'pull'
+TYPE_LIST = 'list'
 
 ATTR_VERSION = 'version'
 ATTR_TYPE = 'type'
@@ -39,13 +39,13 b' class GlobalIdManager(models.Manager):'
 
         return et.tostring(request, 'unicode')
 
-    def generate_request_pull(self):
+    def generate_request_list(self):
         """
         Form a pull request from a list of ModelId objects.
         """
 
         request = et.Element(TAG_REQUEST)
-        request.set(ATTR_TYPE, TYPE_PULL)
+        request.set(ATTR_TYPE, TYPE_LIST)
         request.set(ATTR_VERSION, '1.0')
 
         model = et.SubElement(request, TAG_MODEL)

boards/urls.py

@@ -1,5 +1,4 b''
 from django.conf.urls import url
-#from django.views.i18n import javascript_catalog
 
 import neboard
 
@@ -9,10 +8,9 b' from boards.views import api, tag_thread'
     settings, all_tags, feed
 from boards.views.authors import AuthorsView
 from boards.views.notifications import NotificationView
-from boards.views.search import BoardSearchView
 from boards.views.static import StaticPageView
 from boards.views.preview import PostPreviewView
-from boards.views.sync import get_post_sync_data, response_get, response_pull
+from boards.views.sync import get_post_sync_data, response_get, response_list
 from boards.views.random import RandomImageView
 from boards.views.tag_gallery import TagGalleryView
 from boards.views.translation import cached_javascript_catalog
@@ -78,9 +76,8 b' urlpatterns = ['
     url(r'^api/new_posts/$', api.api_get_new_posts, name='new_posts'),
 
     # Sync protocol API
-    url(r'^api/sync/pull/$', response_pull, name='api_sync_pull'),
-    url(r'^api/sync/get/$', response_get, name='api_sync_pull'),
-    # TODO 'get' request
+    url(r'^api/sync/list/$', response_list, name='api_sync_list'),
+    url(r'^api/sync/get/$', response_get, name='api_sync_get'),
 
     # Notifications
     url(r'^notifications/(?P<username>\w+)/$', NotificationView.as_view(), name='notifications'),

boards/views/sync.py

@@ -6,13 +6,13 b' from boards.models import GlobalId, Post'
 from boards.models.post.sync import SyncManager
 
 
-def response_pull(request):
+def response_list(request):
     request_xml = request.body
 
-    if request_xml is None:
+    if request_xml is None or len(request_xml) == 0:
         return HttpResponse(content='Use the API')
 
-    response_xml = SyncManager.generate_response_pull()
+    response_xml = SyncManager.generate_response_list()
 
     return HttpResponse(content=response_xml)
 
@@ -25,7 +25,7 b' def response_get(request):'
 
     request_xml = request.body
 
-    if request_xml is None:
+    if request_xml is None or len(request_xml) == 0:
         return HttpResponse(content='Use the API')
 
     posts = []

docs/dip-1.markdown

@@ -61,15 +61,15 b' responsible for validating it.'
 
 The server is required to return the status of request. See 3.2 for details.
 
-### 3.1.1 pull ###
+### 3.1.1 list ###
 
-"pull" request gets the desired model id list by the given filter (e.g. thread, tags,
+"list" request gets the desired model id list by the given filter (e.g. thread, tags,
 author)
 
 Sample request is as follows:
 
     <?xml version="1.1" encoding="UTF-8" ?>
-    <request version="1.0" type="pull">
+    <request version="1.0" type="list">
         <model version="1.0" name="post">
             <timestamp_from>0</timestamp_from>
             <timestamp_to>0</timestamp_to>