Added type hints to some models and managers

boards/models/post.py

@@ -124,7 +124,7 b' class PostManager(models.Manager):'
             post.delete()
 
     @cached_result
-    def get_posts_per_day(self):
+    def get_posts_per_day(self) -> float:
         """
         Gets average count of posts per day for the last 7 days
         """
@@ -200,6 +200,7 b' class Post(models.Model, Viewable):'
 
         self.refmap = ', '.join(post_urls)
 
+    # TODO Is this still needed?
     def get_sorted_referenced_posts(self):
         return self.refmap
 
@@ -232,18 +233,18 b' class Post(models.Model, Viewable):'
     def get_thread(self):
         return self.thread
 
-    def get_threads(self):
+    def get_threads(self) -> list:
         """
         Gets post's thread.
         """
 
         return self.threads
 
-    def get_referenced_posts(self):
+    def get_referenced_posts(self) -> list:
         return self.referenced_posts.only('id', 'threads')
 
     def get_view(self, moderator=False, need_open_link=False,
-                 truncated=False, *args, **kwargs):
+                 truncated=False, *args, **kwargs) -> str:
         """
         Renders post's HTML view. Some of the post params can be passed over
         kwargs for the means of caching (if we view the thread, some params
@@ -296,7 +297,7 b' class Post(models.Model, Viewable):'
             'Deleted post {}'.format(self))
 
     def get_post_data(self, format_type=DIFF_TYPE_JSON, request=None,
-                      include_last_update=False):
+                      include_last_update=False) -> str:
         """
         Gets post HTML or JSON data that can be rendered on a page or used by
         API.

boards/models/thread.py

@@ -8,6 +8,7 b' from boards import settings'
 import boards
 from boards.utils import cached_result
 from boards.models.post import Post
+from boards.models.tag import Tag
 
 
 __author__ = 'neko259'
@@ -59,7 +60,7 b' class Thread(models.Model):'
     bumpable = models.BooleanField(default=True)
     max_posts = models.IntegerField(default=settings.MAX_POSTS_PER_THREAD)
 
-    def get_tags(self):
+    def get_tags(self) -> list:
         """
         Gets a sorted tag list.
         """
@@ -78,7 +79,7 b' class Thread(models.Model):'
 
             logger.info('Bumped thread %d' % self.id)
 
-    def has_post_limit(self):
+    def has_post_limit(self) -> bool:
         return self.max_posts > 0
 
     def update_bump_status(self):
@@ -86,21 +87,21 b' class Thread(models.Model):'
             self.bumpable = False
             self.update_posts_time()
 
-    def get_reply_count(self):
+    def get_reply_count(self) -> int:
         return self.get_replies().count()
 
-    def get_images_count(self):
+    def get_images_count(self) -> int:
         return self.get_replies().annotate(images_count=Count(
                 'images')).aggregate(Sum('images_count'))['images_count__sum']
 
-    def can_bump(self):
+    def can_bump(self) -> bool:
         """
         Checks if the thread can be bumped by replying to it.
         """
 
         return self.bumpable and not self.archived
 
-    def get_last_replies(self):
+    def get_last_replies(self) -> list:
         """
         Gets several last replies, not including opening post
         """
@@ -116,7 +117,7 b' class Thread(models.Model):'
 
                 return last_replies
 
-    def get_skipped_replies_count(self):
+    def get_skipped_replies_count(self) -> int:
         """
         Gets number of posts between opening post and last replies.
         """
@@ -125,7 +126,7 b' class Thread(models.Model):'
                                  reply_count - 1)
         return reply_count - last_replies_count - 1
 
-    def get_replies(self, view_fields_only=False):
+    def get_replies(self, view_fields_only=False) -> list:
         """
         Gets sorted thread posts
         """
@@ -136,7 +137,7 b' class Thread(models.Model):'
             query = query.defer('poster_ip')
         return query.all()
 
-    def get_replies_with_images(self, view_fields_only=False):
+    def get_replies_with_images(self, view_fields_only=False) -> list:
         """
         Gets replies that have at least one image attached
         """
@@ -144,14 +145,14 b' class Thread(models.Model):'
         return self.get_replies(view_fields_only).annotate(images_count=Count(
             'images')).filter(images_count__gt=0)
 
-    def add_tag(self, tag):
+    def add_tag(self, tag: Tag):
         """
         Connects thread to a tag and tag to a thread
         """
 
         self.tags.add(tag)
 
-    def get_opening_post(self, only_id=False):
+    def get_opening_post(self, only_id=False) -> Post:
         """
         Gets the first post of the thread
         """
@@ -164,7 +165,7 b' class Thread(models.Model):'
         return opening_post
 
     @cached_result
-    def get_opening_post_id(self):
+    def get_opening_post_id(self) -> int:
         """
         Gets ID of the first thread post.
         """
@@ -191,7 +192,7 b' class Thread(models.Model):'
     def __str__(self):
         return 'T#{}/{}'.format(self.id, self.get_opening_post_id())
 
-    def get_tag_url_list(self):
+    def get_tag_url_list(self) -> list:
         return boards.models.Tag.objects.get_tag_url_list(self.get_tags())
 
     def update_posts_time(self):