404 page now returns the 404 status for real. Fixed some tests related to

this. Excluded ban view from the view tests because it returns 404 if the user
is not banned

boards/tests/test_pages.py

@@ -1,56 +1,52 b''
 from django.test import TestCase, Client
 from boards.models import Tag, Post
 
 TEST_TEXT = 'test'
 
 NEW_THREAD_PAGE = '/'
 THREAD_PAGE_ONE = '/thread/1/'
 THREAD_PAGE = '/thread/'
 TAG_PAGE = '/tag/'
-HTTP_CODE_REDIRECT = 302
+HTTP_CODE_REDIRECT = 301
 HTTP_CODE_OK = 200
 HTTP_CODE_NOT_FOUND = 404
 
-PAGE_404 = 'boards/404.html'
-
 
 class PagesTest(TestCase):
 
     def test_404(self):
         """Test receiving error 404 when opening a non-existent page"""
 
         tag_name = 'test_tag'
         tag = Tag.objects.create(name=tag_name)
         client = Client()
 
         Post.objects.create_post('title', TEST_TEXT, tags=[tag])
 
         existing_post_id = Post.objects.all()[0].id
         response_existing = client.get(THREAD_PAGE + str(existing_post_id) +
                                        '/')
         self.assertEqual(HTTP_CODE_OK, response_existing.status_code,
                          'Cannot open existing thread')
 
         response_not_existing = client.get(THREAD_PAGE + str(
             existing_post_id + 1) + '/')
-        self.assertEqual(PAGE_404, response_not_existing.templates[0].name,
+        self.assertEqual(HTTP_CODE_NOT_FOUND, response_not_existing.status_code,
                          'Not existing thread is opened')
 
         response_existing = client.get(TAG_PAGE + tag_name + '/')
         self.assertEqual(HTTP_CODE_OK,
                          response_existing.status_code,
                          'Cannot open existing tag')
 
         response_not_existing = client.get(TAG_PAGE + 'not_tag' + '/')
-        self.assertEqual(PAGE_404,
-                         response_not_existing.templates[0].name,
+        self.assertEqual(HTTP_CODE_NOT_FOUND, response_not_existing.status_code,
                          'Not existing tag is opened')
 
         reply_id = Post.objects.create_post('', TEST_TEXT,
                                             thread=Post.objects.all()[0]
                                             .get_thread())
         response_not_existing = client.get(THREAD_PAGE + str(
             reply_id) + '/')
-        self.assertEqual(PAGE_404,
-                         response_not_existing.templates[0].name,
+        self.assertEqual(HTTP_CODE_REDIRECT, response_not_existing.status_code,
                          'Reply is opened as a thread')

boards/tests/test_views.py

@@ -1,38 +1,46 b''
 import logging
 from django.core.urlresolvers import reverse, NoReverseMatch
 from django.test import TestCase, Client
 from boards import urls
 
 
 logger = logging.getLogger(__name__)
 
 HTTP_CODE_OK = 200
 
+EXCLUDED_VIEWS = {
+        'banned',
+}
+
 
 class ViewTest(TestCase):
 
     def test_all_views(self):
         """
         Try opening all views defined in ulrs.py that don't need additional
         parameters
         """
 
         client = Client()
         for url in urls.urlpatterns:
             try:
                 view_name = url.name
+                if view_name in EXCLUDED_VIEWS:
+                    logger.debug('View {} is excluded.'.format(view_name))
+                    continue
+
                 logger.debug('Testing view %s' % view_name)
 
                 try:
                     response = client.get(reverse(view_name))
 
                     self.assertEqual(HTTP_CODE_OK, response.status_code,
-                                     '%s view not opened' % view_name)
+                            'View not opened: {}'.format(view_name))
                 except NoReverseMatch:
                     # This view just needs additional arguments
                     pass
                 except Exception as e:
                     self.fail('Got exception %s at %s view' % (e, view_name))
             except AttributeError:
                 # This is normal, some views do not have names
                 pass

boards/views/not_found.py

@@ -1,15 +1,18 b''
 from django.shortcuts import render
 
 from boards.views.base import BaseBoardView
 
 
 class NotFoundView(BaseBoardView):
     """
     Page 404 (not found)
     """
 
     def get(self, request):
         context = self.get_context_data(request=request)
 
         # TODO Use dict here
-        return render(request, 'boards/404.html', context_instance=context)
+        response = render(request, 'boards/404.html', context_instance=context)
+        response.status_code = 404
+
+        return response