Refactored views code. This refs #16

boards/views.py

@@ -14,7 +14,7 b' import neboard'
 
 
 def index(request, page=0):
-    context = RequestContext(request)
+    context = _init_default_context(request)
 
     if utils.need_include_captcha(request):
         threadFormClass = ThreadCaptchaForm
@@ -34,11 +34,8 b' def index(request, page=0):'
 
     threads = Post.objects.get_threads(page=int(page))
 
-    # TODO Get rid of the duplicate code in index and tag views
     context['threads'] = None if len(threads) == 0 else threads
     context['form'] = form
-    context['tags'] = Tag.objects.get_popular_tags()
-    context['theme'] = _get_theme(request)
     context['pages'] = range(Post.objects.get_thread_page_count())
 
     return render(request, 'boards/posting_general.html',
@@ -106,11 +103,9 b' def tag(request, tag_name, page=0):'
         form = forms.ThreadForm(initial={'tags': tag_name},
                                 error_class=PlainErrorList)
 
-    context = RequestContext(request)
+    context = _init_default_context(request)
     context['threads'] = None if len(threads) == 0 else threads
     context['tag'] = tag_name
-    context['tags'] = Tag.objects.get_popular_tags()
-    context['theme'] = _get_theme(request)
     context['pages'] = range(Post.objects.get_thread_page_count(tag=tag))
 
     context['form'] = form
@@ -139,12 +134,10 b' def thread(request, post_id):'
 
     posts = Post.objects.get_thread(post_id)
 
-    context = RequestContext(request)
+    context = _init_default_context(request)
 
     context['posts'] = posts
     context['form'] = form
-    context['tags'] = Tag.objects.get_popular_tags()
-    context['theme'] = _get_theme(request)
 
     return render(request, 'boards/thread.html', context)
 
@@ -178,6 +171,8 b' def logout(request):'
 
 
 def settings(request):
+    """User's settings"""
+
     context = RequestContext(request)
 
     if request.method == 'POST':
@@ -198,15 +193,17 b' def settings(request):'
 
 
 def all_tags(request):
-    context = RequestContext(request)
-    context['tags'] = Tag.objects.get_popular_tags()
-    context['theme'] = _get_theme(request)
+    """All tags list"""
+
+    context = _init_default_context(request)
     context['all_tags'] = Tag.objects.get_not_empty_tags()
 
     return render(request, 'boards/tags.html', context)
 
 
 def jump_to_post(request, post_id):
+    """Determine thread in which the requested post is and open it's page"""
+
     post = get_object_or_404(Post, id=post_id)
 
     if boards.models.NO_PARENT == post.parent:
@@ -218,6 +215,8 b' def jump_to_post(request, post_id):'
 
 
 def _get_theme(request):
+    """Get user's CSS theme"""
+
     return request.session.get('theme', neboard.settings.DEFAULT_THEME)
 
 
@@ -228,3 +227,13 b' def _get_client_ip(request):'
     else:
         ip = request.META.get('REMOTE_ADDR')
     return ip
+
+
+def _init_default_context(request):
+    """Create context with default values that are used in most views"""
+
+    context = RequestContext(request)
+    context['tags'] = Tag.objects.get_popular_tags()
+    context['theme'] = _get_theme(request)
+
+    return context