##// END OF EJS Templates
Fix #4777 and #7887...
Fix #4777 and #7887 The function in charge of actually converting cursor offset to CodeMirror line number and character number was actually crashing when the cursor was at the last character (loop until undefined, then access length of variable, which is undefined). This was hiding a bug in which when you would completer to a single completion pressing tab after as-you-type filtering, the completion would be completed twice. The logic that was supposed to detect whether or not all completions had a common prefix was actually faulty as the common prefix used to be a string but was then changed to an object. Hence the logic to check whether or not there was actually a common prefix was always true, even for empty string, leading to the deletion of the line (replace by '') in some cases.

File last commit:

r12952:2f14d2ae
r20538:ae7f6d6a
Show More
payload.py
55 lines | 1.7 KiB | text/x-python | PythonLexer
Brian Granger
Adding payload module.
r2807 # -*- coding: utf-8 -*-
"""Payload system for IPython.
Authors:
* Fernando Perez
* Brian Granger
"""
#-----------------------------------------------------------------------------
Matthias BUSSONNIER
update copyright to 2011/20xx-2011...
r5390 # Copyright (C) 2008-2011 The IPython Development Team
Brian Granger
Adding payload module.
r2807 #
# Distributed under the terms of the BSD License. The full license is in
# the file COPYING, distributed as part of this software.
#-----------------------------------------------------------------------------
#-----------------------------------------------------------------------------
# Imports
#-----------------------------------------------------------------------------
from IPython.config.configurable import Configurable
Brian Granger
Fixing imports and syntax errors.
r2812 from IPython.utils.traitlets import List
Brian Granger
Adding payload module.
r2807
#-----------------------------------------------------------------------------
# Main payload class
#-----------------------------------------------------------------------------
class PayloadManager(Configurable):
Brian Granger
Fixing imports and syntax errors.
r2812 _payload = List([])
Brian Granger
Adding payload module.
r2807
Pablo de Oliveira
payload.write_payload: use `single` keyword instead of `update`...
r12933 def write_payload(self, data, single=True):
"""Include or update the specified `data` payload in the PayloadManager.
Pablo de Oliveira
PayloadManager: Fix docstring.
r12952 If a previous payload with the same source exists and `single` is True,
it will be overwritten with the new one.
Pablo de Oliveira
payload.write_payload: use `single` keyword instead of `update`...
r12933 """
Brian Granger
Fixing imports and syntax errors.
r2812 if not isinstance(data, dict):
raise TypeError('Each payload write must be a dict, got: %r' % data)
Pablo de Oliveira
set_next_input: squash multiple calls from the same cell execution...
r12931
Pablo de Oliveira
payload.write_payload: use `single` keyword instead of `update`...
r12933 if single and 'source' in data:
Pablo de Oliveira
set_next_input: squash multiple calls from the same cell execution...
r12931 source = data['source']
Pablo de Oliveira
Fix style
r12932 for i, pl in enumerate(self._payload):
Pablo de Oliveira
set_next_input: squash multiple calls from the same cell execution...
r12931 if 'source' in pl and pl['source'] == source:
self._payload[i] = data
return
Brian Granger
First working draft of new payload system.
r2814 self._payload.append(data)
Brian Granger
Adding payload module.
r2807
def read_payload(self):
return self._payload
Brian Granger
First working draft of new payload system.
r2814
def clear_payload(self):
self._payload = []